search for: error_pipe

...2002 01:21:34 -0000 *************** *** 346,351 **** --- 346,353 ---- exit_cleanup(0); } + io_start_buffering_in(f_in); + io_start_buffering_out(f_out); send_files(flist,f_out,f_in); io_flush(); report(f_out); *************** *** 421,427 **** close(error_pipe[1]); if (f_in != f_out) close(f_in); ! io_start_buffering(f_out); io_set_error_fd(error_pipe[0]); --- 423,429 ---- close(error_pipe[1]); if (f_in != f_out) close(f_in); ! io_start_buffering_out(f_out); io_set_error_fd(error_pipe[0]); *************** *** 434,44...

...d be no need for an asynchronous notification? Comments sought, meanwhile I'll test the patch a bit... Regards Anthony *** main.c.Orig Fri Jun 27 15:21:22 2003 --- main.c Fri Jun 27 15:30:09 2003 *************** *** 390,395 **** --- 390,396 ---- int status=0; int recv_pipe[2]; int error_pipe[2]; + int cleanup_pipe[2]; extern int preserve_hard_links; extern int delete_after; extern int recurse; *************** *** 416,426 **** --- 417,435 ---- exit_cleanup(RERR_SOCKETIO); } + if (pipe(cleanup_pipe) < 0) { + rprintf(FERROR,"cleanup pipe failed in do_recv\...

FYI, We've been using the 2.4.7pre1 release for several days now, with nary a hang problem. We haven't seen the EOF bug at all, which was what we upgraded for. This is with transfers of as much as 50GB to set up an initial mirror. The only thing we did was set timeout=0 -- which I guess is unnecessary. The semantics of this flag are a bit unclear. We thought was 'time since

...rk)\n", mi.arena); rprintf(FINFO, " ordblks: %10d (chunks not in use)\n", mi.ordblks); rprintf(FINFO, " smblks: %10d\n", mi.smblks); @@ -455,6 +457,8 @@ static int do_recv(int f_in,int f_out,st msleep(20); } + who_am_i = "generator"; + close(error_pipe[1]); if (f_in != f_out) close(f_in); @@ -754,6 +758,7 @@ static int start_client(int argc, char * argc--; argv++; } else { + who_am_i = "sender"; am_sender = 1; /* rsync:// destination uses rsync server over direct socket */ @@ -817,6 +822,7 @@ static int start_...

...sync/main.c Thu Aug 1 13:46:59 2002 +++ rsync-craig/main.c Sun Dec 8 17:39:07 2002 @@ -346,6 +346,8 @@ exit_cleanup(0); } + io_start_buffering_in(f_in); + io_start_buffering_out(f_out); send_files(flist,f_out,f_in); io_flush(); report(f_out); @@ -421,7 +423,7 @@ close(error_pipe[1]); if (f_in != f_out) close(f_in); - io_start_buffering(f_out); + io_start_buffering_out(f_out); io_set_error_fd(error_pipe[0]); @@ -476,6 +478,7 @@ } } + io_start_buffering_in(f_in); if (delete_mode && !delete_excluded) recv_exclude_list(f_in); @@ -569,...

...after, the deletion messages are written before the fork of the grandchild, so the bug does not manifest. ---------------------------------------------------------------------- Fix --- Looking at the code, I would suggest that main.c:do_recv() be modified as follows: - Have the grandchild close error_pipe[1] before its final sleep loop. (Why doesn't the grandchild just exit instead of sleeping? Is it only to try to avoid having to deal with a SIGCHLD in the middle of an I/O operation in the child?) - In the child, prior to the kill(), loop and call read_error_fd() until that descripto...

...if (st2.st_dev == st1.st_dev --- main.c 20 Jan 2004 17:46:31 -0000 1.183 +++ main.c 25 Jan 2004 09:19:45 -0000 @@ -409,6 +409,7 @@ static void do_server_sender(int f_in, i static int do_recv(int f_in,int f_out,struct file_list *flist,char *local_name) { + int i; int pid; int status=0; int error_pipe[2]; @@ -463,6 +464,19 @@ static int do_recv(int f_in,int f_out,st generate_files(f_out, flist, local_name); get_redo_num(); /* Read final -1, and any prior messages. */ + + if (preserve_hard_links) + do_hard_links(); + + /* now we need to fix any directory permissions that were + * modified...

People of cygwin & rsync, I recently attempted to get cygwin and rsync working to solve a backup/mirroring need in my computer life. Well, as you might guess, I ran into a little but of trouble. Strangely enough, rsync seemed to be regularly hanging when I attempted to do a "get" (sycronize a remote to a local dir). Well, considering I want to automate this, that was not going