Displaying 8 results from an estimated 8 matches for "error_in_add".
2019 Mar 23
2
Re: [PATCH nbdkit 7/8] vddk: Implement extents.
...he
> + * blocks as necessary.
> + */
> + if (position < offset) {
> + if (nbdkit_add_extent (extents,
> + offset, length,
> + NBDKIT_EXTENT_HOLE | NBDKIT_EXTENT_ZERO) == -1)
> + goto error_in_add;
> + }
> +
> + if (nbdkit_add_extent (extents,
> + offset, length, 0 /* allocated data */) == -1) {
> + error_in_add:
> + DEBUG_CALL ("VixDiskLib_FreeBlockList", "block_list");
> + VixDiskLib_FreeBlock...
2019 Mar 25
0
Re: [PATCH nbdkit 7/8] vddk: Implement extents.
...cessary.
> > + */
> > + if (position < offset) {
> > + if (nbdkit_add_extent (extents,
> > + offset, length,
> > + NBDKIT_EXTENT_HOLE | NBDKIT_EXTENT_ZERO) == -1)
> > + goto error_in_add;
> > + }
> > +
> > + if (nbdkit_add_extent (extents,
> > + offset, length, 0 /* allocated data */) == -1) {
> > + error_in_add:
> > + DEBUG_CALL ("VixDiskLib_FreeBlockList", "block_list");
>...
2019 Mar 20
0
[PATCH nbdkit 7/8] vddk: Implement extents.
...ks. We must insert holes between the
+ * blocks as necessary.
+ */
+ if (position < offset) {
+ if (nbdkit_add_extent (extents,
+ offset, length,
+ NBDKIT_EXTENT_HOLE | NBDKIT_EXTENT_ZERO) == -1)
+ goto error_in_add;
+ }
+
+ if (nbdkit_add_extent (extents,
+ offset, length, 0 /* allocated data */) == -1) {
+ error_in_add:
+ DEBUG_CALL ("VixDiskLib_FreeBlockList", "block_list");
+ VixDiskLib_FreeBlockList (block_list);
+ return...
2019 Mar 27
2
Re: [PATCH nbdkit 7/8] vddk: Implement extents.
...*/
> > > + if (position < offset) {
> > > + if (nbdkit_add_extent (extents,
> > > + offset, length,
> > > + NBDKIT_EXTENT_HOLE | NBDKIT_EXTENT_ZERO) == -1)
> > > + goto error_in_add;
> > > + }
> > > +
> > > + if (nbdkit_add_extent (extents,
> > > + offset, length, 0 /* allocated data */) == -1) {
> > > + error_in_add:
> > > + DEBUG_CALL ("VixDiskLib_FreeBlockList",...
2019 Apr 29
5
[nbdkit PATCH 0/3] Fix data integrity in vddk plugin
Couple of fixes to return correct data and one nice-to-have clean-up which is not needed. I just find it nicer to read.
Martin Kletzander (3):
vddk: Use a separate handle for single-link=true
vddk: Do not report hole extents to be zero with single-link=true
vddk: Eliminate one needless goto
plugins/vddk/vddk.c | 48 +++++++++++++++++++++++++++++++++------------
1 file changed, 36
2019 Mar 20
15
[PATCH nbdkit 0/8] Implement extents using a simpler array.
Not sure what version we're up to, but this reimplements extents using
the new simpler structure described in this thread:
https://www.redhat.com/archives/libguestfs/2019-March/msg00077.html
I also fixed most of the things that Eric pointed out in the previous
review, although I need to go back over his replies and check I've got
everything.
This needs a bit more testing. However the
2019 Mar 26
21
[PATCH nbdkit v4 00/15] Implement Block Status.
I'm not sure exactly which version we're up to, but let's say it's
version 4.
I'm a lot happier with this version:
- all filters have been reviewed and changed where I think that's necessary
- can_extents is properly defined and implemented now
- NBD protocol is followed
- I believe it addresses all previous review points where possible
The "only" thing
2019 Mar 28
32
[PATCH nbdkit v5 FINAL 00/19] Implement extents.
This has already been pushed upstream. I am simply posting these here
so we have a reference in the mailing list in case we find bugs later
(as I'm sure we will - it's a complex patch series).
Great thanks to Eric Blake for tireless review on this one. It also
seems to have identified a few minor bugs in qemu along the way.
Rich.