search for: err_buf

Hello, I found the reason why "refuse options" is ignored on the server side. When then 5th argument (int val) in the poptOption struct is set to zero, the parsing function poptGetNextOpt() just continues with the next arg, without returning. So check_refuse_options() is simply not called in such cases. The attached patch makes "refuse options" work with checksum and

...mcpy(page_address(page) + page_off, page_address(p) + offset, *len); > + page_off += *len; > + > + while (--*num_buf) { > + unsigned int buflen; > + void *buf; > + int off; > + > + buf = virtqueue_get_buf(rq->vq, &buflen); > + if (unlikely(!buf)) > + goto err_buf; > + > + p = virt_to_head_page(buf); > + off = buf - page_address(p); > + > + /* guard against a misconfigured or uncooperative backend that > + * is sending packet larger than the MTU. > + */ > + if ((page_off + buflen) > PAGE_SIZE) { > + put_page(p); > +...

...mcpy(page_address(page) + page_off, page_address(p) + offset, *len); > + page_off += *len; > + > + while (--*num_buf) { > + unsigned int buflen; > + void *buf; > + int off; > + > + buf = virtqueue_get_buf(rq->vq, &buflen); > + if (unlikely(!buf)) > + goto err_buf; > + > + p = virt_to_head_page(buf); > + off = buf - page_address(p); > + > + /* guard against a misconfigured or uncooperative backend that > + * is sending packet larger than the MTU. > + */ > + if ((page_off + buflen) > PAGE_SIZE) { > + put_page(p); > +...

...uot;exclude-from", 0, POPT_ARG_STRING, 0, OPT_EXCLUDE_FROM, 0, 0 }, --- 335,344 ---- *************** *** 659,675 **** am_server ? "server" : "client"); return 0; } #endif - if (delete_mdays!=-1 && delete_mdays<1){ - snprintf(err_buf, sizeof err_buf, - "--delete-mdays needs a positive integer argument (number of days); " - "got %d\n", delete_mdays); - return 0; - } - if (write_batch && read_batch) { snprintf(err_buf, sizeof err_buf, "--write-batch and --read-batch can not...

...GFP_ATOMIC); + + if (!page) + return NULL; + + memcpy(page_address(page) + page_off, page_address(p) + offset, *len); + page_off += *len; + + while (--*num_buf) { + unsigned int buflen; + void *buf; + int off; + + buf = virtqueue_get_buf(rq->vq, &buflen); + if (unlikely(!buf)) + goto err_buf; + + p = virt_to_head_page(buf); + off = buf - page_address(p); + + /* guard against a misconfigured or uncooperative backend that + * is sending packet larger than the MTU. + */ + if ((page_off + buflen) > PAGE_SIZE) { + put_page(p); + goto err_buf; + } + + memcpy(page_address(pag...

...head_skb->dev->name, hdr->mhdr.num_buffers); - head_skb->dev->stats.rx_length_errors++; - return -EINVAL; + pr_debug("%s: rx error: %d buffers out of %d missing\n", + dev->name, num_buf, hdr->mhdr.num_buffers); + dev->stats.rx_length_errors++; + goto err_buf; } if (unlikely(len > MERGE_BUFFER_LEN)) { pr_debug("%s: rx error: merge buffer too long\n", - head_skb->dev->name); + dev->name); len = MERGE_BUFFER_LEN; } + + page = virt_to_head_page(buf); + --rq->num; + + num_skb_frags = skb_shinfo(curr_skb)-...

...head_skb->dev->name, hdr->mhdr.num_buffers); - head_skb->dev->stats.rx_length_errors++; - return -EINVAL; + pr_debug("%s: rx error: %d buffers out of %d missing\n", + dev->name, num_buf, hdr->mhdr.num_buffers); + dev->stats.rx_length_errors++; + goto err_buf; } if (unlikely(len > MERGE_BUFFER_LEN)) { pr_debug("%s: rx error: merge buffer too long\n", - head_skb->dev->name); + dev->name); len = MERGE_BUFFER_LEN; } + + page = virt_to_head_page(buf); + --rq->num; + + num_skb_frags = skb_shinfo(curr_skb)-...

https://bugzilla.samba.org/show_bug.cgi?id=7869 Summary: rsync segfault Product: rsync Version: 3.0.7 Platform: x64 OS/Version: Linux Status: NEW Severity: minor Priority: P3 Component: core AssignedTo: wayned at samba.org ReportedBy: rafa.silva at gmail.com QAContact: rsync-qa at

...f, hdr->mhdr.num_buffers); @@ -329,7 +337,6 @@ static struct sk_buff *receive_mergeable(struct net_device *dev, } page = virt_to_head_page(buf); - --rq->num; num_skb_frags = skb_shinfo(curr_skb)->nr_frags; if (unlikely(num_skb_frags == MAX_SKB_FRAGS)) { @@ -370,7 +377,7 @@ err_buf: dev->stats.rx_dropped++; dev_kfree_skb(head_skb); while (--num_buf) { - buf = virtqueue_get_buf(rq->vq, &len); + buf = rq_get_buf(rq, &len); if (unlikely(!buf)) { pr_debug("%s: rx error: %d buffers missing\n", dev->name, num_buf); @@ -379,7 +386,6 @@...

...f, hdr->mhdr.num_buffers); @@ -329,7 +337,6 @@ static struct sk_buff *receive_mergeable(struct net_device *dev, } page = virt_to_head_page(buf); - --rq->num; num_skb_frags = skb_shinfo(curr_skb)->nr_frags; if (unlikely(num_skb_frags == MAX_SKB_FRAGS)) { @@ -370,7 +377,7 @@ err_buf: dev->stats.rx_dropped++; dev_kfree_skb(head_skb); while (--num_buf) { - buf = virtqueue_get_buf(rq->vq, &len); + buf = rq_get_buf(rq, &len); if (unlikely(!buf)) { pr_debug("%s: rx error: %d buffers missing\n", dev->name, num_buf); @@ -379,7 +386,6 @@...

...+ case 'Z': refused_compress = op->val; break; case '\0': @@ -1575,6 +1586,16 @@ int parse_arguments(int *argc_p, const char ***argv_p) do_compression++; break; + case 'Z': +#ifdef HAVE_LIBZSTD + do_compression_zstd++; +#else + snprintf(err_buf, sizeof err_buf, + "Support for zstd is not enabled.\n"); + return 0; +#endif + break; + case 'M': arg = poptGetOptArg(pc); if (*arg != '-') { @@ -1856,7 +1877,12 @@ int parse_arguments(int *argc_p, const char ***argv_p) exit_cleanup(0); } - if (...

...def INET6 {0, '4', POPT_ARG_VAL, &default_af_hint, AF_INET , 0, 0 }, {0, '6', POPT_ARG_VAL, &default_af_hint, AF_INET6 , 0, 0 }, @@ -586,6 +592,20 @@ return 0; } + if ((force_f_in == -1) && (force_f_out != -1)) { + snprintf(err_buf,sizeof(err_buf), + "fd-out can not be used without fd-in\n"); + rprintf(FERROR,"ERROR: fd-out can not be used without fd-in\n"); + return 0; + } + if ((force_f_out == -1) && (force_f_in != -1)) { + snprintf(err_buf,sizeof(err_buf), + "fd-in can not be...

...ng\n", - skb->dev->name, hdr->mhdr.num_buffers); - skb->dev->stats.rx_length_errors++; - return -EINVAL; + pr_debug("%s: rx error: %d buffers %d missing\n", + dev->name, hdr->mhdr.num_buffers, num_buf); + dev->stats.rx_length_errors++; + goto err_buf; } if (len > PAGE_SIZE) @@ -326,7 +333,25 @@ static int receive_mergeable(struct receive_queue *rq, struct sk_buff *skb) --rq->num; } - return 0; + return skb; +err_skb: + give_pages(rq, page); + while (--num_buf) { + buf = virtqueue_get_buf(rq->vq, &len); + if (unlike...

...ng\n", - skb->dev->name, hdr->mhdr.num_buffers); - skb->dev->stats.rx_length_errors++; - return -EINVAL; + pr_debug("%s: rx error: %d buffers %d missing\n", + dev->name, hdr->mhdr.num_buffers, num_buf); + dev->stats.rx_length_errors++; + goto err_buf; } if (len > PAGE_SIZE) @@ -326,7 +333,25 @@ static int receive_mergeable(struct receive_queue *rq, struct sk_buff *skb) --rq->num; } - return 0; + return skb; +err_skb: + give_pages(rq, page); + while (--num_buf) { + buf = virtqueue_get_buf(rq->vq, &len); + if (unlike...

...GFP_ATOMIC); - - if (!page) - return NULL; - - memcpy(page_address(page) + page_off, page_address(p) + offset, *len); - page_off += *len; - - while (--*num_buf) { - unsigned int buflen; - void *buf; - int off; - - buf = virtqueue_get_buf(rq->vq, &buflen); - if (unlikely(!buf)) - goto err_buf; - - p = virt_to_head_page(buf); - off = buf - page_address(p); - - /* guard against a misconfigured or uncooperative backend that - * is sending packet larger than the MTU. - */ - if ((page_off + buflen) > PAGE_SIZE) { - put_page(p); - goto err_buf; - } - - memcpy(page_address(pag...

There's a rather old bug report in Debian's bug tracking system (see http://bugs.debian.org/27126) about wanting to be able to specify the maximum file size, as well as the minimum file size. Here's the text: Sometimes, it's useful to specify a file size range one is interested in. For example, I'd like to keep an up-to-date mirror of Debian, but I currently

...ng\n", - skb->dev->name, hdr->mhdr.num_buffers); - skb->dev->stats.rx_length_errors++; - return -EINVAL; + pr_debug("%s: rx error: %d buffers %d missing\n", + dev->name, hdr->mhdr.num_buffers, num_buf); + dev->stats.rx_length_errors++; + goto err_buf; } if (len > PAGE_SIZE) @@ -326,7 +333,25 @@ static int receive_mergeable(struct receive_queue *rq, struct sk_buff *skb) --rq->num; } - return 0; + return skb; +err_skb: + give_pages(rq, page); + while (--num_buf) { + buf = virtqueue_get_buf(rq->vq, &len); + if (unlike...

...ng\n", - skb->dev->name, hdr->mhdr.num_buffers); - skb->dev->stats.rx_length_errors++; - return -EINVAL; + pr_debug("%s: rx error: %d buffers %d missing\n", + dev->name, hdr->mhdr.num_buffers, num_buf); + dev->stats.rx_length_errors++; + goto err_buf; } if (len > PAGE_SIZE) @@ -326,7 +333,25 @@ static int receive_mergeable(struct receive_queue *rq, struct sk_buff *skb) --rq->num; } - return 0; + return skb; +err_skb: + give_pages(rq, page); + while (--num_buf) { + buf = virtqueue_get_buf(rq->vq, &len); + if (unlike...

...r->mhdr.num_buffers); > - head_skb->dev->stats.rx_length_errors++; > - return -EINVAL; > + pr_debug("%s: rx error: %d buffers out of %d missing\n", > + dev->name, num_buf, hdr->mhdr.num_buffers); > + dev->stats.rx_length_errors++; > + goto err_buf; Not sure it's correct here. Since the we break immediately if buffer is missed in err_buf and rx_length_error will be miss counted. Maybe an ERR_PTR(-EINVAL) is better. > } > if (unlikely(len > MERGE_BUFFER_LEN)) { > pr_debug("%s: rx error: merge buffer too long\n&...

...ot;, 0, POPT_ARG_NONE, &am_daemon , 0, 0, 0 }, @@ -591,6 +593,19 @@ /* popt stores the filename in batch_prefix for us */ read_batch = 1; break; + case OPT_LINK_DEST: +#if HAVE_LINK + compare_dest = poptGetOptArg(pc); + link_dest = 1; + break; +#else + snprintf(err_buf,sizeof(err_buf), + "hard links are not supported on this %s\n", + am_server ? "server" : "client"); + rprintf(FERROR,"ERROR: hard links not supported on this platform\n"); + return 0; +#endif + default:...