search for: erozenfeld

Hi Lang, LoadedObjectInfo::getSectionLoadAddress takes StringRef as an arg. That breaks if the object file has multiple sections with the same name. I made a change to add an overload that takes a SectionRef&. Can you please take a look? https://github.com/erozenfeld/llvm/commit/65f635e426bdc8e80a29ed370a78f0c0a282f265 Thanks, Eugene -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150723/e9a25f37/attachment.html>

...t; > > LoadedObjectInfo::getSectionLoadAddress takes StringRef as an arg. That > breaks if the object file has multiple sections with the same name. I made a > change to add an overload that takes a SectionRef&. Can you please take a > look? > > > > https://github.com/erozenfeld/llvm/commit/65f635e426bdc8e80a29ed370a78f0c0a282f265 Out of curiosity, is there any reason not to send this through the normal llvm-commits patch submission/review process? -- Meador

...> > LoadedObjectInfo::getSectionLoadAddress takes StringRef as an arg. > That breaks if the object file has multiple sections with the same > name. I made a change to add an overload that takes a SectionRef&. Can > you please take a look? > > > > https://github.com/erozenfeld/llvm/commit/65f635e426bdc8e80a29ed370a78f0c0a282f265 Out of curiosity, is there any reason not to send this through the normal llvm-commits patch submission/review process? -- Meador