search for: epollout

I was straceing a pop3 process and noticed that the TCP_CORK option isn't set soon enough: epoll_wait(8, {{EPOLLOUT, {u32=37481984, u64=37481984}}}, 38, 207) = 1 write(41, "iTxPBrNlaNFao+yQzLhuO4/+tQ5cuiKSe"..., 224) = 224 epoll_ctl(8, EPOLL_CTL_MOD, 41, {EPOLLIN|EPOLLPRI|EPOLLERR|EPOLLHUP, {u32=37481984, u64=37481984}}) = 0 pread(19, "AFABQAlAC0AJ\nQAUALQAUAFABQAlAC0AF"..., 8192, 811008) = 8...

...c.so.6 #16 0x00007fcba5a52b2d in _start () strace -tt says: 16:14:19.693378 gettimeofday({1381421659, 693415}, NULL) = 0 16:14:19.693490 time(NULL) = 1381421659 16:14:19.693588 read(18, 0x7fcba7876a43, 5) = -1 EAGAIN (Resource temporarily unavailable) 16:14:19.693688 epoll_wait(14, {{EPOLLOUT, {u32=2810463600, u64=140512665552240}}}, 10, 4294967295) = 1 16:14:19.693796 gettimeofday({1381421659, 693823}, NULL) = 0 16:14:19.693890 time(NULL) = 1381421659 16:14:19.693984 read(18, 0x7fcba7876a43, 5) = -1 EAGAIN (Resource temporarily unavailable) 16:14:19.694084 epoll_wait(14, {...

On 7.3.2019 23.37, A. Schulze via dovecot wrote: > > Am 07.03.19 um 17:33 schrieb Aki Tuomi via dovecot: > >>> test-http-client-errors.c:2989: Assert failed: FALSE >>> connection timed out ................................................. : FAILED > Hello Aki, > >> Are you running with valgrind or on really slow system? > I'm not aware my buildsystem

...x2039390) at main.c:123 strace shows this: read(11, "\27\3\1\0 q\r\252\3551\21\237l\33\330\33\303\340\306l\334k\0360p\303)HF\331\234g"..., 1261) = 37 read(11, 0xf09908, 1224) = -1 EAGAIN (Resource temporarily unavailable) epoll_ctl(10, EPOLL_CTL_MOD, 11, {EPOLLIN|EPOLLPRI|EPOLLOUT|EPOLLERR|EPOLLHUP, {u32=15754432, u64=15754432}}) = 0 epoll_ctl(10, EPOLL_CTL_MOD, 11, {EPOLLIN|EPOLLPRI|EPOLLERR|EPOLLHUP, {u32=15754432, u64=15754432}}) = 0 write(11, "\27\3\1\0 \204\375\373!\253\263n\204\274duj/\n\202\236\373\342\303[\22\17\264\10\23\346\225"..., 90) = 90 epoll_ctl(10,...

...up 100% CPU. Current revision is 10962 29865 vmail 20 0 47820 3296 1708 R 99.7 0.9 131:07.85 imap vmail 29865 86.1 0.8 47820 3296 ? R Mar20 131:20 dovecot/imap [berni 2001:a60:f001:1:219:66ff:fe8b:a6e IDLE strace -p <pid> shows a repeating pattern of epoll_wait(8, {{EPOLLOUT, {u32=36560672, u64=36560672}}}, 5, 4872) = 1 gettimeofday({1269133967, 495298}, NULL) = 0 gettimeofday({1269133967, 495333}, NULL) = 0 gettimeofday({1269133967, 495370}, NULL) = 0 with the last argument of epoll_wait (4872) slowly decrementing and then wrapping around to ~30k. Attaching gdb show...

....c > > +++ b/drivers/vhost/net.c > > @@ -1135,8 +1135,15 @@ static int vhost_net_open(struct inode *inode, struct file *f) > > } > > vhost_dev_init(dev, vqs, VHOST_NET_VQ_MAX); > > > > - vhost_poll_init(n->poll + VHOST_NET_VQ_TX, handle_tx_net, EPOLLOUT, dev); > > - vhost_poll_init(n->poll + VHOST_NET_VQ_RX, handle_rx_net, EPOLLIN, dev); > > + vhost_poll_init(n->poll + VHOST_NET_VQ_TX, > > + handle_tx_net, > > + VHOST_NET_VQ_TX, > > + EPOLLOUT,...

I managed to get a build of the async Rust handle compiling on FreeBSD (although the cirrus CI appears to not actually run 'make check' on non-Linux machines, at least when run on my fork): https://gitlab.com/ebblake/libnbd/-/jobs/4985192286 However, I'd really like Tage's review on patch 2 to see if my Rust makes sense. Eric Blake (2): maint: Favor 4-space indent in .rs files

...NET, sin_port=htons(24007), sin_addr=inet_addr("100.64.252.1")}, 16) = -1 EINPROGRESS (Operation now in progress) 4543 fcntl(5, F_GETFL) = 0x802 (flags O_RDWR|O_NONBLOCK) 4543 fcntl(5, F_SETFL, O_RDWR|O_NONBLOCK) = 0 4543 epoll_ctl(3, EPOLL_CTL_ADD, 5, {EPOLLIN|EPOLLPRI|EPOLLOUT|EPOLLONESHOT, {u32=2, u64=4952097292290}}) = 0 ... 4543 socket(PF_INET, SOCK_STREAM, IPPROTO_IP) = 7 4543 setsockopt(7, SOL_TCP, TCP_NODELAY, [1], 4) = 0 4543 setsockopt(7, SOL_SOCKET, SO_KEEPALIVE, [1], 4) = 0 4543 setsockopt(7, SOL_TCP, TCP_KEEPIDLE, [20], 4) = 0 4543 setsockopt(7, SOL_TCP,...

...close(data->epfd); + p_free(ioloop->pool, ioloop->handler_data->events); + p_free(ioloop->pool, ioloop->handler_data->fd_index); + p_free(ioloop->pool, ioloop->handler_data); +} + +#define IO_EPOLL_INPUT (EPOLLIN | EPOLLPRI | EPOLLERR | EPOLLHUP) +#define IO_EPOLL_OUTPUT (EPOLLOUT | EPOLLERR | EPOLLHUP) + +static int epoll_event_mask(struct io_list *list) +{ + int events = 0, i; + struct io *io; + + for (i = 0; i < list->count; i++) { + io = list->ios[i]; + + if (!io) + continue; + + if (io->condition & IO_READ) + events |= IO_EPOLL_INPUT; + if (io-&g...

...PE (Broken pipe) @ 0 (0) --- 13:36:05.866478 writev(1, [{"508qWWH96If+uVXeH2Zxl/hkn+plVwmI"..., 3975}, {"HP1oxt+np0o4Xtz27VQBtxx0zWfGuA3r"..., 193}], 2) = -1 EPIPE (Broken pipe) 13:36:05.866539 --- SIGPIPE (Broken pipe) @ 0 (0) --- 13:36:05.866575 epoll_ctl(6, EPOLL_CTL_ADD, 1, {EPOLLOUT|EPOLLERR|EPOLLHUP, {u32=135259776, u64=135259776}}) = 0 13:36:05.866623 setsockopt(1, SOL_TCP, TCP_CORK, [0], 4) = 0 13:36:05.866660 gettimeofday({1197372965, 866675}, NULL) = 0 13:36:05.866698 epoll_wait(6, {{EPOLLHUP, {u32=135259776, u64=135259776}}}, 4, 6986) = 1 13:36:05.866737 gettimeofday({11...

...(c->outgoing && !c->node) { (gdb) p c $1 = (connection_t *) 0x0 Here the end of strace: > read(24, "-----BEGIN RSA PUBLIC KEY-----\nM"..., 4096) = 426 > close(24) = 0 > munmap(0x7f9f1978d000, 4096) = 0 > epoll_wait(14, {{EPOLLOUT, {u32=23, u64=23}}}, 32, 4907) = 1 > sendto(23, "0 tecra 17.0\n1 94 64 0 0 A2B583B"..., 538, 0, NULL, 0) = 538 > epoll_ctl(14, EPOLL_CTL_MOD, 23, {EPOLLIN, {u32=23, u64=23}}) = 0 > epoll_wait(14, 69d660, 32, 4904) = -1 EINTR (Interrupted system call) > --- SIGALRM (Alar...

Hi: This series try to prvernt a guest triggerable CPU hogging through vhost kthread. This is done by introducing and checking the weight after each requrest. The patch has been tested with reproducer of vsock and virtio-net. Only compile test is done for vhost-scsi. Please review. This addresses CVE-2019-3900. Jason Wang (4): vhost: introduce vhost_exceeds_weight() vhost_net: fix possible

...inode, struct file *f) } vhost_dev_init(dev, vqs, VHOST_NET_VQ_MAX, UIO_MAXIOV + VHOST_NET_BATCH, - VHOST_NET_PKT_WEIGHT, VHOST_NET_WEIGHT, + VHOST_NET_PKT_WEIGHT, VHOST_NET_WEIGHT, true, NULL); vhost_poll_init(n->poll + VHOST_NET_VQ_TX, handle_tx_net, EPOLLOUT, dev); diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index c39952243fd3..0cbaa0b3893d 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -1628,7 +1628,7 @@ static int vhost_scsi_open(struct inode *inode, struct file *f) vs->vqs[i].vq.handle_kick = vhost_scsi_handle_kic...

...ile *f) vhost_net_buf_init(&n->vqs[i].rxq); } vhost_dev_init(dev, vqs, VHOST_NET_VQ_MAX, - UIO_MAXIOV + VHOST_NET_BATCH); + UIO_MAXIOV + VHOST_NET_BATCH, + VHOST_NET_WEIGHT, VHOST_NET_PKT_WEIGHT); vhost_poll_init(n->poll + VHOST_NET_VQ_TX, handle_tx_net, EPOLLOUT, dev); vhost_poll_init(n->poll + VHOST_NET_VQ_RX, handle_rx_net, EPOLLIN, dev); diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index 618fb64..d830579 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -57,6 +57,12 @@ #define VHOST_SCSI_PREALLOC_UPAGES 2048 #define VHOS...

...truct io_list { - struct io *ios[EPOLL_IOS_PER_FD]; -}; - void io_loop_handler_init(struct ioloop *ioloop) { struct ioloop_handler_data *data; @@ -74,58 +64,6 @@ void io_loop_handler_deinit(struct ioloo #define IO_EPOLL_INPUT (EPOLLIN | EPOLLPRI | EPOLLERR | EPOLLHUP) #define IO_EPOLL_OUTPUT (EPOLLOUT | EPOLLERR | EPOLLHUP) -static int epoll_event_mask(struct io_list *list) -{ - int events = 0, i; - struct io *io; - - for (i = 0; i < EPOLL_IOS_PER_FD; i++) { - io = list->ios[i]; - - if (io == NULL) - continue; - - if (io->condition & IO_READ) - events |= IO_EPOLL_INPUT; -...

Hi: This series try to prevent a guest triggerable CPU hogging through vhost kthread. This is done by introducing and checking the weight after each requrest. The patch has been tested with reproducer of vsock and virtio-net. Only compile test is done for vhost-scsi. Please review. This addresses CVE-2019-3900. Changs from V1: - fix user-ater-free in vosck patch Jason Wang (4): vhost:

Hi: This series try to prevent a guest triggerable CPU hogging through vhost kthread. This is done by introducing and checking the weight after each requrest. The patch has been tested with reproducer of vsock and virtio-net. Only compile test is done for vhost-scsi. Please review. This addresses CVE-2019-3900. Changs from V1: - fix user-ater-free in vosck patch Jason Wang (4): vhost:

...sa_family=AF_INET, sin_port=htons(110), sin_addr=inet_addr("127.0.11.106")}, 16 <unfinished ...> [pid 6756] epoll_wait(13, <unfinished ...> [pid 6771] <... connect resumed> ) = -1 EINPROGRESS (Operation now in progress) [pid 6771] epoll_ctl(9, EPOLL_CTL_ADD, 12, {EPOLLOUT|EPOLLERR|EPOLLHUP, {u32=6632256, u64=6632256}}) = 0 [pid 6771] gettimeofday({1235491268, 493619}, NULL) = 0 [pid 6771] epoll_wait(9, {{EPOLLOUT, {u32=6632256, u64=6632256}}}, 6, 179989) = 1 [pid 6771] gettimeofday({1235491268, 493987}, {0, 0}) = 0 [pid 6771] getsockopt(12, SOL_SOCKET, SO_ERROR,...

...4 vsock_stream_has_space(struct vsock_sock *vsk) { - return transport->stream_has_space(vsk); + return vsk->transport->stream_has_space(vsk); } EXPORT_SYMBOL_GPL(vsock_stream_has_space); @@ -861,6 +864,7 @@ static __poll_t vsock_poll(struct file *file, struct socket *sock, mask |= EPOLLOUT | EPOLLWRNORM | EPOLLWRBAND; } else if (sock->type == SOCK_STREAM) { + const struct vsock_transport *transport = vsk->transport; lock_sock(sk); /* Listening sockets that have connections in their accept @@ -936,6 +940,7 @@ static int vsock_dgram_sendmsg(struct socket *sock, struc...

...4 vsock_stream_has_space(struct vsock_sock *vsk) { - return transport->stream_has_space(vsk); + return vsk->transport->stream_has_space(vsk); } EXPORT_SYMBOL_GPL(vsock_stream_has_space); @@ -869,6 +872,7 @@ static __poll_t vsock_poll(struct file *file, struct socket *sock, mask |= EPOLLOUT | EPOLLWRNORM | EPOLLWRBAND; } else if (sock->type == SOCK_STREAM) { + const struct vsock_transport *transport = vsk->transport; lock_sock(sk); /* Listening sockets that have connections in their accept @@ -944,6 +948,7 @@ static int vsock_dgram_sendmsg(struct socket *sock, struc...