search for: entryvecty

Hi David, Thanks for your efforts here. I have a few comments on your patch, although I realise it's still a work in progress. +class ConstantPool { + MCSymbol *Label; + typedef std::vector<const MCExpr*> EntryVecTy; Use a SmallVector here? + MCSymbol *getLabel() {return Label;} + size_t getNumEntries() {return Entries.size();} + const MCExpr *getEntry(size_t Num) {return Entries[Num];} These can be const. + int64_t ConstantPoolCounter; This can be unsigned. + case AsmToken::Equal: { + const MCSect...

...n in ARM > integrated assembler > > Hi David, > > Thanks for your efforts here. I have a few comments on your patch, > although I realise it's still a work in progress. > > +class ConstantPool { > + MCSymbol *Label; > + typedef std::vector<const MCExpr*> EntryVecTy; > > Use a SmallVector here? > > + MCSymbol *getLabel() {return Label;} > + size_t getNumEntries() {return Entries.size();} const MCExpr > + *getEntry(size_t Num) {return Entries[Num];} > These can be const. > > + int64_t ConstantPoolCounter; > This can be unsig...

...t; > > Hi David, > > > > Thanks for your efforts here. I have a few comments on your patch, > > although I realise it's still a work in progress. > > > > +class ConstantPool { > > + MCSymbol *Label; > > + typedef std::vector<const MCExpr*> EntryVecTy; > > > > Use a SmallVector here? > > > > + MCSymbol *getLabel() {return Label;} size_t getNumEntries() > > + {return Entries.size();} const MCExpr *getEntry(size_t Num) {return > > + Entries[Num];} > > These can be const. > > > > + int64_t C...

I have attached an initial patch that implements the ldr pseudo. It still needs some clean up and more tests, but I would like some feedback on the approach I used and if there are any objections to implementing it this way. Here is my approach: Add a finishParse() callback to the target asm parser This callback is invoked when the parse has finished successfully. It will be used to write out

...>>> >>> Thanks for your efforts here. I have a few comments on your patch, >>> although I realise it's still a work in progress. >>> >>> +class ConstantPool { >>> + MCSymbol *Label; >>> + typedef std::vector<const MCExpr*> EntryVecTy; >>> >>> Use a SmallVector here? >>> >>> + MCSymbol *getLabel() {return Label;} size_t getNumEntries() >>> + {return Entries.size();} const MCExpr *getEntry(size_t Num) {return >>> + Entries[Num];} >>> These can be const. >>&...

In an earlier email[1] I proposed adding support for the ldr pseud-instruction to the ARM integrated assembler. After some discussion the overall consensus seemed to be that it was worth adding. One concern was that we needed to have adequate testing. I promised to provide more details on what the behavior should be and provide some tests before starting the implementation. The FileCheck-ified