search for: entdec

...ture was tested by ectest.c, but not actually used by libcelt. An assert has been added to ec_dec_uint() to ensure that we don't try to use this feature by accident. ec_enc_uint() was actually correct, but support for this feature has been removed and the assert put in its place. --- libcelt/entdec.c | 3 +++ libcelt/entenc.c | 4 +++- tests/ectest.c | 4 ++-- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/libcelt/entdec.c b/libcelt/entdec.c index 555543f..284ce39 100644 --- a/libcelt/entdec.c +++ b/libcelt/entdec.c @@ -5,6 +5,7 @@ #include <stddef.h> #inclu...

....c | 2 +- libcelt/bands.h | 2 +- libcelt/celt.c | 12 ++++++------ libcelt/cwrs.c | 2 +- libcelt/cwrs.h | 2 +- libcelt/ecintrin.h | 3 ++- libcelt/entcode.c | 12 ++++++------ libcelt/entcode.h | 22 ++++++++++------------ libcelt/entdec.c | 38 +++++++++++++++++++------------------- libcelt/entdec.h | 6 +++--- libcelt/entenc.c | 36 ++++++++++++++++++------------------ libcelt/entenc.h | 8 ++++---- libcelt/mfrngcod.h | 6 +++--- libcelt/quant_bands.c | 14 +++++++------- libcelt/quant_bands....

...PTS = match-test.sh -lib_LTLIBRARIES = libcelt.la +lib_LTLIBRARIES = libcelt at LIBCELT_SUFFIX@.la # Sources for compilation in the library -libcelt_la_SOURCES = bands.c celt.c cwrs.c ecintrin.h entcode.c \ +libcelt at LIBCELT_SUFFIX@_la_SOURCES = bands.c celt.c cwrs.c ecintrin.h entcode.c \ entdec.c entenc.c header.c kfft_single.c kiss_fft.c kiss_fftr.c laplace.c mdct.c \ modes.c pitch.c psy.c quant_bands.c rangedec.c rangeenc.c rate.c \ vq.c #noinst_HEADERS = -libcelt_la_LDFLAGS = -version-info @CELT_LT_CURRENT@:@CELT_LT_REVISION@:@CELT_LT_AGE@ +libcelt at LIBCELT_SUFFIX@_la_LDFLAG...

Hi, compiling the latest release 0.5.1 (as well as from git) with gcc-4.2.4 on zenwalk (slackware current), ectest fails; using gcc-3.4.6 all tests succeeds. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/opus/attachments/20081220/68be24c8/attachment-0002.htm

...h.h diff --git a/libcelt/Makefile.am b/libcelt/Makefile.am index d34c1dc..7c574cc 100644 --- a/libcelt/Makefile.am +++ b/libcelt/Makefile.am @@ -16,7 +16,7 @@ lib_LTLIBRARIES = libcelt.la # Sources for compilation in the library libcelt_la_SOURCES = bands.c celt.c cwrs.c ecintrin.h entcode.c \ entdec.c entenc.c header.c kfft_single.c kiss_fft.c kiss_fftr.c laplace.c mdct.c \ - modes.c pitch.c psy.c quant_bands.c quant_pitch.c rangedec.c rangeenc.c rate.c \ + modes.c pitch.c psy.c quant_bands.c rangedec.c rangeenc.c rate.c \ vq.c #noinst_HEADERS = @@ -26,8 +26,8 @@ libcelt_la_LDFLAGS = -ver...

...the patch I'm suggesting: --- opus_decoder_old.c 2012-11-12 23:35:03.289595241 -0800 +++ opus_decoder.c 2012-11-12 23:36:44.550437586 -0800 @@ -34,6 +34,7 @@ #endif #include <stdarg.h> +#include <limits.h> #include "celt.h" #include "opus.h" #include "entdec.h" @@ -619,6 +620,8 @@ return OPUS_INVALID_PACKET; p = *data++; len--; + if (padding > INT_MAX - p) + return OPUS_INVALID_PACKET; padding += p==255 ? 254: p; } while (p==255); len -= padding;...

.../celt/dump_modes/Makefile +++ b/celt/dump_modes/Makefile @@ -1,10 +1,29 @@ + CFLAGS=-O2 -Wall -Wextra -DHAVE_CONFIG_H INCLUDES=-I. -I../ -I../.. -I../../include +SOURCES = dump_modes.c \ + ../modes.c \ + ../cwrs.c \ + ../rate.c \ + ../entenc.c \ + ../entdec.c \ + ../mathops.c \ + ../mdct.c \ + ../kiss_fft.c + +ifdef HAVE_ARM_NE10 +CC = gcc +CFLAGS += -mfpu=neon +INCLUDES += -I$(NE10_INCDIR) -DHAVE_ARM_NE10 -DOPUS_ARM_NEON_INTR +LIBDIR = -l:$(NE10_LIBDIR)/libNE10.so +SOURCES += ../arm/celt_neon_intr.c dump_mode_arm_ne10.c +en...

Hello opus-dev, I've been cooking up this patchset to integrate NE10 library into opus. Current patchset focuses on encode use case mainly effecting performance of clt_mdct_forward() and opus_fft() (for float only) Glad to report the following on Encode use case: (Measured on my Beaglebone Black Cortex-A8 board) - Performance improvement for encode use case ~= 12.34% (Based on time -p

.../celt/dump_modes/Makefile +++ b/celt/dump_modes/Makefile @@ -1,10 +1,31 @@ + CFLAGS=-O2 -Wall -Wextra -DHAVE_CONFIG_H INCLUDES=-I. -I../ -I../.. -I../../include +SOURCES = dump_modes.c \ + ../modes.c \ + ../cwrs.c \ + ../rate.c \ + ../entenc.c \ + ../entdec.c \ + ../mathops.c \ + ../mdct.c \ + ../kiss_fft.c + +ifdef HAVE_ARM_NE10 +CC = gcc +CFLAGS += -mfpu=neon +INCLUDES += -I$(NE10_INCDIR) -DHAVE_ARM_NE10 -DOPUS_ARM_NEON_INTR +LIBDIR = -l:$(NE10_LIBDIR)/libNE10.so +SOURCES += ../arm/celt_ne10_fft.c \ + dump_modes_...

.../celt/dump_modes/Makefile +++ b/celt/dump_modes/Makefile @@ -1,10 +1,31 @@ + CFLAGS=-O2 -Wall -Wextra -DHAVE_CONFIG_H INCLUDES=-I. -I../ -I../.. -I../../include +SOURCES = dump_modes.c \ + ../modes.c \ + ../cwrs.c \ + ../rate.c \ + ../entenc.c \ + ../entdec.c \ + ../mathops.c \ + ../mdct.c \ + ../kiss_fft.c + +ifdef HAVE_ARM_NE10 +CC = gcc +CFLAGS += -mfpu=neon +INCLUDES += -I$(NE10_INCDIR) -DHAVE_ARM_NE10 -DOPUS_ARM_NEON_INTR +LIBDIR = -l:$(NE10_LIBDIR)/libNE10.so +SOURCES += ../arm/celt_ne10_fft.c \ + dump_modes_...

.../celt/dump_modes/Makefile +++ b/celt/dump_modes/Makefile @@ -1,10 +1,31 @@ + CFLAGS=-O2 -Wall -Wextra -DHAVE_CONFIG_H INCLUDES=-I. -I../ -I../.. -I../../include +SOURCES = dump_modes.c \ + ../modes.c \ + ../cwrs.c \ + ../rate.c \ + ../entenc.c \ + ../entdec.c \ + ../mathops.c \ + ../mdct.c \ + ../kiss_fft.c + +ifdef HAVE_ARM_NE10 +CC = gcc +CFLAGS += -mfpu=neon +INCLUDES += -I$(NE10_INCDIR) -DHAVE_ARM_NE10 -DOPUS_ARM_NEON_INTR +LIBDIR = -l:$(NE10_LIBDIR)/libNE10.so +SOURCES += ../arm/celt_ne10_fft.c \ + dump_modes_...

Changes from RFC PATCH v3 - Just rebased on tip - For all else, please see notes from RFC PATCH v3 at http://lists.xiph.org/pipermail/opus/2015-March/002902.html - latest wip opus tree/branch https://git.linaro.org/people/viswanath.puttagunta/Ne10.git branch: rfcv4_final_fft_ne10 Viswanath Puttagunta (1): armv7(float): Optimize encode usecase using NE10 library Makefile.am

Changes from RFC PATCH v1: - passing arch parameter explicitly - reduced stack usage by ~3.5K by using scaled NE10 fft version - moved all optimization array functions to arm_celt_map.c - Other cleanups pointed out by Timothy Phil, As you mentioned earlier, could you please address all compile and linker errors/warnings coming out of Ne10 library? You can find my working Ne10 repo at [1] You

Changes from RFC PATCH v2 - fixed compile issue when just compiling for --enable-intrinsics for ARMv7 without NE10 - Notes for NE10: - All compile/link warnings are now in upstream NE10 - Only patch pending upstream in NE10 is the one that needs to add -funsafe-math-optimizations for ARMv7 targets. - Phil Wang @ ARM is working on getting this fixed. - Note that even without

Hi All, Since I continue to base my work on top of Jonathan's patch, and my previous Ne10 fft/ifft/mdct_forward/backward patches, I thought it would be better to just post all new patches as a patch series. Please let me know if anyone disagrees with this approach. You can see wip branch of all latest patches at https://git.linaro.org/people/viswanath.puttagunta/opus.git Branch:

Hi Timothy, As I mentioned earlier [1], I now fixed compile issues with fixed point and resubmitting the patch. I also have new patch that does intrinsics optimizations for celt_pitch_xcorr targetting aarch64. You can find my latest work-in-progress branch at [2] For reference, you can use the Ne10 pre-built libraries at [3] Note that I am working with Phil at ARM to get my patch at [4]

Hi All, As per Timothy's suggestion, disabling mdct_forward for fixed point. Only effects armv7,armv8: Extend fixed fft NE10 optimizations to mdct Rest of patches are same as in [1] For reference, latest wip code for opus is at [2] Still working with NE10 team at ARM to get corner cases of mdct_forward. Will update with another patch when issue in NE10 gets fixed. Regards, Vish [1]:

Hi All, Changes from RFC v2 [1] armv7,armv8: Extend fixed fft NE10 optimizations to mdct - Overflow issue fixed by Phil at ARM. Ne10 wip at [2]. Should be upstream soon. - So, re-enabled using fixed fft for mdct_forward which was disabled in RFCv2 armv7,armv8: Optimize fixed point fft using NE10 library - Thanks to Jonathan Lennox, fixed some build fixes on iOS and some copy-paste errors Rest

Hello Timothy / Jean-Marc / opus-dev, This patch series is follow up on work I posted on [1]. In addition to what was posted on [1], this patch series mainly integrates Fixed point FFT implementations in NE10 library into opus. You can view my opus wip code at [2]. Note that while I found some issues both with the NE10 library(fixed fft) and with Linaro toolchain (armv8 intrinsics), the work