search for: enodev

Fix issues Eric found in the original patch: https://www.redhat.com/archives/libguestfs/2018-July/msg00072.html - When handling ENODEV, the caller is expecting EOPNOTSUPP to trigger fallback. - ENODEV should be ignored in file_trim. Tested only on Fedora 28 and RHEL 7.5. --- plugins/file/file.c | 33 ++++++++++++++++++++++++--------- 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/plugins/file/file.c b/plugins/f...

Fix issues Eric found in the original patch: https://www.redhat.com/archives/libguestfs/2018-July/msg00072.html - When handling ENODEV, the caller is expecting ENOTSUPP to trigger fallback. - ENODEV should be ignored in file_trim. Tested only on Fedora 28. --- plugins/file/file.c | 33 ++++++++++++++++++++++++--------- 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/plugins/file/file.c b/plugins/file/file.c inde...

When using block device on RHEL 7.5, file plugin fails to zero with this error (copied from strace): [pid 39551] fallocate(8, FALLOC_FL_ZERO_RANGE, 1536, 64000) = -1 ENODEV (No such device) This is expected error according to the manual: ENODEV fd does not refer to a regular file or a directory. (If fd is a pipe or FIFO, a different error results.) Treat this error as EOPNOSUPP. Tested only on Fedora 28; I don't know how to build nbdkit on RHEL, but the chang...

On 07/19/2013 04:16 AM, Amit Shah wrote: > If a port gets unplugged while a user is blocked on read(), -ENODEV is > returned. However, subsequent read()s returned 0, indicating there's no > host-side connection (but not indicating the device went away). > > This also happened when a port was unplugged and the user didn't have > any blocking operation pending. If the user didn't...

On 07/19/2013 04:16 AM, Amit Shah wrote: > If a port gets unplugged while a user is blocked on read(), -ENODEV is > returned. However, subsequent read()s returned 0, indicating there's no > host-side connection (but not indicating the device went away). > > This also happened when a port was unplugged and the user didn't have > any blocking operation pending. If the user didn't...

...init uv_info_init(void) > } > device_initcall(uv_info_init); > #endif > + > +/* > + * arch_validate_virtio_iommu_platform s/arch_validate_virtio_iommu_platform/arch_validate_virtio_features/ > + * @dev: the VIRTIO device being added > + * > + * Return value: returns -ENODEV if any features of the > + * device breaks the protected virtualization > + * 0 otherwise. I don't think you need to specify the contract here: that belongs to the definition in the virtio core. What about simply adding a sentence "Return an error if requ...

...init uv_info_init(void) > } > device_initcall(uv_info_init); > #endif > + > +/* > + * arch_validate_virtio_iommu_platform s/arch_validate_virtio_iommu_platform/arch_validate_virtio_features/ > + * @dev: the VIRTIO device being added > + * > + * Return value: returns -ENODEV if any features of the > + * device breaks the protected virtualization > + * 0 otherwise. I don't think you need to specify the contract here: that belongs to the definition in the virtio core. What about simply adding a sentence "Return an error if requ...

On (Fri) 19 Jul 2013 [13:07:49], Jason Wang wrote: > On 07/19/2013 04:16 AM, Amit Shah wrote: > > If a port gets unplugged while a user is blocked on read(), -ENODEV is > > returned. However, subsequent read()s returned 0, indicating there's no > > host-side connection (but not indicating the device went away). > > > > This also happened when a port was unplugged and the user didn't have > > any blocking operation pending....

...l 27, 2018 at 04:23:10PM -0500, Eric Blake wrote: > On 07/27/2018 04:03 PM, Nir Soffer wrote: > >When using block device on RHEL 7.5, file plugin fails to zero with this > >error (copied from strace): > > > >[pid 39551] fallocate(8, FALLOC_FL_ZERO_RANGE, 1536, 64000) = -1 ENODEV (No such device) > > > >This is expected error according to the manual: > > > >ENODEV fd does not refer to a regular file or a directory. (If fd is a > >pipe or FIFO, a different error results.) > > The man page is out-of-date; newer kernels support > FALLOC...

On 07/28/2018 06:42 AM, Nir Soffer wrote: > Fix issues Eric found in the original patch: > https://www.redhat.com/archives/libguestfs/2018-July/msg00072.html > > - When handling ENODEV, the caller is expecting ENOTSUPP to trigger > fallback. > - ENODEV should be ignored in file_trim. > > Tested only on Fedora 28. > --- > plugins/file/file.c | 33 ++++++++++++++++++++++++--------- > 1 file changed, 24 insertions(+), 9 deletions(-) > > diff --git...

Hi, Would it be acceptable to patch make_file() in flist.c to ignore any ENODEV's and not mark them as io_error=1? In afs, a mountpoint to a volume which does not exist gives an ENODEV. As such, it can't be copied, so should (or could) just be ignored? The io_error isn't terminal, but it does disable the delete function and you end up with an exit code of 23. r...

If a port gets unplugged while a user is blocked on read(), -ENODEV is returned. However, subsequent read()s returned 0, indicating there's no host-side connection (but not indicating the device went away). This also happened when a port was unplugged and the user didn't have any blocking operation pending. If the user didn't monitor the SIGIO signal...

If a port gets unplugged while a user is blocked on read(), -ENODEV is returned. However, subsequent read()s returned 0, indicating there's no host-side connection (but not indicating the device went away). This also happened when a port was unplugged and the user didn't have any blocking operation pending. If the user didn't monitor the SIGIO signal...

On Mon, Jul 30, 2018 at 9:23 PM Eric Blake <eblake@redhat.com> wrote: > On 07/30/2018 12:02 PM, Nir Soffer wrote: > > Fix issues Eric found in the original patch: > > https://www.redhat.com/archives/libguestfs/2018-July/msg00072.html > > > > - When handling ENODEV, the caller is expecting EOPNOTSUPP to trigger > > fallback. > > - ENODEV should be ignored in file_trim. > > > > Tested only on Fedora 28 and RHEL 7.5. > > --- > > plugins/file/file.c | 33 ++++++++++++++++++++++++--------- > > 1 file changed, 24 ins...

On 07/30/2018 12:02 PM, Nir Soffer wrote: > Fix issues Eric found in the original patch: > https://www.redhat.com/archives/libguestfs/2018-July/msg00072.html > > - When handling ENODEV, the caller is expecting EOPNOTSUPP to trigger > fallback. > - ENODEV should be ignored in file_trim. > > Tested only on Fedora 28 and RHEL 7.5. > --- > plugins/file/file.c | 33 ++++++++++++++++++++++++--------- > 1 file changed, 24 insertions(+), 9 deletions(-) >...

From: Joerg Roedel <jroedel at suse.de> When check_device() fails on the device, it is not handled by the IOMMU and amd_iommu_add_device() needs to return -ENODEV. Signed-off-by: Joerg Roedel <jroedel at suse.de> --- drivers/iommu/amd_iommu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c index 504f2db75eda..3e0d27f7622e 100644 --- a/drivers/iommu/amd_iommu.c +++ b/drivers...

On 07/27/2018 04:03 PM, Nir Soffer wrote: > When using block device on RHEL 7.5, file plugin fails to zero with this > error (copied from strace): > > [pid 39551] fallocate(8, FALLOC_FL_ZERO_RANGE, 1536, 64000) = -1 ENODEV (No such device) > > This is expected error according to the manual: > > ENODEV fd does not refer to a regular file or a directory. (If fd is a > pipe or FIFO, a different error results.) The man page is out-of-date; newer kernels support FALLOC_FL_ZERO_RANGE on block devices, i...

...ged, 7 insertions(+), 5 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 2f22874..d5e1ab9 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -1475,6 +1475,9 @@ static int __init xlblk_init(void) if (!xen_domain()) return -ENODEV; + if (!xen_platform_pci_unplug) + return -ENODEV; + if (register_blkdev(XENVBD_MAJOR, DEV_NAME)) { printk(KERN_WARNING "xen_blk: can''t get major %d with name %s\n", XENVBD_MAJOR, DEV_NAME); diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c in...

Hi all, I changed the patch subject to reflect the content, becoming more general. 1) I removed the ack from Christian and Jason even far as I understand they gave it for the functionality more than for the implementation. @Jason, @Christian, please can I get back your acked-by with these changes? 2) previous patch had another name: [PATCH v3 0/1] s390: virtio: let arch choose to

...t;>>> + !virtio_has_feature(dev, VIRTIO_F_IOMMU_PLATFORM)) >>>>> + return -EIO; >>>>> + >>>> >>>> Why EIO? >>> >>> Because I/O can not occur correctly? >>> I am open to suggestions. >> >> We use -ENODEV if feature when the device rejects the features we >> tried to negotiate (see virtio_finalize_features()) and -EINVAL when >> the F_VERSION_1 and the virtio-ccw revision ain't coherent (in >> virtio_ccw_finalize_features()). Any of those seems more fitting >> that EIO to...