search for: enoclue

[...] >> >> Issue 2: When called via the shrinker, (but also to fix Issue 1), it could be >> that we do have VIRTIO_BALLOON_F_MUST_TELL_HOST. I assume this means >> (-ENOCLUE) that we have to wait until the hypervisor notifies us via the STOP? Or >> for which event do we have to wait? Because there is no way to *tell host* here >> that we want to reuse a page. The hypervisor will *tell us* when we can reuse pages. >> For the shrinker it is simple: Don&...

[...] >> >> Issue 2: When called via the shrinker, (but also to fix Issue 1), it could be >> that we do have VIRTIO_BALLOON_F_MUST_TELL_HOST. I assume this means >> (-ENOCLUE) that we have to wait until the hypervisor notifies us via the STOP? Or >> for which event do we have to wait? Because there is no way to *tell host* here >> that we want to reuse a page. The hypervisor will *tell us* when we can reuse pages. >> For the shrinker it is simple: Don&...

...to_mm(vb, ULONG_MAX); + /* Now we reset the device so we can clean up the queues. */ vb->vdev->config->reset(vb->vdev); Issue 2: When called via the shrinker, (but also to fix Issue 1), it could be that we do have VIRTIO_BALLOON_F_MUST_TELL_HOST. I assume this means (-ENOCLUE) that we have to wait until the hypervisor notifies us via the STOP? Or for which event do we have to wait? Because there is no way to *tell host* here that we want to reuse a page. The hypervisor will *tell us* when we can reuse pages. For the shrinker it is simple: Don't use the shrinker wit...

...to_mm(vb, ULONG_MAX); + /* Now we reset the device so we can clean up the queues. */ vb->vdev->config->reset(vb->vdev); Issue 2: When called via the shrinker, (but also to fix Issue 1), it could be that we do have VIRTIO_BALLOON_F_MUST_TELL_HOST. I assume this means (-ENOCLUE) that we have to wait until the hypervisor notifies us via the STOP? Or for which event do we have to wait? Because there is no way to *tell host* here that we want to reuse a page. The hypervisor will *tell us* when we can reuse pages. For the shrinker it is simple: Don't use the shrinker wit...

On Tue, Feb 04, 2020 at 05:56:22PM +0100, David Hildenbrand wrote: > [...] > > >> > >> Issue 2: When called via the shrinker, (but also to fix Issue 1), it could be > >> that we do have VIRTIO_BALLOON_F_MUST_TELL_HOST. I assume this means > >> (-ENOCLUE) that we have to wait until the hypervisor notifies us via the STOP? Or > >> for which event do we have to wait? Because there is no way to *tell host* here > >> that we want to reuse a page. The hypervisor will *tell us* when we can reuse pages. > >> For the shrinker it...

...Now we reset the device so we can clean up the queues. */ > vb->vdev->config->reset(vb->vdev); Indeed. > > Issue 2: When called via the shrinker, (but also to fix Issue 1), it could be > that we do have VIRTIO_BALLOON_F_MUST_TELL_HOST. I assume this means > (-ENOCLUE) that we have to wait until the hypervisor notifies us via the STOP? Or > for which event do we have to wait? Because there is no way to *tell host* here > that we want to reuse a page. The hypervisor will *tell us* when we can reuse pages. > For the shrinker it is simple: Don't use th...

>>> I would say reverting probably makes sense. I'm not sure there is much >>> value to having a shrinker running deflation when you are actively trying >>> to increase the balloon. It would make more sense to wait until you are >>> actually about to start hitting oom. >> >> I think the shrinker makes sense for free page hinting feature >>

>>> I would say reverting probably makes sense. I'm not sure there is much >>> value to having a shrinker running deflation when you are actively trying >>> to increase the balloon. It would make more sense to wait until you are >>> actually about to start hitting oom. >> >> I think the shrinker makes sense for free page hinting feature >>