search for: endoffset

...ch, let me > know. > > >> I may need to refer to the second patch in reviewing this first one. >> DwarfDebug.cpp: >> computeSizeAndOffsets: >> I believe this produces the wrong offset for the 3rd CU and >> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >> relative to the Offset passed in, so it should be assigned to SecOffset, >> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >> through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll >> be (0 + 42)...

...>> I may need to refer to the second patch in reviewing this first one. >>>> DwarfDebug.cpp: >>>> computeSizeAndOffsets: >>>> I believe this produces the wrong offset for the 3rd CU and >>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>> through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'...

...the two and commit as a single patch, let me know. > I may need to refer to the second patch in reviewing this first one. > DwarfDebug.cpp: > computeSizeAndOffsets: > I believe this produces the wrong offset for the 3rd CU and onwards. > computeSizeAndOffset returns the EndOffset which is absolute, not relative > to the Offset passed in, so it should be assigned to SecOffset, not added > to it. (eg: if you have CUs at 0, 42, and 57 - the first pass through > SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll be (0 + > 42) + 57 which isn&...

...t; >> >>> I may need to refer to the second patch in reviewing this first one. >>> DwarfDebug.cpp: >>> computeSizeAndOffsets: >>> I believe this produces the wrong offset for the 3rd CU and >>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>> relative to the Offset passed in, so it should be assigned to SecOffset, >>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>> through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll >>...

...the second patch in reviewing this first one. >>>>>> DwarfDebug.cpp: >>>>>> computeSizeAndOffsets: >>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>>>> through SecOffset will be zero, then it'll be 0 + 42...

...eparated for legibility, is untested & difficult to discuss in isolation. I may need to refer to the second patch in reviewing this first one. DwarfDebug.cpp: computeSizeAndOffsets: I believe this produces the wrong offset for the 3rd CU and onwards. computeSizeAndOffset returns the EndOffset which is absolute, not relative to the Offset passed in, so it should be assigned to SecOffset, not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll be (0 + 42) + 57 which isn't right, it shou...

...need to refer to the second patch in reviewing this first one. >>>>> DwarfDebug.cpp: >>>>> computeSizeAndOffsets: >>>>> I believe this produces the wrong offset for the 3rd CU and >>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>>> through SecOffset will be zero, then it'll be 0 + 42, then on th...

...>> I may need to refer to the second patch in reviewing this first one. >>>> DwarfDebug.cpp: >>>> computeSizeAndOffsets: >>>> I believe this produces the wrong offset for the 3rd CU and >>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>> through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'...

...t; >> >>> I may need to refer to the second patch in reviewing this first one. >>> DwarfDebug.cpp: >>> computeSizeAndOffsets: >>> I believe this produces the wrong offset for the 3rd CU and >>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>> relative to the Offset passed in, so it should be assigned to SecOffset, >>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>> through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll >>...

...h in reviewing this first one. >>>>>>> DwarfDebug.cpp: >>>>>>> computeSizeAndOffsets: >>>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>>>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>>>>> through SecOffset will be zero, then it'...

...his first one. >>>>>>>> DwarfDebug.cpp: >>>>>>>> computeSizeAndOffsets: >>>>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>>> relative to the Offset passed in, so it should be assigned to SecOffset, not >>>>>>>> added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass through >>>>>>>> SecOffset will be zero,...

...h in reviewing this first one. >>>>>>> DwarfDebug.cpp: >>>>>>> computeSizeAndOffsets: >>>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>>>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>>>>> through SecOffset will be zero, then it'...

...;>> one. >>>>>>>> DwarfDebug.cpp: >>>>>>>> computeSizeAndOffsets: >>>>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>>>>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>>>>>> through SecOffset will be zero,...

...Error("Decode","Offset error"); // uninterleave samples ret = ov_read(&m_pDecoder->VorbisFile,(char *)_pData,_nBytes,0,2,1,&m_pDecoder->Section); int EndOffset = ov_pcm_tell(&m_pDecoder->VorbisFile); if (EndOffset<0) Error("Decode","Offset error"); if (EndOffset == StartOffset) ++NumTimesNoData;...

...gt;>>>>>>>> DwarfDebug.cpp: >>>>>>>>> computeSizeAndOffsets: >>>>>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>>>>>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>>>>>>> through SecOffset wi...

...gt;>>>>> DwarfDebug.cpp: >>>>>>>>>> computeSizeAndOffsets: >>>>>>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>>>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>>>>>>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>>>>>>>> through...

...gt;>> DwarfDebug.cpp: >>>>>>>>>>> computeSizeAndOffsets: >>>>>>>>>>> I believe this produces the wrong offset for the 3rd CU >>>>>>>>>>> and onwards. computeSizeAndOffset returns the EndOffset which is absolute, >>>>>>>>>>> not relative to the Offset passed in, so it should be assigned to >>>>>>>>>>> SecOffset, not added to it. (eg: if you have CUs at 0, 42, and 57 - the >>>>>>>>>>> first p...

...gt;>> DwarfDebug.cpp: >>>>>>>>>>> computeSizeAndOffsets: >>>>>>>>>>> I believe this produces the wrong offset for the 3rd CU >>>>>>>>>>> and onwards. computeSizeAndOffset returns the EndOffset which is absolute, >>>>>>>>>>> not relative to the Offset passed in, so it should be assigned to >>>>>>>>>>> SecOffset, not added to it. (eg: if you have CUs at 0, 42, and 57 - the >>>>>>>>>>> first p...

...DwarfDebug.cpp: >>>>>>>>>>>> computeSizeAndOffsets: >>>>>>>>>>>> I believe this produces the wrong offset for the 3rd CU >>>>>>>>>>>> and onwards. computeSizeAndOffset returns the EndOffset which is absolute, >>>>>>>>>>>> not relative to the Offset passed in, so it should be assigned to >>>>>>>>>>>> SecOffset, not added to it. (eg: if you have CUs at 0, 42, and 57 - the >>>>>>>>>>>...

....cpp: >>>>>>>>>>>>> computeSizeAndOffsets: >>>>>>>>>>>>> I believe this produces the wrong offset for the 3rd CU >>>>>>>>>>>>> and onwards. computeSizeAndOffset returns the EndOffset which is absolute, >>>>>>>>>>>>> not relative to the Offset passed in, so it should be assigned to >>>>>>>>>>>>> SecOffset, not added to it. (eg: if you have CUs at 0, 42, and 57 - the >>>>>>>>>...