search for: end_of_line

Getting this when attempting to build 2.3.11.3 on CentOS 6: test-mail-cache.c:176: Assert failed: strcmp(str_c(str),"123\nfoo\n456\nbar\n") "" != "123 foo 456 bar " test-mail-cache.c:176: Assert failed: strcmp(str_c(str),"123\nfoo\n456\nbar\n") "" != "123 foo 456 bar " mail cache uncommitted lookups

...but that's a 4M file so I'll provide it upon request. > > For now I'm going ot have to bypass the make check stage of the build for CentOS 6, but I worry that the failed check could be indicative of something critical. Looks like it's a gcc bug. It's not initializing the end_of_lines field in the unit test. Since it's in the unit test only, it's not harmful. Of course, the same gcc bug could be hitting some important places in the code.. but that's not a new issue. Only this unit test is really new and exposing this issue. The problem goes away with: diff --git a...

...rmalize the llvm rules. I ran it against Target/Target.cpp Target.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Target.cpp:10: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] Target.cpp:22: Found C++ system header after other header. Should be: Target.h, c system, c++ system, other. [build/include_order] [4] Target.cpp:24: Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5] Target.cpp:26: Is this a non-const referen...

...it would good to > start to adapt this tool > or write a new tool to do style checking and to start to better > formalize the llvm rules. > > I ran it against Target/Target.cpp > > Target.cpp:10: Line ends in whitespace. Consider deleting these extra > spaces. [whitespace/end_of_line] [4] We have an incredible amount of those, and fixing them would create far too much churn. I generally fix them on the code I touch. > Target.cpp:22: Found C++ system header after other header. Should be: > Target.h, c system, c++ system, other. [build/include_order] [4] The LLVM convent...

...to adapt this tool >> or write a new tool to do style checking and to start to better >> formalize the llvm rules. >> >> I ran it against Target/Target.cpp >> >> Target.cpp:10: Line ends in whitespace. Consider deleting these extra >> spaces. [whitespace/end_of_line] [4] > We have an incredible amount of those, and fixing them would create far > too much churn. I generally fix them on the code I touch. >> Target.cpp:22: Found C++ system header after other header. Should be: >> Target.h, c system, c++ system, other. [build/include_order] [4]...