search for: enabled_by_default

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.

...*"; ] in + List.iter ( + fun path -> + let files = g#glob_expand path in + Array.iter ( + fun file -> + g#rm_rf file; + ) files; + ) paths; + + [] + ) + else [] + +let op = { + defaults with + name = "tmp-files"; + enabled_by_default = true; + heading = s_"Remove the tmp files"; + pod_description = Some (s_"\ +This removes the temporary files under C</tmp> and C</var/tmp>."); + perform_on_filesystems = Some tmp_files_perform; +} + +let () = register_operation op -- 1.8.4.27.g0a41de8

...e; [] + | "apt" -> + let cache = g#glob_expand "/var/cache/apt/archives/*" in + Array.iter ( + fun dir -> + g#rm_rf dir + ) cache; [] + | _ -> (); [] + +let package_manager_cache_op = { + name = "package-manager-cache"; + enabled_by_default = true; + heading = "Remove the cache of package manager"; + pod_description = None; + extra_args = []; + perform = package_manager_cache_perform; +} + +let () = register_operation package_manager_cache_op -- 1.7.10

...ld_right StringSet.add excepts StringSet.empty in + let set = StringSet.diff set excepts in + StringSet.iter ( + fun filename -> + try g#rm filename with G.Error _ -> () + ) set; + + [] + ) + else [] + +let kerberos_data_op = { + name = "kerberos-data"; + enabled_by_default = false; + heading = s_"Remove Kerberos data in the guest"; + pod_description = None; + extra_args = []; + perform = kerberos_data_perform; +} + +let () = register_operation kerberos_data_op -- 1.7.10

...ter ( + fun path -> + let files = g#glob_expand path in + Array.iter ( + fun file -> + try g#rm file with G.Error _ -> () + ) files; + ) paths; + + [] + ) + else [] + +let puppet_data_log_op = { + name = "puppet-data-log"; + enabled_by_default = false; + heading = s_"Remove the data and log files of puppet"; + pod_description = None; + extra_args = []; + perform = puppet_data_log_perform; +} + +let () = register_operation puppet_data_log_op -- 1.7.10

Version 1 of the patch, for discussion, but not to be applied. It does work, but needs a lot more testing. This removes all the psychopathic gettextify cruft, and replaces it with a 99 line Makefile.am. A large win, I think. The third patch implements gettext support in the OCaml tools. The fourth patch is just for illustration. It shows the consequent changes to libguestfs.pot and the po

...e G = Guestfs + +let flag_reconfiguration g root = + let typ = g#inspect_get_type root in + if typ <> "windows" then ( + g#touch "/.unconfigured"; + [ `Created_files ] + ) + else [] + +let flag_reconfiguration_op = { + name = "flag-reconfiguration"; + enabled_by_default = true; + heading = "Flag the system for reconfiguration"; + pod_description = Some "\ +Flag the system for reconfiguration by touching a file +\"/.unconfigured\"."; + extra_args = []; + perform = flag_reconfiguration; +} + +let () = register_operation flag_reconfi...

...+ if typ <> "windows" then ( + let paths = g#glob_expand "/var/spool/abrt/*" in + Array.iter ( + fun path -> g#rm_rf path; + ) paths; + g#rm_rf "/root/.ssh"; + [] + ) + else [] + +let abrt_data_op = { + name = "abrt-data"; + enabled_by_default = true; + heading = s_"Remove the crash data generated by ABRT"; + pod_description = Some (s_"\ +Remove the automatically generated crash data in /var/spool/abrt/ +by ABRT."); + extra_args = []; + perform = abrt_data_perform; +} + +let () = register_operation abrt_data_op --...

This patch series adds a new virt-sysprep operation to offline unenroll a guest from FreeIPA. It does so by removing some configuration files and certificates. Changes from v1: - the other patches were pushed, as unrelated and approved - created a new kerberos-hostkeytab operation Pino Toscano (2): sysprep: add IPA offline unenrollment (RHBZ#1789592) sysprep: add Kerberos keytab file removal

...fnmatch usage can be avoided. > + let path = full_path dir (Some filename) in > + g#rm_f path > + ) > + ) > + ) > + ) fses > + > +let op = { > + defaults with > + name = "backup-files"; > + enabled_by_default = true; > + heading = s_"Remove editor backup files from the guest"; > + pod_description = Some ( > + sprintf (f_"\ > +The following files are removed from anywhere in the guest > +filesystem: > + > +%s > + > +On Linux and Unix operating systems,...

...uot;) + ) lines in + let file = String.concat "\n" lines ^ "\n" in + g#write filename file + ) filenames; + + if filenames <> [||] then [ `Created_files ] else [] + + | _ -> [] + +let net_hostname_op = { + name = "net-hostname"; + enabled_by_default = true; + heading = s_"Remove HOSTNAME in network interface configuration"; + pod_description = Some (s_"\ +For Fedora and Red Hat Enterprise Linux, +this is removed from C<ifcfg-*> files."); + extra_args = []; + perform_on_filesystems = Some net_hostname_perform; + p...

...List.iter ( + fun path -> + let files = g#glob_expand path in + Array.iter ( + fun file -> + try g#rm file with G.Error _ -> () + ) files; + ) paths; + + [] + ) + else [] + +let sssd_db_log_op = { + name = "sssd-db-log"; + enabled_by_default = true; + heading = "Remove the db and log of sssd"; + pod_description = None; + extra_args = []; + perform = sssd_db_log_perform; +} + +let () = register_operation sssd_db_log_op -- 1.7.10

audit.log is already included in /var/log/audit/*. Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com> --- sysprep/sysprep_operation_logfiles.ml | 1 - 1 file changed, 1 deletion(-) diff --git a/sysprep/sysprep_operation_logfiles.ml b/sysprep/sysprep_operation_logfiles.ml index 842b855..cdfe8fc 100644 --- a/sysprep/sysprep_operation_logfiles.ml +++

...pacct*" in + Array.iter ( + fun file -> + try g#rm file with G.Error _ -> () + ) files; + (try g#touch "/var/log/account/pacct" with G.Error _ -> ()); + [ `Created_files ] + + | _ -> [] + +let pacct_log_op = { + name = "pacct-log"; + enabled_by_default = true; + heading = s_"Remove the process accounting log files"; + pod_description = Some (s_"\ +The system wide process accounting will store to the pacct +log files if the process accounting is on."); + extra_args = []; + perform_on_filesystems = Some pacct_log_perform; +...

...fun except -> + if file <> except then ( + try g#rm file with G.Error _ -> () + ) + ) excepts; + ) files; + ) paths; + + [] + ) + else [] + +let ca_certificates_op = { + name = "ca-certificates"; + enabled_by_default = true; + heading = s_"Remove CA certificates in the guest"; + pod_description = None; + extra_args = []; + perform = ca_certificates_perform; +} + +let () = register_operation ca_certificates_op -- 1.7.10

In the TODO file there's a discussion of perhaps writing a new 'virt-customize' tool. I think it's probably better (or at any rate, easier) to just add this functionality into virt-sysprep. That is what this small series of patches aims to achieve. Note these are not very well tested at the moment. The first patch adds a generic and useful '--firstboot' flag. The

...match parttype, p.p_id with | GPT, GPT_Type gpt_type -> diff --git a/sysprep/sysprep_operation.ml b/sysprep/sysprep_operation.ml index af2004e..057c8c5 100644 --- a/sysprep/sysprep_operation.ml +++ b/sysprep/sysprep_operation.ml @@ -186,10 +186,7 @@ let dump_pod () = if op.enabled_by_default then printf "*\n"; printf "\n"; printf "%s.\n\n" op.heading; - (match op.pod_description with - | None -> () - | Some description -> printf "%s\n\n" description - ); + may (printf "%s\n\n") op.pod_descrip...

...ot;\n" (List.map ((^) " ") files) + +let passwd_backups_perform (g : Guestfs.guestfs) root side_effects = + let typ = g#inspect_get_type root in + if typ = "linux" then + List.iter g#rm_f files + +let op = { + defaults with + name = "passwd-backups"; + enabled_by_default = true; + heading = s_"Remove /etc/passwd- and similar backup files"; + pod_description = Some ( + sprintf (f_"\ +On Linux the following files are removed: + +%s") files_as_pod); + perform_on_filesystems = Some passwd_backups_perform; +} + +let () = register_operat...

...ot;) && + not (String.is_prefix line "DHCP_HOSTNAME=") ) lines in let file = String.concat "\n" lines ^ "\n" in g#write filename file; @@ -46,7 +48,7 @@ let op = { defaults with name = "net-hostname"; enabled_by_default = true; - heading = s_"Remove HOSTNAME in network interface configuration"; + heading = s_"Remove HOSTNAME and DHCP_HOSTNAME in network interface configuration"; pod_description = Some (s_"\ For Fedora and Red Hat Enterprise Linux, this is removed from C<ifc...

...stkeytab_perform (g : Guestfs.guestfs) root side_effects = + let typ = g#inspect_get_type root in + if typ <> "windows" then ( + (try g#rm "/etc/krb5.keytab" with G.Error _ -> ()) + ) + +let op = { + defaults with + name = "kerberos-hostkeytab"; + enabled_by_default = true; + heading = s_"Remove the Kerberos host keytab file in the guest"; + perform_on_filesystems = Some kerberos_hostkeytab_perform; +} + +let () = register_operation op -- 2.25.4