Displaying 3 results from an estimated 3 matches for "enable_reverse_iteration".
2017 Jun 30
2
llvm-profdata determinism
...h has deterministic iteration
>>
>
> Does the iteration order of these maps depend on the order of hashes (of
> strings for StringMap)?
>
Right - that's my understanding.
(Some folks have started adding interesting things to LLVM to try to help
weed out these sort of issues (ENABLE_REVERSE_ITERATION - though it's only
been implemented in one of LLVM's containers so far))
> Anyway, text dump is for debugging purpose only.
>
Sure, though even test cases written against this should be deterministic,
but yeah - less of a concern, for sure.
> .
>>
>> The binary...
2017 Jun 30
0
llvm-profdata determinism
...>>
>> Does the iteration order of these maps depend on the order of hashes (of
>> strings for StringMap)?
>>
>
> Right - that's my understanding.
>
> (Some folks have started adding interesting things to LLVM to try to help
> weed out these sort of issues (ENABLE_REVERSE_ITERATION - though it's only
> been implemented in one of LLVM's containers so far))
>
>
>> Anyway, text dump is for debugging purpose only.
>>
>
> Sure, though even test cases written against this should be deterministic,
> but yeah - less of a concern, for sure.
>...
2017 Jun 30
2
llvm-profdata determinism
I haven't tested it, but it looks to me like llvm-profdata merge (well,
InstrProfWriter specifically) would not have deterministic output.
Certainly the textual output iterates over FunctionData which is a
StringMap of SmallDenseMaps, neither of which has deterministic iteration.
The binary writing looks like it'd have similar issues - looping through
these unordered maps & writing