search for: emitxraytable

...he mailing list... Please, see below. On 9 January 2017 at 23:45, Serge Rogatch <serge.rogatch at gmail.com> wrote: > Hi Dean, > > I have seen that you removed the following code from ARMAsmPrinter.cpp in > revision 290858: > // Emit the XRay table for this function. > EmitXRayTable(); > > Was this done by mistake or on purpose? > > Without this call, xray_instr_map gets empty in the executable, so that > XRay doesn't patch anything. While implementing the tail call handling, I > am reverting this change (I mean, just returning the call to > emitXRayTa...

...is condition to enable the tests for ARM. Oleg ________________________________________ From: Renato Golin <renato.golin at linaro.org> Sent: Monday, January 9, 2017 11:50 PM To: Serge Rogatch Cc: Dean Michael Berris; LLVM Developers; Oleg Ranevskyy Subject: Re: [llvm-dev] Removed a call to EmitXRayTable() from ARMAsmPrinter On 9 January 2017 at 20:47, Serge Rogatch via llvm-dev <llvm-dev at lists.llvm.org> wrote: >> Without this call, xray_instr_map gets empty in the executable, so that >> XRay doesn't patch anything. While implementing the tail call handling, I am >>...

...gt; ________________________________________ >> From: Renato Golin <renato.golin at linaro.org> >> Sent: Monday, January 9, 2017 11:50 PM >> To: Serge Rogatch >> Cc: Dean Michael Berris; LLVM Developers; Oleg Ranevskyy >> Subject: Re: [llvm-dev] Removed a call to EmitXRayTable() from ARMAsmPrinter >> >> On 9 January 2017 at 20:47, Serge Rogatch via llvm-dev >> <llvm-dev at lists.llvm.org> wrote: >>>> Without this call, xray_instr_map gets empty in the executable, so that >>>> XRay doesn't patch anything. While implement...

> As Oleg points out, apparently the way we've configured the XRay tests in compiler-rt/... excludes running tests on non-64-bit platforms. arm7 is definitely not 64-bit and therefore means we've not been running those tests. :( I believe that for this particular case one does not need to have execution tests - you'd simply need to check for expected output and that's it. --

Hi I try to implement a coarse-grained CFI in LLVM (CFI = Contorl Flow Integrity) I want to collect all address after call instructions address after a call equals to a valid return site in coarse-grained CFI I want to add a new section and write all the possible return address in the new section (and then, add the integrity check) I have some quetions: (1) Which part of LLVM code should

...unk/lib/xray/xray_interface_internal.h : struct XRaySledEntry { uint64_t Address; uint64_t Function; unsigned char Kind; unsigned char AlwaysInstrument; unsigned char Padding[14]; // Need 32 bytes }; And the peer code in llvm/trunk/lib/Target/X86/X86MCInstLower.cpp : void X86AsmPrinter::EmitXRayTable() { if (Sleds.empty()) return; if (Subtarget->isTargetELF()) { auto *Section = OutContext.getELFSection( "xray_instr_map", ELF::SHT_PROGBITS, ELF::SHF_ALLOC | ELF::SHF_GROUP | ELF::SHF_MERGE, 0, CurrentFnSym->getName()); auto PrevSection = Out...

> On 4 Aug 2016, at 06:27, Serge Rogatch <serge.rogatch at gmail.com> wrote: > > Hi Dean, > > I have a question about the following piece of code in compiler-rt/trunk/lib/xray/xray_trampoline_x86.S : > movq _ZN6__xray19XRayPatchedFunctionE(%rip), %rax > testq %rax, %rax > je .Ltmp0 > > // assume that %r10d has the function id. > movl %r10d,

...> uint64_t Function; > > unsigned char Kind; > > unsigned char AlwaysInstrument; > > unsigned char Padding[14]; // Need 32 bytes > > }; > > > > And the peer code in llvm/trunk/lib/Target/X86/X86MCInstLower.cpp : > > > > void X86AsmPrinter::EmitXRayTable() { > > if (Sleds.empty()) > > return; > > if (Subtarget->isTargetELF()) { > > auto *Section = OutContext.getELFSection( > > "xray_instr_map", ELF::SHT_PROGBITS, > > ELF::SHF_ALLOC | ELF::SHF_GROUP | ELF::SHF_MERGE, 0, &gt...