search for: emitmachineconstantpoolvalue

...use for MachineConstantPoolValue :-) Creating the constant is easy, but I have two problems: 1) what are the methods getExistingMachineCPValue and AddSelectionDAGCSEId supposed to do? 2) printing is hard because we are outside the AsmPrinter. In my current hack I am printing from ARMAsmPrinter::EmitMachineConstantPoolValue :-( Since this problem might also be significant to x86 (see my previous email), maybe we should just teach the pool printer to emit ".weak" directives... Best Regards, Rafael P.S.: rest assured that what is attached is just a demo hack and will not be committed :-) -------------- next...

...atch is quite small and shows where the address space > information is getting lost and it will correctly propagate it. It also > avoids existent back-ends to break because of an unimplemented hook in > MCAsmInfo. @@ -1046,7 +1046,8 @@ if (CPE.isMachineConstantPoolEntry()) EmitMachineConstantPoolValue(CPE.Val.MachineCPVal); else - EmitGlobalConstant(CPE.Val.ConstVal); + EmitGlobalConstant(CPE.Val.ConstVal, (isa<PointerType>(Ty)) ? + cast<PointerType>(Ty)->getAddressSpace() : 0); } } } This looks suspicious; how can an entry in the constant...

Hi Eli, On 07/05/2012 18:15, Eli Friedman wrote: > On Mon, May 7, 2012 at 5:15 AM, Ivan Llopard<ivanllopard at gmail.com> wrote: >> Hi all, >> >> Tuning my TargetAsmPrinter implementation in the back-end side, I >> discovered that the address space number is not passed down while >> emitting global variables with constant initializers. The information is

...FlagOutlineJumpTables; +cl::opt<std::string> FlagJumpTableSection("jumptable-section", + cl::init(".data.jtab")); + STATISTIC(EmittedInsts, "Number of machine instrs printed"); namespace { @@ -139,6 +145,7 @@ /// EmitMachineConstantPoolValue - Print a machine constantpool value to /// the .s file. virtual void EmitMachineConstantPoolValue(MachineConstantPoolValue *MCPV) { + // NOTE: A lot of this code is replicated in ARMConstantPoolValue::print printDataDirective(MCPV->getType()); ARMConstantPoolValu...

...s where the address space >> information is getting lost and it will correctly propagate it. It also >> avoids existent back-ends to break because of an unimplemented hook in >> MCAsmInfo. > @@ -1046,7 +1046,8 @@ > if (CPE.isMachineConstantPoolEntry()) > EmitMachineConstantPoolValue(CPE.Val.MachineCPVal); > else > - EmitGlobalConstant(CPE.Val.ConstVal); > + EmitGlobalConstant(CPE.Val.ConstVal, (isa<PointerType>(Ty)) ? > + cast<PointerType>(Ty)->getAddressSpace() : 0); > } > } > } > > This lo...

...Creating the constant is easy, but I have two problems: > > 1) what are the methods getExistingMachineCPValue and > AddSelectionDAGCSEId supposed to do? > > 2) printing is hard because we are outside the AsmPrinter. > > In my current hack I am printing from > ARMAsmPrinter::EmitMachineConstantPoolValue :-( > > Since this problem might also be significant to x86 (see my previous > email), maybe we should just teach the pool printer to emit ".weak" > directives... > > Best Regards, > Rafael > > P.S.: rest assured that what is attached is just a demo hack and wil...

On Jun 8, 2009, at 2:42 PM, robert muth wrote: > On Sun, Jun 7, 2009 at 11:53 PM, Evan Cheng <evan.cheng at apple.com> > wrote: >> >> On Jun 7, 2009, at 6:59 AM, robert muth wrote: >> >>> On Sat, Jun 6, 2009 at 4:51 PM, Evan Cheng<evan.cheng at apple.com> >>> wrote: >>>> +cl::opt<std::string>

On Sun, Jun 7, 2009 at 11:53 PM, Evan Cheng <evan.cheng at apple.com> wrote: > > On Jun 7, 2009, at 6:59 AM, robert muth wrote: > >> On Sat, Jun 6, 2009 at 4:51 PM, Evan Cheng<evan.cheng at apple.com> >> wrote: >>> +cl::opt<std::string> FlagJumpTableSection("jumptable-section", >>> +                                          

...quot; #include "llvm/Support/raw_ostream.h" #include <cctype> +#include <sstream> using namespace llvm; +extern cl::opt<bool> FlagOutlineJumpTables; + STATISTIC(EmittedInsts, "Number of machine instrs printed"); namespace { @@ -141,6 +145,7 @@ /// EmitMachineConstantPoolValue - Print a machine constantpool value to /// the .s file. virtual void EmitMachineConstantPoolValue(MachineConstantPoolValue *MCPV) { + // NOTE: A lot of this code is replicated in ARMConstantPoolValue::print printDataDirective(MCPV->getType()); ARMConstantPoolValu...