search for: emitlocalcommonsymbol

...ll, I noticed that the static local variable(internal global in .bc) is not aligned in ARM ELF(use MC(-filetype=obj)). Then I found that the alignment information is lost at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:316 if (MAI->hasLCOMMDirective()) { // .lcomm _foo, 42 OutStreamer.EmitLocalCommonSymbol(GVSym, Size); return; } MCStreamer::EmitLocalCommonSymbol have no parameter about alignment. Is this issue will cause some problem? The original c code: ===========test-lcomm.c========= #include <stdio.h> int main(){ static char a; static long long b; static long lo...

...tic local variable(internal global in .bc) is > not aligned in ARM ELF(use MC(-filetype=obj)). > Then I found that the alignment information is lost at: > lib/CodeGen/AsmPrinter/AsmPrinter.cpp:316 > if (MAI->hasLCOMMDirective()) { > // .lcomm _foo, 42 > OutStreamer.EmitLocalCommonSymbol(GVSym, Size); > return; > } > > MCStreamer::EmitLocalCommonSymbol have no parameter about alignment. > > Is this issue will cause some problem? > > > > The original c code: > ===========test-lcomm.c========= > #include <stdio.h> > int main(){ &gt...

...s design. It seemed to be that having these calls with the restrictions on when they would be allowed would simplify an object file writers job sifting though the incoming data and organizing into what will become the output file. I had a problem with MCStreamer::EmitCommonSymbol & MCStreamer::EmitLocalCommonSymbol. When I implemented them I assumed this meant to put those symbols into the .bss segment. This required me to get a hold of the TLOF from the streamer. I now realize this is wrong after re-reading the description of the '.comm' directive a few times. I am not sure why an uninitialized glob...

On May 4, 2010, at 11:03 AM, Nathan Jeffords wrote: > This is a brain-dump of my thoughts on the MCStreamer interface after several > days of digging around trying to get a COFF writer working. Great! Something that is worth pointing out is that the MCStreamer API is intended to directly reflect what is happening in .s files. We basically want one MCStreamer callback to correspond to one

...COFFSymbolDef(); > virtual void EmitELFSize(MCSymbol *Symbol, const MCExpr *Value); > virtual void EmitCommonSymbol(MCSymbol *Symbol, uint64_t Size, > - unsigned ByteAlignment); > + unsigned ByteAlignment); > virtual void EmitLocalCommonSymbol(MCSymbol *Symbol, uint64_t Size); > virtual void EmitZerofill(const MCSection *Section, MCSymbol *Symbol, > - unsigned Size,unsigned ByteAlignment); > + unsigned Size,unsigned ByteAlignment); > virtual void EmitTBSSSymbol(const MCSecti...

On Sun, Jul 11, 2010 at 6:10 PM, Chris Lattner <clattner at apple.com> wrote: > This probably needs to be slightly tweaked to work with mainline.  I don't see anything objectionable, but I think Daniel needs to review this one. Updated patch to work with mainline. http://github.com/Bigcheese/llvm-mirror/commit/d19a4c82c18afc4830c09b70f02d162292231c94 - Michael Spencer

On Wed, May 5, 2010 at 1:22 PM, Nathan Jeffords <blunted2night at gmail.com> wrote: > I had a problem with MCStreamer::EmitCommonSymbol > & MCStreamer::EmitLocalCommonSymbol. When I implemented them I assumed this > meant to put those symbols into the .bss segment. This required me to get a > hold of the TLOF from the streamer. I now realize this is wrong after > re-reading the description of the '.comm' directive a few times.  I am not > sure why a...

This is a brain-dump of my thoughts on the MCStreamer interface after several days of digging around trying to get a COFF writer working. All fragments should be associated with a symbol. For assembler components, a unnammed "virtual" symbol can be used when there is no explicit label defined. Section assignment should be the responsiblity of the object imlementing the MCStreamer

Does anybody know if there is a particular reason why MCAsmStreamer doesn't have its own .h file? https://github.com/llvm-mirror/llvm/blob/0e66a5f53c74056f95d178c86531d7d9cfb23da9/lib/MC/MCAsmStreamer.cpp#L41 It seems like it is a good idea to have this class declared as its own module ( its own .cpp and .h files). That would make it easier to inherit from it if there is a need (like in my

...CSymbol* to whatever data you need to associate with a symbol. This is equivalent to embedding per-symbol stuff in the MCSymbol itself. MCSection should be subclassed and you should put COFF specific stuff in MCSectionCOFF. > I had a problem with MCStreamer::EmitCommonSymbol & MCStreamer::EmitLocalCommonSymbol. When I implemented them I assumed this meant to put those symbols into the .bss segment. This required me to get a hold of the TLOF from the streamer. I now realize this is wrong after re-reading the description of the '.comm' directive a few times. I am not sure why an uninitialized glob...