search for: emitlinkage

On May 10, 2010, at 6:46 PM, Nathan Jeffords wrote: > I have been looking over AsmPrinter::EmitLinkage (around line 195 of lib\CodeGen\AsmPrinter\AsmPrinter.cpp) and it seems that its implementation will vary quite a bit depending on what object file format is in use (MachO, ELF, or COFF). > Would it make sense to delegate the implementation to a specialized object from current the object file f...

> I think it emits valid output, but I don't think it handles weak symbols > correctly, as COFF supports true weak symbols, but this code appears to turn > them into a linkonce section which is not quite the same thing. Yes. This was intentional, since: 1. At the time of writing the code binutils did not support weak stuff 2. It was my feeling, that weak (especially external weak

> For the windows sub-target is it safe to assume Microsoft's linker is the being targeted? I'd really appreciate if both ms link and gnu ld will be tested, if this is possible. -- With best regards, Anton Korobeynikov Faculty of Mathematics and Mechanics, Saint Petersburg State University

On 11 May 2010 18:04, Anton Korobeynikov <anton at korobeynikov.info> wrote: > > For the windows sub-target is it safe to assume Microsoft's linker is the > being targeted? > I'd really appreciate if both ms link and gnu ld will be tested, if > this is possible. I have done some tests with Cygwin, and most things seem okay, e.g. Static Constructors...Virtual

On Tue, May 11, 2010 at 10:49 AM, Aaron Gray < aaronngray.lists at googlemail.com> wrote: > On 11 May 2010 18:04, Anton Korobeynikov <anton at korobeynikov.info> wrote: > >> > For the windows sub-target is it safe to assume Microsoft's linker is >> the being targeted? >> I'd really appreciate if both ms link and gnu ld will be tested, if >>

I noticed that AsmPrinter::EmitLinkage doesn't handle ExternalWeakLinkage. Is that an oversight or is something deeper going on? -Dave

I have been looking over AsmPrinter::EmitLinkage (around line 195 of lib\CodeGen\AsmPrinter\AsmPrinter.cpp) and it seems that its implementation will vary quite a bit depending on what object file format is in use (MachO, ELF, or COFF). Would it make sense to delegate the implementation to a specialized object from current the object file forma...

On Tue, May 11, 2010 at 2:03 AM, Anton Korobeynikov <anton at korobeynikov.info > wrote: > > I think it emits valid output, but I don't think it handles weak symbols > > correctly, as COFF supports true weak symbols, but this code appears to > turn > > them into a linkonce section which is not quite the same thing. > Yes. This was intentional, since: > 1. At

On Mon, May 10, 2010 at 9:43 PM, Chris Lattner <clattner at apple.com> wrote: > > On May 10, 2010, at 6:46 PM, Nathan Jeffords wrote: > > > I have been looking over AsmPrinter::EmitLinkage (around line 195 of > lib\CodeGen\AsmPrinter\AsmPrinter.cpp) and it seems that its implementation > will vary quite a bit depending on what object file format is in use (MachO, > ELF, or COFF). > > Would it make sense to delegate the implementation to a specialized > object from...

On Jul 12, 2010, at 5:27 PM, David Greene wrote: > I noticed that AsmPrinter::EmitLinkage doesn't handle > ExternalWeakLinkage. Is that an oversight or is something > deeper going on? EmitLinkage is never called on external globals. -Chris

> I have not looked at how gcc implements this internally but in LLVM I'm > creating real IR for a function (the stub being in mips32 mode; even though > the rest of the compilation unit is being compiled in mips16 mode). This is > one (not the only) reason why I implemented the ability to switch processor > modes on a per function basis. Now that I see where this is from, why

Hi, I'm a little confused over the use of WeakDefDirective & getWeakDefDirective() as it seems to be used differently to WeakRefDirective & getWeakRefDirective(). WeakDefDirective seems to be a boolean, used by AsmPrinter::EmitLinkage(), to decide if special stuff needs to be done. As I just want "weak", I should leave WeakDefDirective as null. Is this right? It would be nice if there was a additional hasWeakDefDirective that a target could specify (default false). Also should MCAsmStreamer::EmitSymbolAttribute() emi...