search for: emitdata

Displaying 3 results from an estimated 3 matches for "emitdata".

2017 Jun 30
2
llvm-profdata determinism
...even test cases written against this should be deterministic, but yeah - less of a concern, for sure. > . >> >> The binary writing looks like it'd have similar issues - looping through >> these unordered maps & writing output (eg: >> InstrProfRecordWriterTrait::EmitData loops through the data in the same >> SmallDenseMap and writes content in that order so far as I can tell. >> >> > Binary dump does not have the problem. The binary format of the indexed > profile data is on-disk hashtable. Before serializing into the disk, the > instPro...
2017 Jun 30
0
llvm-profdata determinism
...tten against this should be deterministic, > but yeah - less of a concern, for sure. > > >> . >>> >>> The binary writing looks like it'd have similar issues - looping through >>> these unordered maps & writing output (eg: InstrProfRecordWriterTrait::EmitData >>> loops through the data in the same SmallDenseMap and writes content in that >>> order so far as I can tell. >>> >>> >> Binary dump does not have the problem. The binary format of the indexed >> profile data is on-disk hashtable. Before serializin...
2017 Jun 30
2
llvm-profdata determinism
...ut. Certainly the textual output iterates over FunctionData which is a StringMap of SmallDenseMaps, neither of which has deterministic iteration. The binary writing looks like it'd have similar issues - looping through these unordered maps & writing output (eg: InstrProfRecordWriterTrait::EmitData loops through the data in the same SmallDenseMap and writes content in that order so far as I can tell. Generally it's important that the compiler (& I believe related tools) have deterministic output. Is there a reason that wouldn't be the case for llvm-profdata? Or have I misunderst...