search for: eltty

...hould be able to do something like: if (ID.ConstantVal->getType() != Ty) if (Constant *Elt = TryConvertingSingleElementStructToUnion(...)) return Elt; +++ lib/Bitcode/Reader/BitcodeReader.cpp (working copy) @@ -584,6 +584,13 @@ ResultTy = StructType::get(Context, EltTys, Record[0]); break; } + case bitc::TYPE_CODE_UNION: { // UNION: [eltty x N] + std::vector<const Type*> EltTys; + for (unsigned i = 0, e = Record.size(); i != e; ++i) + EltTys.push_back(getTypeByID(Record[i], true)); + ResultTy = UnionType::get(&Elt...

...if (ID.ConstantVal->getType() != Ty) > if (Constant *Elt = TryConvertingSingleElementStructToUnion(...)) > return Elt; > > > > +++ lib/Bitcode/Reader/BitcodeReader.cpp (working copy) > @@ -584,6 +584,13 @@ > ResultTy = StructType::get(Context, EltTys, Record[0]); > break; > } > + case bitc::TYPE_CODE_UNION: { // UNION: [eltty x N] > + std::vector<const Type*> EltTys; > + for (unsigned i = 0, e = Record.size(); i != e; ++i) > + EltTys.push_back(getTypeByID(Record[i], true)); > + Res...

...if (ID.ConstantVal->getType() != Ty) > if (Constant *Elt = TryConvertingSingleElementStructToUnion(...)) > return Elt; > > > > +++ lib/Bitcode/Reader/BitcodeReader.cpp (working copy) > @@ -584,6 +584,13 @@ > ResultTy = StructType::get(Context, EltTys, Record[0]); > break; > } > + case bitc::TYPE_CODE_UNION: { // UNION: [eltty x N] > + std::vector<const Type*> EltTys; > + for (unsigned i = 0, e = Record.size(); i != e; ++i) > + EltTys.push_back(getTypeByID(Record[i], true)); > + Res...

...de/llvm/ADT/PointerUnion.h:153: instantiated from ‘const PT1* llvm::PointerUnion<PT1, PT2>::getAddrOf() const [with T = llvm::VNInfo*, PT1 = llvm::VNInfo*, PT2 = llvm::SmallVector<llvm::VNInfo*, 4u>*]’ /src/llvm-trunk-dev/include/llvm/ADT/TinyPtrVector.h:63: instantiated from ‘const EltTy* llvm::TinyPtrVector<EltTy>::begin() const [with EltTy = llvm::VNInfo*]’ /src/llvm-trunk-dev/lib/CodeGen/InlineSpiller.cpp:382: instantiated from here /src/llvm-trunk-dev/include/llvm/ADT/PointerIntPair.h:98: warning: dereferencing type-punned pointer will break strict-aliasing rules I thi...

OK here's the patch for real this time :) On Fri, Jan 15, 2010 at 4:36 PM, Talin <viridia at gmail.com> wrote: > Here's a work in progress of the union patch. Note that the test "union.ll" > does not work, so you probably don't want to check this in as is. However, > I'd be interested in any feedback you're willing to give. > > -- > -- Talin

Here's a work in progress of the union patch. Note that the test "union.ll" does not work, so you probably don't want to check this in as is. However, I'd be interested in any feedback you're willing to give. -- -- Talin -------------- next part -------------- An HTML attachment was scrubbed... URL:

...ion not to fire: diff --git lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.cpp index 048c8f8..2bded23 100644 --- lib/CodeGen/CGDebugInfo.cpp +++ lib/CodeGen/CGDebugInfo.cpp @@ -771,7 +771,7 @@ llvm::DIType CGDebugInfo::CreateType(const FunctionType *Ty, SmallVector<llvm::Value *, 16> EltTys; // Add the result type at least. - EltTys.push_back(getOrCreateType(Ty->getReturnType(), Unit)); + EltTys.push_back(getOrCreateType(Ty->getReturnType(), Unit).getRef()); // Set up remainder of arguments if there is a prototype. // otherwise emit it as a variadic function. @@ -7...

...+++ b/include/llvm/Bitcode/LLVMBitCodes.h @@ -110,10 +110,12 @@ namespace bitc { TYPE_CODE_METADATA = 16, // METADATA TYPE_CODE_X86_MMX = 17, // X86 MMX + + TYPE_CODE_HALF = 18, // IEEE HALF (16-bit fp) - TYPE_CODE_STRUCT_ANON = 18, // STRUCT_ANON: [ispacked, eltty x N] - TYPE_CODE_STRUCT_NAME = 19, // STRUCT_NAME: [strchr x N] - TYPE_CODE_STRUCT_NAMED = 20 // STRUCT_NAMED: [ispacked, eltty x N] + TYPE_CODE_STRUCT_ANON = 19, // STRUCT_ANON: [ispacked, eltty x N] + TYPE_CODE_STRUCT_NAME = 20, // STRUCT_NAME: [strchr x N] + TYPE_CODE_STRUCT_NAMED...

...ext &ctx = getGlobalContext(); > > Type *void_type( Type::getVoidTy( ctx ) ); > PointerType *void_ptr_type( void_type->getPointerTo() ); > > return 0; > } When compiled using the clang binaries with MinGW32 and run, I get: > Assertion failed: isValidElementType(EltTy) && "Invalid type for pointer element!", file /Users/asl/Projects/llvm/release/3.1/src/lib/VMCore/Type.cpp, line 748 Why? - Paul

...pe() != Ty) >> if (Constant *Elt = TryConvertingSingleElementStructToUnion(...)) >> return Elt; >> >> >> >> +++ lib/Bitcode/Reader/BitcodeReader.cpp (working copy) >> @@ -584,6 +584,13 @@ >> ResultTy = StructType::get(Context, EltTys, Record[0]); >> break; >> } >> + case bitc::TYPE_CODE_UNION: { // UNION: [eltty x N] >> + std::vector<const Type*> EltTys; >> + for (unsigned i = 0, e = Record.size(); i != e; ++i) >> + EltTys.push_back(getTypeByID(Record[i],...

Hello, after completing the build i get ... BUILD SUCCESSFUL Total time: 5 seconds llvm[2]: Building Release+Asserts mmtk-vmkit.jar all vmjc: /home1/public/zakkak/llvm/lib/VMCore/Type.cpp:747: static llvm::PointerType *llvm::PointerType::get(llvm::Type *, unsigned int): Assertion `EltTy && "Can't get a pointer to <null> type!"' failed. 0 vmjc 0x0000000000d24e1f 1 vmjc 0x0000000000d25334 2 libpthread.so.0 0x00002b398f36b8f0 3 libc.so.6 0x00002b3990178a75 gsignal + 53 4 libc.so.6 0x00002b399017c5c0 abort + 384 5...

+Adrian & Manman, Looks like this is a case of non-DIRef references ending up in the IR, and thus the references not being deduplicated. This could lead to some of the IR bloat that you guys implemented the DIRef stuff to reduce/avoid. The specific issue is that the type is slightly different in the two TUs (since the namespace scope it's contained within is different in the two TUs -

...g the build i get > > ... > BUILD SUCCESSFUL > Total time: 5 seconds > llvm[2]: Building Release+Asserts mmtk-vmkit.jar all > vmjc: /home1/public/zakkak/llvm/lib/VMCore/Type.cpp:747: static > llvm::PointerType *llvm::PointerType::get(llvm::Type *, unsigned int): > Assertion `EltTy && "Can't get a pointer to <null> type!"' failed. > 0 vmjc 0x0000000000d24e1f > 1 vmjc 0x0000000000d25334 > 2 libpthread.so.0 0x00002b398f36b8f0 > 3 libc.so.6 0x00002b3990178a75 gsignal + 53 > 4 libc.so.6 0x00002b...

> When compiled using the clang binaries with MinGW32 and run, I get: >> Assertion failed: isValidElementType(EltTy) && "Invalid type for pointer element!", file /Users/asl/Projects/llvm/release/3.1/src/lib/VMCore/Type.cpp, line 748 > Why? Because there is no void* in LLVM IR world -- With best regards, Anton Korobeynikov Faculty of Mathematics and Mechanics, Saint Petersburg State Univers...

...... > BUILD SUCCESSFUL > Total time: 5 seconds > llvm[2]: Building Release+Asserts mmtk-vmkit.jar all > vmjc: /home1/public/zakkak/llvm/lib/VMCore/Type.cpp:747: static > llvm::PointerType *llvm::PointerType::get(llvm::Type *, unsigned int): > Assertion `EltTy && "Can't get a pointer to <null> type!"' failed. > 0 vmjc 0x0000000000d24e1f > 1 vmjc 0x0000000000d25334 > 2 libpthread.so.0 0x00002b398f36b8f0 > 3 libc.so.6 0x00002b3990178a75 gsignal + 53 > 4 libc...

...case copysignpd256: > + case copysignps: > + case copysignps256: { > + if (Ops.size() != 2) > + return false; > + VectorType *VecTy = dyn_cast<VectorType>(Ops[0]->getType()); > + if (Ops[1]->getType() != VecTy) > + return false; > + Type *EltTy = VecTy->getElementType(); > + unsigned EltBitWidth = EltTy->getPrimitiveSizeInBits(); > + Type *IntEltTy = IntegerType::get(Context, EltBitWidth); > + Type *IntVecTy = VectorType::get(IntEltTy, VecTy->getNumElements()); > + APInt SignBit = APInt::getSignBit(EltBitW...

...Type (this=0x850f00, FieldName=...) at Record.cpp:633 #4 0x0000000000543f64 in llvm::TGParser::ParseValue (this=0x7fffffffd480, CurRec=0x8511d0, ItemType=0x851540) at TGParser.cpp:1342 #5 0x0000000000544574 in llvm::TGParser::ParseValueList (this=0x7fffffffd480, CurRec=0x8511d0, ArgsRec=0x8510d0, EltTy=0x0) at TGParser.cpp:1405 #6 0x000000000053e520 in llvm::TGParser::ParseSubClassReference (this=0x7fffffffd480, CurRec=0x8511d0, isDefm=false) at TGParser.cpp:397 #7 0x00000000005458e5 in llvm::TGParser::ParseObjectBody (this=0x7fffffffd480, CurRec=0x8511d0) at TGParser.cpp:1613 #8 0x00000000005...

...time: 5 seconds >> llvm[2]: Building Release+Asserts mmtk-vmkit.jar all >> vmjc: /home1/public/zakkak/llvm/lib/VMCore/Type.cpp:747: static >> llvm::PointerType *llvm::PointerType::get(llvm::Type *, >> unsigned int): >> Assertion `EltTy && "Can't get a pointer to <null> type!"' >> failed. >> 0 vmjc 0x0000000000d24e1f >> 1 vmjc 0x0000000000d25334 >> 2 libpthread.so.0 0x00002b398f36b8f0 >> 3 libc.so.6...

...gt; ... >> BUILD SUCCESSFUL >> Total time: 5 seconds >> llvm[2]: Building Release+Asserts mmtk-vmkit.jar all >> vmjc: /home1/public/zakkak/llvm/lib/VMCore/Type.cpp:747: static >> llvm::PointerType *llvm::PointerType::get(llvm::Type *, unsigned int): >> Assertion `EltTy && "Can't get a pointer to <null> type!"' failed. >> 0 vmjc 0x0000000000d24e1f >> 1 vmjc 0x0000000000d25334 >> 2 libpthread.so.0 0x00002b398f36b8f0 >> 3 libc.so.6 0x00002b3990178a75 gsignal + 53 >> 4 libc...

...=0x850f00, FieldName=...) at Record.cpp:633 > #4 0x0000000000543f64 in llvm::TGParser::ParseValue (this=0x7fffffffd480, CurRec=0x8511d0, ItemType=0x851540) at TGParser.cpp:1342 > #5 0x0000000000544574 in llvm::TGParser::ParseValueList (this=0x7fffffffd480, CurRec=0x8511d0, ArgsRec=0x8510d0, EltTy=0x0) at TGParser.cpp:1405 > #6 0x000000000053e520 in llvm::TGParser::ParseSubClassReference (this=0x7fffffffd480, CurRec=0x8511d0, isDefm=false) at TGParser.cpp:397 > #7 0x00000000005458e5 in llvm::TGParser::ParseObjectBody (this=0x7fffffffd480, CurRec=0x8511d0) at TGParser.cpp:1613 > #8...