search for: elemty

...t; >> >> Funky indentation in ConstantUnion::replaceUsesOfWithOnConstant and >> implementation missing :) >> >> In UnionValType methods, please use "UT" instead of "ST" as an acronym. >> >> +bool UnionType::isValidElementType(const Type *ElemTy) { >> + return ElemTy->getTypeID() != VoidTyID && ElemTy->getTypeID() != >> LabelTyID && >> + ElemTy->getTypeID() != MetadataTyID && >> !isa<FunctionType>(ElemTy); >> +} >> >> Please use "!ElemTy->isVo...

...ement replaceUsesOfWithOnConstant for unions"); +} + Still not implemented? +UnionType *UnionType::get(const Type *type, ...) { + va_list ap; + std::vector<const llvm::Type*> UnionFields; + va_start(ap, type); Please use smallvector. +bool UnionType::isValidElementType(const Type *ElemTy) { + return !ElemTy->isVoidTy() && !ElemTy->isLabelTy() && + !ElemTy->isMetadataTy() && !isa<FunctionType>(ElemTy); +} Isn't there a better predicate somewhere? +LLVMTypeRef LLVMUnionTypeInContext(LLVMContextRef C, LLVMTypeRef *ElementTypes, +...

...e things which revert a recent patch, please don't :) Funky indentation in ConstantUnion::replaceUsesOfWithOnConstant and implementation missing :) In UnionValType methods, please use "UT" instead of "ST" as an acronym. +bool UnionType::isValidElementType(const Type *ElemTy) { + return ElemTy->getTypeID() != VoidTyID && ElemTy->getTypeID() != LabelTyID && + ElemTy->getTypeID() != MetadataTyID && ! isa<FunctionType>(ElemTy); +} Please use "!ElemTy->isVoidTy()" etc. --- lib/VMCore/ConstantsContext.h (revi...

...please don't > :) > > > Funky indentation in ConstantUnion::replaceUsesOfWithOnConstant and > implementation missing :) > > In UnionValType methods, please use "UT" instead of "ST" as an acronym. > > +bool UnionType::isValidElementType(const Type *ElemTy) { > + return ElemTy->getTypeID() != VoidTyID && ElemTy->getTypeID() != > LabelTyID && > + ElemTy->getTypeID() != MetadataTyID && > !isa<FunctionType>(ElemTy); > +} > > Please use "!ElemTy->isVoidTy()" etc. > >...

...T/EquivalenceClasses.h (revision 108148) +++ include/llvm/ADT/EquivalenceClasses.h (working copy) @@ -169,7 +169,7 @@ /// getOrInsertLeaderValue - Return the leader for the specified value that is /// in the set. If the member is not in the set, it is inserted, then /// returned. - const ElemTy &getOrInsertLeaderValue(const ElemTy &V) const { + const ElemTy &getOrInsertLeaderValue(const ElemTy &V) { member_iterator MI = findLeader(insert(V)); assert(MI != member_end() && "Value is not in the set!"); return *MI; -------------- next part ---...

...please don't > :) > > > Funky indentation in ConstantUnion::replaceUsesOfWithOnConstant and > implementation missing :) > > In UnionValType methods, please use "UT" instead of "ST" as an acronym. > > +bool UnionType::isValidElementType(const Type *ElemTy) { > + return ElemTy->getTypeID() != VoidTyID && ElemTy->getTypeID() != > LabelTyID && > + ElemTy->getTypeID() != MetadataTyID && > !isa<FunctionType>(ElemTy); > +} > > Please use "!ElemTy->isVoidTy()" etc. > >...

...d CMake to create solution... building mostly seems to be OK, except for a couple of compiler errors. warning C4090: 'function' : different 'const' qualifiers d:\companyone\external\llvm\source\llvm-2.7\lib\support\regengine.inc 188 error C2248: 'llvm::EquivalenceClasses<ElemTy>::ECValue::ECValue' : cannot access private member declared in class 'llvm::EquivalenceClasses<ElemTy>::ECValue' C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\xmemory 208 error C2668: 'llvm::next' : ambiguous call to overloaded function D:\Company...

Hey, So I tried to fix these errors, and have everything compiling now... not too difficult, just annoying. error C2248: 'llvm::EquivalenceClasses< > > ElemTy>::ECValue::ECValue' : cannot access private member declared in class > 'llvm::EquivalenceClasses<ElemTy>::ECValue' C:\Program Files > (x86)\Microsoft Visual Studio 10.0\VC\include\xmemory 208 I moved: // ECValue ctor - Start out with EndOfList pointing to thi...

OK here's the patch for real this time :) On Fri, Jan 15, 2010 at 4:36 PM, Talin <viridia at gmail.com> wrote: > Here's a work in progress of the union patch. Note that the test "union.ll" > does not work, so you probably don't want to check this in as is. However, > I'd be interested in any feedback you're willing to give. > > -- > -- Talin

Here's a work in progress of the union patch. Note that the test "union.ll" does not work, so you probably don't want to check this in as is. However, I'd be interested in any feedback you're willing to give. -- -- Talin -------------- next part -------------- An HTML attachment was scrubbed... URL:

...onType::get(const Type *type, ...) { > + va_list ap; > + std::vector<const llvm::Type*> UnionFields; > + va_start(ap, type); > > Please use smallvector. > Done - although I was just copying from what Struct does. > > +bool UnionType::isValidElementType(const Type *ElemTy) { > + return !ElemTy->isVoidTy() && !ElemTy->isLabelTy() && > + !ElemTy->isMetadataTy() && !isa<FunctionType>(ElemTy); > +} > > Isn't there a better predicate somewhere? > Apparently there is now. Done. > > +LLVMTypeRef...

...ysis/DataStructure/DSGraph.h: 20, from /home/ejones/llvm/llvm3/include/llvm/Analysis/DataStructure/ DSGraphTraits.h:19, from DataStructure.cpp:14: /home/ejones/llvm/llvm3/include/llvm/ADT/EquivalenceClasses.h: In constructor `llvm::EquivalenceClasses<ElemTy>::ECValue::ECValue(const ElemTy&)': /home/ejones/llvm/llvm3/include/llvm/ADT/EquivalenceClasses.h:72: parse error before `;' token Evan Jones

...} Tom. On Sat, May 1, 2010 at 8:57 PM, Tom van Dijck <llvm at tomvandijck.com> wrote: > Hey, > > So I tried to fix these errors, and have everything compiling now... not > too difficult, just annoying. > > error C2248: 'llvm::EquivalenceClasses< >> >> ElemTy>::ECValue::ECValue' : cannot access private member declared in >> class 'llvm::EquivalenceClasses<ElemTy>::ECValue' C:\Program Files >> (x86)\Microsoft Visual Studio 10.0\VC\include\xmemory 208 > > > I moved: > > // ECValue ctor - Start out...

...siest fix is to explicitly call the constructor of ECValue before the insert/find calls. If I'm understanding the concern, this looks easy to fix to me by simply making the private construction explicit within the scope of the code which has access to this constructor: iterator insert(const ElemTy &Data) { return TheMapping.insert(ECValue(Data)).first; } You can make this change today, and it will work with your C++03 compiler with no loss of efficiency, and arguably improved clarity. > 2. There are numerous places where there is a std::pair of pointer types and passing 0 resu...

Sorry, always end up not replying to the list: The main issue with dealing with next this way is that people adding new uses of next will probably not be using c++0x and therefore won't know it's ambiguous and that it needs to be qualified. There are also two issues with rvalue references and the STL: 1. EquivalenceClasses, in the insert and findLeader functions, it uses map functions

...libc-start.c:344:0 #18 0x0000564bac791a9a _start (/usr/local/bin/lli+0x110aa9a) [1] 12828 abort (core dumped) /usr/local/bin/lli --force-interpreter pngpixel_crash.bc 0 0 mini.png So I'm certaint that the crash happend in ExecutionEngine::getConstantValue. In addition, I have noticed that ElemTy->getTypeID() is 15 ( pointer type of type struct.code ) but the switch branch ( Line 917 ) in not able to deal with it so the llvm_unrecheable instruction is reached. So I can conclude that the problem is that the switch branch is not able to deal with pointers.. Any suggestion on how to fix it...

...bin/lli+0x110aa9a) >> [1] 12828 abort (core dumped) /usr/local/bin/lli --force-interpreter >> pngpixel_crash.bc 0 0 mini.png >> >> So I'm certaint that the crash happend >> in ExecutionEngine::getConstantValue. >> >> In addition, I have noticed that ElemTy->getTypeID() is 15 ( pointer type >> of type struct.code ) but the switch branch ( Line 917 ) in not able to >> deal with it so the llvm_unrecheable instruction is reached. >> >> So I can conclude that the problem is that the switch branch is not able >> to deal wit...

...gt; [1] 12828 abort (core dumped) /usr/local/bin/lli --force-interpreter >>> pngpixel_crash.bc 0 0 mini.png >>> >>> So I'm certaint that the crash happend >>> in ExecutionEngine::getConstantValue. >>> >>> In addition, I have noticed that ElemTy->getTypeID() is 15 ( pointer >>> type of type struct.code ) but the switch branch ( Line 917 ) in not able >>> to deal with it so the llvm_unrecheable instruction is reached. >>> >>> So I can conclude that the problem is that the switch branch is not able >...

Hi David, In pretty sure that the crash is due to the instruction I have shared in my first email. In order to run pngpixel you just need libpng and zlib.. honest I thought that the .bc had Al the necessary. I'm happy to help you to reproduce it. As a curiosity, why do you think you cannot reproduce it? Unfortunately I won't be able to modify the interpreter soon.. anyway, I'll try to