search for: efi_udp4_config_data

...+ void* buf; + uint16_t* buf_len; + uint32_t* src_ip; + uint16_t* src_port; +}RX; + +/// +/// Type defined as UDP_IO. +/// This data structure wraps the UDP instance and configuration. +/// +typedef struct { + uint16_t known_TID; + struct efi_binding* b; + EFI_UDP4* Protocol_Udp4; + EFI_UDP4_CONFIG_DATA Config_Udp4; + EFI_UDP4_COMPLETION_TOKEN* Token; + EFI_EVENT Timeout_Timer; + EFI_EVENT CB_OK_Event; + RX rx; +}UDP_IO; + + +#define EFI_IP4_EQUAL(Ip1, Ip2) (CompareMem ((Ip1), (Ip2), sizeof (EFI_IPv4_ADDRESS)) == 0) +EFI_IPv4_ADDRESS mZeroIp4Addr = {{0, 0, 0, 0}}; +static BOOLEAN vola...

The variable 'ok' is never used and generates a warning. Remove it. Also ntfssect.c is designed to be compiled in non Unicode mode when using MSVC compilers, so remove all ambiguity about it (LPCTSTR -> LPCSTR, use of 'A' API calls) so that it doesn't break when compiled in Unicode mode, which is what Rufus uses with MSVC. -------------- next part --------------

...D + 500 * TICKS_PER_MS > +#define UDP_TIME_RX_TIMEOUT 1 * TICKS_PER_SECOND + 500 * TICKS_PER_MS <snip/> > > /** > - * Try to configure this UDP socket > + * Try to configure this UDP_IO > * > - * @param:udp, the EFI_UDP4 socket to configure > - * @param:udata, the EFI_UDP4_CONFIG_DATA to use > - * @param:f, the name of the function as a wide string. > + * @param:udp_io, The UDP_IO containing the EFI_UDP4 socket to configure > + * and the EFI_UDP4_CONFIG_DATA to use. > + * @param:f, The name of the invoking function as a wide string. > * > * @out: status...

...memcpy(&udata.SubnetMask, &IPInfo.netmask, sizeof(IPInfo.netmask)); > + memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); > + udata.RemotePort = port; > + udata.AcceptPromiscuous = TRUE; > + Looking at UEFI Spec v2.5 (same wording since the oldest 2.0 I have) for EFI_UDP4_CONFIG_DATA, I could see now why an EFI implementer might misinterpret the language and say that UseDefaultAddress is broken for transmit even though my interpretation is that it will work for transmit but is ignored for receive filtering. -- -Gene

Signed-off-by: Julien Viard de Galbert <jviarddegalbert at online.net> --- efi/udp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/efi/udp.c b/efi/udp.c index 1088f47..b0f13ad 100644 --- a/efi/udp.c +++ b/efi/udp.c @@ -163,7 +163,7 @@ void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, } else { udata.UseDefaultAddress = FALSE;

...Viard de Galbert <jviarddegalbert at online.net> --- efi/udp.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/efi/udp.c b/efi/udp.c index b0f13ad..8f4d7dc 100644 --- a/efi/udp.c +++ b/efi/udp.c @@ -52,7 +52,7 @@ EFI_STATUS core_udp_configure(EFI_UDP4 *udp, EFI_UDP4_CONFIG_DATA *udata, } } else { if (status != EFI_SUCCESS) { - Print(L"%s: udp->Configure() unsuccessful (%d)", f, status); + Print(L"%s: udp->Configure() unsuccessful (%d)\n", f, status); if (!efi_net_def_addr && (status == EFI_INVALID_PARAMETER)) efi...

...;IPInfo.netmask, sizeof(IPInfo.netmask)); > > + memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); > > + udata.RemotePort = port; > > + udata.AcceptPromiscuous = TRUE; > > + > > Looking at UEFI Spec v2.5 (same wording since the oldest 2.0 I have) > for EFI_UDP4_CONFIG_DATA, I could see now why an EFI implementer might > misinterpret the language and say that UseDefaultAddress is broken for > transmit even though my interpretation is that it will work for > transmit but is ignored for receive filtering. As with all things related to UEFI there's a certai...

...d to get UDP mode data: %d\n", status); + else + socket->net.efi.localport = udata.StationPort; + return 0; bail: @@ -89,7 +100,6 @@ void core_udp_close(struct pxe_pvt_inode *socket) void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, uint16_t port) { - EFI_UDP4_CONFIG_DATA udata; EFI_STATUS status; EFI_UDP4 *udp; @@ -113,20 +123,6 @@ void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, return; } - /* - * If this is the first time connecting, save the random local port - * number that the UDPv4 Protocol Driver picked for us....

I did change both instances of txdata->GatewayAddress, but I think something may be wrong in my toolchain. If I extract syslinux.zip and attempt to make from there (without modifying any files), the cached DHCP packet isn't read on the same subnet. I receive "Succeed to download NBP file." twice before anything from syslinux is loaded, so I believe the duplicate request for

...- Diffstat: udp.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 50 insertions(+), 2 deletions(-) --- udp.c 2015-07-06 07:22:04.000000000 -0700 +++ efi/udp.c 2015-07-08 12:13:48.000000000 -0700 @@ -142,6 +142,7 @@ void core_udp_connect(struct pxe_pvt_ino EFI_UDP4_CONFIG_DATA udata; EFI_STATUS status; EFI_UDP4 *udp; + uint32_t tip; udp = (EFI_UDP4 *)socket->net.efi.binding->this; @@ -150,7 +151,30 @@ void core_udp_connect(struct pxe_pvt_ino /* Re-use the existing local port number */ udata.StationPort = socket->net.efi.localport;...

...however, the defaults do not work. In that case, the packets were not parsed to get any of the ip addresses so I used IPInfo to get client ip and netmask instead of using defaults. In efi/udp.c: void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, uint16_t port) { EFI_UDP4_CONFIG_DATA udata; EFI_STATUS status; EFI_UDP4 *udp; udp = (EFI_UDP4 *)socket->net.efi.binding->this; memset(&udata, 0, sizeof(udata)); /* Re-use the existing local port number */ udata.StationPort = socket->net.efi.localport; -- udata.UseDefaultAddress = TRUE; ++ uda...