search for: efi_service_bind

>>> > I think these changes would solve the thing. > > ... > -EFI_SERVICE_BINDING *sbp; > +EFI_SERVICE_BINDING *sbp =NULL; > ... > > -? ? if (status != EFI_SUCCESS) > +? ? if (status != EFI_SUCCESS || sbp == NULL) >? ? ? ? goto free_binding; > ... The presumption was that we'd see an error rather than non-error from LibLocateHandle() when...

...dle; break; } } } } if (status != EFI_SUCCESS) goto free_binding; child = NULL; status = uefi_call_wrapper(sbp->CreateChild, 2, sbp, (EFI_HANDLE *)&child); <<<< Potential crash here ! ... I think these changes would solve the thing. ... -EFI_SERVICE_BINDING *sbp; +EFI_SERVICE_BINDING *sbp =NULL; ... - if (status != EFI_SUCCESS) + if (status != EFI_SUCCESS || sbp != NULL) goto free_binding; ... Please take a look; BTW It's just only me or the adopted Linux kernel coding style makes following C code really a PITA ?? Best, Patrick

On Mon, 24 Jun, at 06:27:00PM, Helmut Hullen wrote: > In file included from /tmp/syslinux-6.00/efi/mem.c:3:0: > /tmp/syslinux-6.00/efi/efi.h:33:5: error: unknown type name 'EFI_SERVICE_BINDING' [...] > Where is the problem: on the syslinux side or on the slackware side? Or > somewhere else? You need a newer version of gnu-efi, gnu-efi 3.0u, which is the release containing the EFI_SERVICE_BINDING definition. -- Matt Fleming, Intel Open Source Technology Center

...ome/voltagex/src/syslinux/efi/mem.c:2: /usr/include/efi/efiapi.h:663:5: warning: function declaration isn't a prototype [-Wstrict-prototypes] ); ^ In file included from /home/voltagex/src/syslinux/efi/mem.c:2:0: /home/voltagex/src/syslinux/efi/efi.h:33:5: error: unknown type name 'EFI_SERVICE_BINDING' EFI_SERVICE_BINDING *binding; ^ /home/voltagex/src/syslinux/efi/mem.c: In function 'efi_malloc': /home/voltagex/src/syslinux/efi/mem.c:4:41: warning: unused parameter 'heap' [-Wunused-parameter] void *efi_malloc(size_t size, enum heap heap, malloc_tag_t tag)...

...5 at 9:50 AM, Gene Cumm <gene.cumm at gmail.com> wrote: > On Jul 27, 2015 12:30 PM, "Patrick Masotta" <masottaus at yahoo.com> wrote: >> >> >>> >> > I think these changes would solve the thing. >> > >> > ... >> > -EFI_SERVICE_BINDING *sbp; >> > +EFI_SERVICE_BINDING *sbp =NULL; >> > ... >> > >> > - if (status != EFI_SUCCESS) >> > + if (status != EFI_SUCCESS || sbp == >> NULL) >> > goto free_binding; >> > ... >> >> The presum...

...SUCCESS) > goto free_binding; > > child = NULL; > > status = uefi_call_wrapper(sbp->CreateChild, 2, sbp, (EFI_HANDLE *)&child); <<<< Potential crash here ! > > ... > > > I think these changes would solve the thing. > > ... > -EFI_SERVICE_BINDING *sbp; > +EFI_SERVICE_BINDING *sbp =NULL; > ... > > - if (status != EFI_SUCCESS) > + if (status != EFI_SUCCESS || sbp == NULL) > goto free_binding; > ... The presumption was that we'd see an error rather than non-error from LibLocateHandle() when nr_handles...

On Jul 27, 2015 12:30 PM, "Patrick Masotta" <masottaus at yahoo.com> wrote: > > >>> > > I think these changes would solve the thing. > > > > ... > > -EFI_SERVICE_BINDING *sbp; > > +EFI_SERVICE_BINDING *sbp =NULL; > > ... > > > > - if (status != EFI_SUCCESS) > > + if (status != EFI_SUCCESS || sbp == > NULL) > > goto free_binding; > > ... > > The presumption was that we'd see an error rat...

...ene.cumm at gmail.com> wrote: >> On Jul 27, 2015 12:30 PM, "Patrick Masotta" <masottaus at yahoo.com> wrote: >>> >>> >>> >>> > I think these changes would solve the thing. >>> > >>> > ... >>> > -EFI_SERVICE_BINDING *sbp; >>> > +EFI_SERVICE_BINDING *sbp =NULL; >>> > ... >>> > >>> > - if (status != EFI_SUCCESS) >>> > + if (status != EFI_SUCCESS || sbp == >>> NULL) >>> > goto free_binding; >>> > ....

Hallo, Matt, Du meintest am 24.06.13: >> In file included from /tmp/syslinux-6.00/efi/mem.c:3:0: >> /tmp/syslinux-6.00/efi/efi.h:33:5: error: unknown type name >> 'EFI_SERVICE_BINDING' > [...] >> Where is the problem: on the syslinux side or on the slackware side? >> Or somewhere else? > You need a newer version of gnu-efi, gnu-efi 3.0u, which is the > release containing the EFI_SERVICE_BINDING definition. Thanks - now it crashes later ... I don...

On Wed, Jul 8, 2015 at 7:34 PM, Gene Cumm <gene.cumm at gmail.com> wrote: > What about the observed symptoms? Have you performed an inline packet Jeff, there's specific code that creates specific responses that if you had mentioned what you saw, I'd expect we could have seen something sooner. -- -Gene

...main.c b/efi/main.c > index 208fee4..6e43f79 100644 > --- a/efi/main.c > +++ b/efi/main.c > @@ -40,36 +40,27 @@ efi_close_protocol(EFI_HANDLE handle, EFI_GUID *guid, EFI_HANDLE agent, > guid, agent, controller); > } > > +/* As of UEFI-2.4.0, all EFI_SERVICE_BINDINGs are for networking */ > struct efi_binding *efi_create_binding(EFI_GUID *bguid, EFI_GUID *pguid) > { > EFI_SERVICE_BINDING *sbp; > struct efi_binding *b; > EFI_STATUS status; > - EFI_HANDLE protocol, child, *handles = NULL; > - UINTN i, nr_handles = 0...

....00/efi/efi.h:22, from /tmp/syslinux-6.00/efi/mem.c:3: /usr/include/efi/efiapi.h:663:5: warning: function declaration isn't a prototype [-Wstrict-prototypes] In file included from /tmp/syslinux-6.00/efi/mem.c:3:0: /tmp/syslinux-6.00/efi/efi.h:33:5: error: unknown type name 'EFI_SERVICE_BINDING' make[3]: *** [mem.o] Error 1 make[3]: Leaving directory `/tmp/syslinux-6.00/efi32/efi' make[2]: *** [efi] Error 2 make[2]: Leaving directory `/tmp/syslinux-6.00/efi32' make[1]: *** [efi32] Error 2 make[1]: Leaving directory `/tmp/syslinux-6.00' make: *** [all] Error 2 ---------...

On Mon, Jun 24, 2013 at 2:20 PM, Matt Fleming <matt at console-pimps.org> wrote: > You need a newer version of gnu-efi, gnu-efi 3.0u, which is the release > containing the EFI_SERVICE_BINDING definition. Is there a way to use a rule in mk/local.mk to block the automatic building of efi32 & efi64 in order to prevent the error for those that do not want efi32/efi64 built and don't have a build box capable of it? -- -Gene

Finally, the Syslinux 6.00 release is out. This release includes support for booting from EFI, both from disk-based media and over the network via PXE. Thanks to everyone who has been testing this out. There are some EFI bugs that I'm aware of, * booting Linux kernels without CONFIG_RELOCATABLE doesn't work * 64-bit syslinux.efi cannot boot 32-bit kernels and vice versa *