search for: ee0a855

...(sparse) disk: specify that explicitly in its -drive qemu command line options, so qemu can skip the autodetection of its format and save a tiny bit of time. --- src/launch-direct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/launch-direct.c b/src/launch-direct.c index ee0a855..8521e5a 100644 --- a/src/launch-direct.c +++ b/src/launch-direct.c @@ -563,7 +563,7 @@ launch_direct (guestfs_h *g, void *datav, const char *arg) /* Add the ext2 appliance drive (after all the drives). */ if (has_appliance_drive) { ADD_CMDLINE ("-drive"); - ADD_CMDLINE_PRIN...

...itly in its -drive qemu command line options, so qemu can skip the > autodetection of its format and save a tiny bit of time. > --- > src/launch-direct.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/launch-direct.c b/src/launch-direct.c > index ee0a855..8521e5a 100644 > --- a/src/launch-direct.c > +++ b/src/launch-direct.c > @@ -563,7 +563,7 @@ launch_direct (guestfs_h *g, void *datav, const char *arg) > /* Add the ext2 appliance drive (after all the drives). */ > if (has_appliance_drive) { > ADD_CMDLINE ("-drive...

...fs_int_getumask (guestfs_h *g); +/* wait.c */ +extern int guestfs_int_waitpid (guestfs_h *g, pid_t pid, int *status, const char *errmsg); +extern void guestfs_int_waitpid_noerror (pid_t pid); + #endif /* GUESTFS_INTERNAL_H_ */ diff --git a/src/launch-direct.c b/src/launch-direct.c index 322737d..ee0a855 100644 --- a/src/launch-direct.c +++ b/src/launch-direct.c @@ -26,7 +26,6 @@ #include <errno.h> #include <fcntl.h> #include <sys/types.h> -#include <sys/wait.h> #include <sys/stat.h> #include <signal.h> #include <sys/socket.h> @@ -851,8 +850,8 @@ laun...

As Eric Blake noted in: https://www.redhat.com/archives/libguestfs/2016-April/msg00154.html libguestfs doesn't correctly handle the case where waitpid receives a SIGCHLD signal and the main program has registered a non-restartable signal handler. In this case waitpid would return -EINTR and we would print an error, but actually we should retry this case. This adds two new internal functions,