Displaying 5 results from an estimated 5 matches for "edit_file_perl".
2016 Apr 12
3
[PATCH v2] customize/perl_edit-c.c: Don't use internal APIs.
In v1 of this patch, there was the (small) possibility that 'g' might
have been garbage collected while we were in the C function.
Avoid this by passing 'g' to the function as well as the C pointer, so
that 'g' is pinned as a garbage collector root [by CAMLparam5] so it
cannot be collected while we're in the function.
Rich.
2016 Apr 11
0
[PATCH] customize/perl_edit-c.c: Don't use internal APIs.
...the guestfs handle, and raising errors); hopefully this should be safe,
- * as long as it's kept internal within the libguestfs sources.
- */
-#include "../ocaml/guestfs-c.h"
-
#pragma GCC diagnostic ignored "-Wmissing-prototypes"
value
@@ -43,12 +37,12 @@ virt_customize_edit_file_perl (value verbosev, value gv, value filev,
{
CAMLparam4 (verbosev, gv, filev, exprv);
int r;
- guestfs_h *g = Guestfs_val (gv);
+ guestfs_h *g = (guestfs_h *) Int64_val (gv);
r = edit_file_perl (g, String_val (filev), String_val (exprv), NULL,
Bool_val (verbosev));...
2016 Apr 12
0
[PATCH v2] customize/perl_edit-c.c: Don't use internal APIs.
...for extracting
- * the guestfs handle, and raising errors); hopefully this should be safe,
- * as long as it's kept internal within the libguestfs sources.
- */
-#include "../ocaml/guestfs-c.h"
-
#pragma GCC diagnostic ignored "-Wmissing-prototypes"
value
-virt_customize_edit_file_perl (value verbosev, value gv, value filev,
- value exprv)
+virt_customize_edit_file_perl (value verbosev, value gv, value gpv,
+ value filev, value exprv)
{
- CAMLparam4 (verbosev, gv, filev, exprv);
+ CAMLparam5 (verbosev, gv, gpv, filev,...
2014 Aug 28
14
[PATCH 00/13] code refactorings for tools
Hi,
this series does a couple of code reorganizations/refactoring in code
used by tools: the windows path handling code, and the two types of
file editing (using editor, and using perl expression).
There's still a code duplication between the two variants of file
editing, but it is just within a single source, and can be easily
solved now (planning as next step).
Pino Toscano (13):
edit:
2016 Apr 14
1
Re: [PATCH v2] customize/perl_edit-c.c: Don't use internal APIs.
...nd raising errors); hopefully this should be safe,
> - * as long as it's kept internal within the libguestfs sources.
> - */
> -#include "../ocaml/guestfs-c.h"
> -
> #pragma GCC diagnostic ignored "-Wmissing-prototypes"
>
> value
> -virt_customize_edit_file_perl (value verbosev, value gv, value filev,
> - value exprv)
> +virt_customize_edit_file_perl (value verbosev, value gv, value gpv,
> + value filev, value exprv)
> {
> - CAMLparam4 (verbosev, gv, filev, exprv);
> + CAMLpar...