search for: early_put_char

Hey Rusty, Christian, Christoph Hellwig asked why we don't need a barrier before this code in virtcons_probe(): > + /* Start using the new console output. */ > + early_put_chars = NULL; > return 0; Since only s390 uses early_put_chars so far, you'd know why it's not needed / why we're safe. Thanks, Amit

Hey Rusty, Christian, Christoph Hellwig asked why we don't need a barrier before this code in virtcons_probe(): > + /* Start using the new console output. */ > + early_put_chars = NULL; > return 0; Since only s390 uses early_put_chars so far, you'd know why it's not needed / why we're safe. Thanks, Amit

Hi all, As far as I can see, early_put_chars is not used by virtio_console because it checks whether there is a port available before using it. If I understand correctly, this makes it useless because once we have a port, we can use the regular virtio transport to output things to the console. Does the attached patch seem valid ? Feedback fr...

Hi all, As far as I can see, early_put_chars is not used by virtio_console because it checks whether there is a port available before using it. If I understand correctly, this makes it useless because once we have a port, we can use the regular virtio transport to output things to the console. Does the attached patch seem valid ? Feedback fr...

From: Francois Diakhate <fdiakh at gmail.com> Currently early_put_chars is not used by virtio_console because it can only be used once a port has been found, at which point it's too late because it is no longer needed. This patch should fix it. Acked-by: Christian Borntraeger <borntraeger at de.ibm.com> Signed-off-by: Amit Shah <amit.shah at redhat.com&g...

From: Francois Diakhate <fdiakh at gmail.com> Currently early_put_chars is not used by virtio_console because it can only be used once a port has been found, at which point it's too late because it is no longer needed. This patch should fix it. Acked-by: Christian Borntraeger <borntraeger at de.ibm.com> Signed-off-by: Amit Shah <amit.shah at redhat.com&g...

...o/kvm_virtio.c b/drivers/s390/virtio/kvm_virtio.c index 1d060fd..b0a849f 100644 --- a/drivers/s390/virtio/kvm_virtio.c +++ b/drivers/s390/virtio/kvm_virtio.c @@ -482,7 +482,7 @@ static int __init kvm_devices_init(void) } /* code for early console output with virtio_console */ -static __init int early_put_chars(u32 vtermno, const char *buf, int count) +static int early_put_chars(u32 vtermno, const char *buf, int count) { char scratch[17]; unsigned int len = count; -- 2.6.6

...tions(-) diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c --- a/arch/x86/lguest/boot.c +++ b/arch/x86/lguest/boot.c @@ -1420,7 +1420,7 @@ __init void lguest_init(void) add_preferred_console("hvc", 0, NULL); /* Register our very early console. */ - virtio_cons_early_init(early_put_chars); +// virtio_cons_early_init(early_put_chars); /* * Last of all, we set the power management poweroff hook to point to diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -226,8 +226,8 @@ add_head:...

...tions(-) diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c --- a/arch/x86/lguest/boot.c +++ b/arch/x86/lguest/boot.c @@ -1420,7 +1420,7 @@ __init void lguest_init(void) add_preferred_console("hvc", 0, NULL); /* Register our very early console. */ - virtio_cons_early_init(early_put_chars); +// virtio_cons_early_init(early_put_chars); /* * Last of all, we set the power management poweroff hook to point to diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -226,8 +226,8 @@ add_head:...

Michael, here are two virtio/s390 patches for 4.8. First, Jing Liu noticed that she could trigger panics while playing around with hvc0 as preferred console but no virtio console: This can be fixed by not discarding our early_put_chars after init (as the minimal fix). This made us wonder why we still have that code around when no current host code supports the old transport: We have no idea whether this still works, and it's probably a good idea to put a deprecation message in there to check whether anyone screams. Patches...

Michael, here are two virtio/s390 patches for 4.8. First, Jing Liu noticed that she could trigger panics while playing around with hvc0 as preferred console but no virtio console: This can be fixed by not discarding our early_put_chars after init (as the minimal fix). This made us wonder why we still have that code around when no current host code supports the old transport: We have no idea whether this still works, and it's probably a good idea to put a deprecation message in there to check whether anyone screams. Patches...

...console.c index 17857beb4892..3cbf4c95e446 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -1136,6 +1136,8 @@ static int put_chars(u32 vtermno, const char *buf, int count) { struct port *port; struct scatterlist sg[1]; + void *data; + int ret; if (unlikely(early_put_chars)) return early_put_chars(vtermno, buf, count); @@ -1144,8 +1146,14 @@ static int put_chars(u32 vtermno, const char *buf, int count) if (!port) return -EPIPE; - sg_init_one(sg, buf, count); - return __send_to_port(port, sg, 1, count, (void *)buf, false); + data = kmemdup(buf, count, GFP_A...

...console.c index 17857beb4892..3cbf4c95e446 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -1136,6 +1136,8 @@ static int put_chars(u32 vtermno, const char *buf, int count) { struct port *port; struct scatterlist sg[1]; + void *data; + int ret; if (unlikely(early_put_chars)) return early_put_chars(vtermno, buf, count); @@ -1144,8 +1146,14 @@ static int put_chars(u32 vtermno, const char *buf, int count) if (!port) return -EPIPE; - sg_init_one(sg, buf, count); - return __send_to_port(port, sg, 1, count, (void *)buf, false); + data = kmemdup(buf, count, GFP_A...

.../char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -784,6 +784,13 @@ int init_port_console(struct port *port) spin_unlock_irq(&pdrvdata_lock); port->guest_connected = true; + /* + * Start using the new console output if this is the first + * console to come up. + */ + if (early_put_chars) + early_put_chars = NULL; + /* Notify host of port being opened */ send_control_msg(port, VIRTIO_CONSOLE_PORT_OPEN, 1); @@ -1056,14 +1063,8 @@ static void handle_control_message(struct ports_device *portdev, switch (cpkt->event) { case VIRTIO_CONSOLE_PORT_ADD: if (port) { - /*...

.../char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -784,6 +784,13 @@ int init_port_console(struct port *port) spin_unlock_irq(&pdrvdata_lock); port->guest_connected = true; + /* + * Start using the new console output if this is the first + * console to come up. + */ + if (early_put_chars) + early_put_chars = NULL; + /* Notify host of port being opened */ send_control_msg(port, VIRTIO_CONSOLE_PORT_OPEN, 1); @@ -1056,14 +1063,8 @@ static void handle_control_message(struct ports_device *portdev, switch (cpkt->event) { case VIRTIO_CONSOLE_PORT_ADD: if (port) { - /*...

...ernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-for-linus.git master Amit Shah (1): MAINTAINERS: Put the virtio-console entry in correct alphabetical order Anton Blanchard (1): hvc_console: Fix race between hvc_close and hvc_remove Fran?ois Diakhat? (1): virtio: console: Fix early_put_chars usage Michael S. Tsirkin (1): virtio: disable multiport console support. Rusty Russell (1): virtio: console makes incorrect assumption about virtio API MAINTAINERS | 13 ++++---- drivers/char/hvc_console.c | 4 -- drivers/char/virtio_console.c | 65 ++...

...ernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-for-linus.git master Amit Shah (1): MAINTAINERS: Put the virtio-console entry in correct alphabetical order Anton Blanchard (1): hvc_console: Fix race between hvc_close and hvc_remove Fran?ois Diakhat? (1): virtio: console: Fix early_put_chars usage Michael S. Tsirkin (1): virtio: disable multiport console support. Rusty Russell (1): virtio: console makes incorrect assumption about virtio API MAINTAINERS | 13 ++++---- drivers/char/hvc_console.c | 4 -- drivers/char/virtio_console.c | 65 ++...

Hey Rusty, In this version: - Assume only one inbuf; no input buffering for ports - Remove the START/END delimiters for outgoing buffers - Remove the header that was sent along with each buffer - Remove unused buffers in the vqs at port remove time - Send a guest port open message to the host when a console port is attached - Remove cached buffers when ports are closed / disconnected - Send

Hey Rusty, In this version: - Assume only one inbuf; no input buffering for ports - Remove the START/END delimiters for outgoing buffers - Remove the header that was sent along with each buffer - Remove unused buffers in the vqs at port remove time - Send a guest port open message to the host when a console port is attached - Remove cached buffers when ports are closed / disconnected - Send

...at 05:07:55PM +0200, Cornelia Huck wrote: > Michael, > > here are two virtio/s390 patches for 4.8. > > First, Jing Liu noticed that she could trigger panics while playing > around with hvc0 as preferred console but no virtio console: This > can be fixed by not discarding our early_put_chars after init (as > the minimal fix). > > This made us wonder why we still have that code around when no current > host code supports the old transport: We have no idea whether this > still works, and it's probably a good idea to put a deprecation > message in there to check wh...