Displaying 3 results from an estimated 3 matches for "e_oggplay_bad_track".
2008 Dec 16
0
liboggplay: RGBA overlay video, rendering with libtiger
...gt;num_tracks'. I
think it should be '>' not '>=' in all cases, what do you think? Code
following usually indexes into decode_data by the track number which
is an error if the track == num_tracks I think.
+ if (track < 0 || track >= me->num_tracks) {
+ return E_OGGPLAY_BAD_TRACK;
Check for NULL return from malloc needed here (the sample problem
occurs in existing code with 'record' but a bug has been raised about
that):
+ orecord = (OggPlayOverlayRecord*)malloc (size);
+ oggplay_data_initialise_header((OggPlayDecode *)decode,
&(orecord->header));
NU...
2008 Dec 16
1
liboggplay: RGBA overlay video, rendering with libtiger
> Should these be wrapped in HAVE_KATE? Same with the definition of the
> functions on oggplay.c? If I'm not building with Kate support it would
> prevent dead code from being around.
They could, but would change the API, and the implementation just
returns a "not implemented" error currently if HAVE_KATE is undefined,
(and a couple checks for validity) so it's not much
2008 Dec 15
3
liboggplay: RGBA overlay video, rendering with libtiger
Hi,
the attached patch adds rendering of Kate streams
using libtiger. To do so, it adds a new type of RGBA video.
One can request the incoming video (in YUV) to be sent
in RGBA (ie, asking liboggplay to do the conversion in the
first place).
The large changes in the GLUT player also include fixes
for crash-on-no-sound, mono sound, and locking fixes
(I *think* - at least it works fine for me