search for: e820_entri

From: Sylvain Gault <sylvain.gault at gmail.com> On some architecture, including my hardware, the function ExitBootServices may need to be called twice in order to successfully exit the boot services. As stated by the UEFI spec, the first call to ExitBootServices may perform a partial shutdown of the services. It seems that during this partial shutdown, the memory map can be modified, thus

...l most likely have changed in the * interim. */ + nr_entries = map_sz / desc_sz; e = e820buf = bp->e820_map; for (i = 0; i < nr_entries && i < E820MAX; i++) { struct e820_entry *prev = NULL; @@ -1089,13 +1155,6 @@ static int exit_boot(struct boot_params *bp) bp->e820_entries = e - e820buf; - status = uefi_call_wrapper(BS->ExitBootServices, 2, image_handle, key); - if (status != EFI_SUCCESS) { - printf("Failed to exit boot services: 0x%016lx\n", status); - FreePool(map); - return -1; - } - return 0; } -- 2.27.0

...hat might want to allocate more RAM. This function looks good from here out. > bp->efi.memmap = (uint32_t)(unsigned long)map; > bp->efi.memmap_size = nr_entries * desc_sz; > @@ -1088,13 +1148,6 @@ static int exit_boot(struct boot_params *bp) > > bp->e820_entries = e - e820buf; > > - status = uefi_call_wrapper(BS->ExitBootServices, 2, image_handle, key); > - if (status != EFI_SUCCESS) { > - printf("Failed to exit boot services: 0x%016lx\n", status); > - FreePool(map); > -...

...ESS) { + printf("Failed to exit boot services: 0x%016lx\n", status); + FreePool(map); return -1; + } + bp->efi.memmap = (uint32_t)(unsigned long)map; bp->efi.memmap_size = nr_entries * desc_sz; @@ -1088,13 +1148,6 @@ static int exit_boot(struct boot_params *bp) bp->e820_entries = e - e820buf; - status = uefi_call_wrapper(BS->ExitBootServices, 2, image_handle, key); - if (status != EFI_SUCCESS) { - printf("Failed to exit boot services: 0x%016lx\n", status); - FreePool(map); - return -1; - } - return 0; } -- 2.5.0

...e it will most likely have changed in the * interim. */ + nr_entries = map_sz / desc_sz; e = e820buf = bp->e820_map; for (i = 0; i < nr_entries && i < E820MAX; i++) { struct e820_entry *prev = NULL; @@ -1089,13 +1155,6 @@ static int exit_boot(struct boot_params *bp) bp->e820_entries = e - e820buf; - status = uefi_call_wrapper(BS->ExitBootServices, 2, image_handle, key); - if (status != EFI_SUCCESS) { - printf("Failed to exit boot services: 0x%016lx\n", status); - FreePool(map); - return -1; - } - return 0; } -- 2.27.0 _____________________________...

...%016lx\n", > status); > + FreePool(map); > return -1; > + } > + > > bp->efi.memmap = (uint32_t)(unsigned long)map; > bp->efi.memmap_size = nr_entries * desc_sz; > @@ -1088,13 +1148,6 @@ static int exit_boot(struct boot_params *bp) > > bp->e820_entries = e - e820buf; > > - status = uefi_call_wrapper(BS->ExitBootServices, 2, > image_handle, key); > - if (status != EFI_SUCCESS) { > - printf("Failed to exit boot services: 0x%016lx\n", > status); > - FreePool(map); > - return -1; > - } > - > retu...

...immediately call ExitBootServices(). >>> bp->efi.memmap = (uint32_t)(unsigned long)map; >>> bp->efi.memmap_size = nr_entries * desc_sz; >>> @@ -1088,13 +1148,6 @@ static int exit_boot(struct boot_params *bp) >>> >>> bp->e820_entries = e - e820buf; >>> >>> - status = uefi_call_wrapper(BS->ExitBootServices, 2, image_handle, >>> key); >>> - if (status != EFI_SUCCESS) { >>> - printf("Failed to exit boot services: 0x%016lx\n", >>> status)...

...te more RAM. This function looks good from here out. > >> bp->efi.memmap = (uint32_t)(unsigned long)map; >> bp->efi.memmap_size = nr_entries * desc_sz; >> @@ -1088,13 +1148,6 @@ static int exit_boot(struct boot_params *bp) >> >> bp->e820_entries = e - e820buf; >> >> - status = uefi_call_wrapper(BS->ExitBootServices, 2, image_handle, >> key); >> - if (status != EFI_SUCCESS) { >> - printf("Failed to exit boot services: 0x%016lx\n", >> status); >> -...

...otServices(). > >>>> bp->efi.memmap = (uint32_t)(unsigned long)map; >>>> bp->efi.memmap_size = nr_entries * desc_sz; >>>> @@ -1088,13 +1148,6 @@ static int exit_boot(struct boot_params *bp) >>>> >>>> bp->e820_entries = e - e820buf; >>>> >>>> - status = uefi_call_wrapper(BS->ExitBootServices, 2, >>>> image_handle, >>>> key); >>>> - if (status != EFI_SUCCESS) { >>>> - printf("Failed to exit boot services: 0...

Hi, It is possible for some BIOSes to return non-page-aligned values for the start and length of regions in the BIOS memory map (through int 15h, e820h). As a result, the initrd is loaded by linux.c32 (a provided com32 module) in a manner such that the last page contains both a portion of initrd and some BIOS data. The linux kernel treats this page as part of the ramdisk file system and ends up

Hi Peter, Please pull the following changes. Paulo, I had to revert your "pxe: resolve names via DNS from protected-mode code" change because dns_resolv() is only implemented for PXELINUX and causes undefined symbol references for ISOLINUX, etc. Feel free to make the change again on top of the revert. The following changes since commit e7bd19def830e8341b1a100956345f1028740b9e:

...char *argv[]) boot->hdr.type_of_loader = 0xFF; } - /* Set up the initial linear pagetables, starting below the initrd. */ - pgdir = setup_pagetables(mem, initrd_size); - /* The Linux boot header contains an "E820" memory map: ours is a * simple, single region. */ boot->e820_entries = 1; @@ -2064,7 +2016,7 @@ int main(int argc, char *argv[]) /* We tell the kernel to initialize the Guest: this returns the open * /dev/lguest file descriptor. */ - lguest_fd = tell_kernel(pgdir, start); + lguest_fd = tell_kernel(start); /* We clone off a thread, which wakes the Launch...

...char *argv[]) boot->hdr.type_of_loader = 0xFF; } - /* Set up the initial linear pagetables, starting below the initrd. */ - pgdir = setup_pagetables(mem, initrd_size); - /* The Linux boot header contains an "E820" memory map: ours is a * simple, single region. */ boot->e820_entries = 1; @@ -2064,7 +2016,7 @@ int main(int argc, char *argv[]) /* We tell the kernel to initialize the Guest: this returns the open * /dev/lguest file descriptor. */ - lguest_fd = tell_kernel(pgdir, start); + lguest_fd = tell_kernel(start); /* We clone off a thread, which wakes the Launch...