search for: e693820

--- common/include/isaligned.h | 11 +++++------ plugins/file/file.c | 4 ++-- plugins/vddk/vddk.c | 8 ++++---- 3 files changed, 11 insertions(+), 12 deletions(-) diff --git a/common/include/isaligned.h b/common/include/isaligned.h index e693820..81ce8a7 100644 --- a/common/include/isaligned.h +++ b/common/include/isaligned.h @@ -36,16 +36,15 @@ #include <assert.h> #include <stdbool.h> +#include <stdint.h> #include "ispowerof2.h" /* Return true if size is a multiple of align. align must be power of 2....

...51 insertions(+) > create mode 100644 common/include/isaligned.h > > diff --git a/common/include/isaligned.h b/common/include/isaligned.h You have to add this file to common/include/Makefile.am otherwise it will never be distributed. Rich. > new file mode 100644 > index 0000000..e693820 > --- /dev/null > +++ b/common/include/isaligned.h > @@ -0,0 +1,51 @@ > +/* nbdkit > + * Copyright (C) 2018 Red Hat Inc. > + * All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided th...

...libguestfs/2018-August/msg00036.html --- common/include/isaligned.h | 51 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 common/include/isaligned.h diff --git a/common/include/isaligned.h b/common/include/isaligned.h new file mode 100644 index 0000000..e693820 --- /dev/null +++ b/common/include/isaligned.h @@ -0,0 +1,51 @@ +/* nbdkit + * Copyright (C) 2018 Red Hat Inc. + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are + * met: + *...

...his should have no effect. However it's probably better to pass the full type explicitly rather than using an implicit truncation. --- common/include/isaligned.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/common/include/isaligned.h b/common/include/isaligned.h index e693820..9ed635e 100644 --- a/common/include/isaligned.h +++ b/common/include/isaligned.h @@ -36,13 +36,14 @@ #include <assert.h> #include <stdbool.h> +#include <stdint.h> #include "ispowerof2.h" /* Return true if size is a multiple of align. align must be power of 2....

--- common/include/isaligned.h | 11 +++++------ plugins/file/file.c | 4 ++-- plugins/vddk/vddk.c | 8 ++++---- 3 files changed, 11 insertions(+), 12 deletions(-) diff --git a/common/include/isaligned.h b/common/include/isaligned.h index e693820..81ce8a7 100644 --- a/common/include/isaligned.h +++ b/common/include/isaligned.h @@ -36,16 +36,15 @@ #include <assert.h> #include <stdbool.h> +#include <stdint.h> #include "ispowerof2.h" /* Return true if size is a multiple of align. align must be power of 2....

...e: > --- > common/include/isaligned.h | 11 +++++------ > plugins/file/file.c | 4 ++-- > plugins/vddk/vddk.c | 8 ++++---- > 3 files changed, 11 insertions(+), 12 deletions(-) > > diff --git a/common/include/isaligned.h b/common/include/isaligned.h > index e693820..81ce8a7 100644 > --- a/common/include/isaligned.h > +++ b/common/include/isaligned.h > @@ -36,16 +36,15 @@ > > #include <assert.h> > #include <stdbool.h> > +#include <stdint.h> > Not need with this change... > > #include "ispowerof2.h&quot...

...tps://docs.microsoft.com/en-us/cpp/c-language/conversions-from-unsigned-integral-types?view=vs-2017 Nir > --- > common/include/isaligned.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/common/include/isaligned.h b/common/include/isaligned.h > index e693820..9ed635e 100644 > --- a/common/include/isaligned.h > +++ b/common/include/isaligned.h > @@ -36,13 +36,14 @@ > > #include <assert.h> > #include <stdbool.h> > +#include <stdint.h> > > #include "ispowerof2.h" > > /* Return true if size i...

This version addresses some of the comments on v2. Changes since v2: - file_zero: Add missing space in function call - is_aligned: Assert that align is indeed a power of 2 - Spelling in commit message Not changed: - Eric commented that spacing was off: https://www.redhat.com/archives/libguestfs/2018-August/msg00113.html but I could not find anything wrong. - Eric asked if ioctl.h will cause

This version addresses comments on v3. Changes since v3: - Finally got spacing right (Eric) - Reorder includes (Richard) - Return 0 or -1 instead of r (Richard) - Add common/include/isaligned.h to Makefile.am (Richard) v3 was here: https://www.redhat.com/archives/libguestfs/2018-August/msg00177.html Nir Soffer (4): file: Avoid unsupported fallocate() calls file: Support zero without

nbdkit partitioning boot.img swap.img root.img ... creates a virtual disk by adding a partition table. In ancient times Xen used to do this. Rich.

The partitioning plugin patch is the same (except for rebasing). However I have changed the first two patches based on feedback received. In particular this fixes a very serious bug found by Eric Blake in the current truncate filter. Rich.