search for: e65448f6

On Tue, Dec 10, 2013 at 4:39 PM, Reid Kleckner <rnk at google.com> wrote: > I think we need to relax the test cases. MSVC usually prints the calling > convention, and it's often useful information. I was going to argue that MSVC doesn't print them, but then I tried, and you're right - it does :) I'll start relaxing the tests then. > Maybe we can make the

...;>> - Hans >> >> -------------- next part -------------- A non-text attachment was scrubbed... Name: relax-tests-for-thiscall-in-types.patch Type: application/octet-stream Size: 24194 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20131211/e65448f6/attachment.obj>

I think we need to relax the test cases. MSVC usually prints the calling convention, and it's often useful information. Maybe we can make the diagnostic text smaller by using the __thiscall, __cdecl, __stdcall, etc keywords when printing types with LangOpts.MicrosoftExt, but it will require moving the attribute from after the identifier to before, which is exciting. On Tue, Dec 10, 2013 at