search for: e3d3c2f1

I'm pushing the first one as blatantly obvious. The second one is also simple enough, but not enough of a bug for me to push tonight. The third is something I noticed while working on sh, but is really more about docs vs. plugins in general. There, we could either change the code to match the docs (breaking backwards behavior for a plugin that set .errno_is_preserved=2) [what my patch did],

...ll can't undo SIG_IGN */ signal (SIGPIPE, SIG_DFL); - /* Set $tmpdir for the script. */ - setenv ("tmpdir", tmpdir, 1); - execvp (argv[0], (char **) argv); perror (argv[0]); _exit (EXIT_FAILURE); diff --git a/plugins/sh/sh.c b/plugins/sh/sh.c index 737c38cf..e3d3c2f1 100644 --- a/plugins/sh/sh.c +++ b/plugins/sh/sh.c @@ -60,6 +60,12 @@ sh_load (void) nbdkit_error ("mkdtemp: /tmp: %m"); exit (EXIT_FAILURE); } + /* Set $tmpdir for the script. */ + if (setenv ("tmpdir", tmpdir, 1) == -1) { + nbdkit_error ("setenv: tmpdir=...

...PIPE, SIG_DFL); > > - /* Set $tmpdir for the script. */ > - setenv ("tmpdir", tmpdir, 1); > - > execvp (argv[0], (char **) argv); > perror (argv[0]); > _exit (EXIT_FAILURE); > diff --git a/plugins/sh/sh.c b/plugins/sh/sh.c > index 737c38cf..e3d3c2f1 100644 > --- a/plugins/sh/sh.c > +++ b/plugins/sh/sh.c > @@ -60,6 +60,12 @@ sh_load (void) > nbdkit_error ("mkdtemp: /tmp: %m"); > exit (EXIT_FAILURE); > } > + /* Set $tmpdir for the script. */ > + if (setenv ("tmpdir", tmpdir, 1) == -1) {...

This is a major rewrite compared to my v1 series, where I've tried a lot harder to ensure that we still accommodate building on Haiku (although I have not actually yet fired up a Haiku VM to try it for myself). I also managed to make the sh plugin fully parallel, on capable platforms. See also my question on patch 10 on whether I've picked the best naming convention. Eric Blake (17):