search for: e0c7918b4

...hat specific case. (Even in >this case the underlying error message still gets logged in debug >output). >--- > lib/canonical-name.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > >diff --git a/lib/canonical-name.c b/lib/canonical-name.c >index 052bbf12c..e0c7918b4 100644 >--- a/lib/canonical-name.c >+++ b/lib/canonical-name.c >@@ -46,9 +46,14 @@ guestfs_impl_canonical_device_name (guestfs_h *g, const char *device) > } > else if (STRPREFIX (device, "/dev/mapper/") || > STRPREFIX (device, "/dev/dm-")) { >...

On Fri, Oct 09, 2020 at 11:33:43AM +0100, Richard W.M. Jones wrote: > > This is the patch I tested which works (on top of the > patch posted): > > diff --git a/lib/canonical-name.c b/lib/canonical-name.c > index e0c7918b4..ae4def692 100644 > --- a/lib/canonical-name.c > +++ b/lib/canonical-name.c > @@ -53,8 +53,16 @@ guestfs_impl_canonical_device_name (guestfs_h *g, const char *device) > * BitLocker-encrypted volume, so simply return the original > * name in that case. > */ > -...

...we can now hide that error in that specific case. (Even in this case the underlying error message still gets logged in debug output). --- lib/canonical-name.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/canonical-name.c b/lib/canonical-name.c index 052bbf12c..e0c7918b4 100644 --- a/lib/canonical-name.c +++ b/lib/canonical-name.c @@ -46,9 +46,14 @@ guestfs_impl_canonical_device_name (guestfs_h *g, const char *device) } else if (STRPREFIX (device, "/dev/mapper/") || STRPREFIX (device, "/dev/dm-")) { - /* XXX hide errors */ +...

This is the patch I tested which works (on top of the patch posted): diff --git a/lib/canonical-name.c b/lib/canonical-name.c index e0c7918b4..ae4def692 100644 --- a/lib/canonical-name.c +++ b/lib/canonical-name.c @@ -53,8 +53,16 @@ guestfs_impl_canonical_device_name (guestfs_h *g, const char *device) * BitLocker-encrypted volume, so simply return the original * name in that case. */ - if (ret == NULL && gues...

...+0100, Richard W.M. Jones wrote: > On Fri, Oct 09, 2020 at 11:33:43AM +0100, Richard W.M. Jones wrote: > > > > This is the patch I tested which works (on top of the > > patch posted): > > > > diff --git a/lib/canonical-name.c b/lib/canonical-name.c > > index e0c7918b4..ae4def692 100644 > > --- a/lib/canonical-name.c > > +++ b/lib/canonical-name.c > > @@ -53,8 +53,16 @@ guestfs_impl_canonical_device_name (guestfs_h *g, const char *device) > > * BitLocker-encrypted volume, so simply return the original > > * name in that c...

As discussed in the emails today, this is the third version addressing most points from the v1/v2 review. You will need to pair this with the changes in libguestfs-common from this series: https://www.redhat.com/archives/libguestfs/2020-September/msg00050.html Rich.