search for: dwarfcompileunit

What program did you use to test the feature, and what was missing information? I'd like to file that as a bug so that we can fix this later. On Thu, Mar 16, 2017 at 2:34 PM, David Blaikie <dblaikie at gmail.com> wrote: > FWIW - selfhosting I did find that GDB wasn't able to find the source code > for some functions when using LLD's gdb_index, so I've switched back to

...ned int, llvm::DIDumpOptions) const /home/linux/llvm-7/llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:530:0 #20 0x00000000004b5db4 llvm::DWARFDie::dump(llvm::raw_ostream&, unsigned int, llvm::DIDumpOptions) const /home/linux/llvm-7/llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:530:0 #21 0x0000000000445cdd llvm::DWARFCompileUnit::dump(llvm::raw_ostream&, llvm::DIDumpOptions) /home/linux/llvm-7/llvm/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp:31:0 #22 0x00000000004482ad llvm::DWARFContext::dump(llvm::raw_ostream&, llvm::DIDumpOptions, std::array<llvm::Optional<unsigned long>, 27ul>)::'lambda0'(bool,...

.../home/linux/llvm-7/llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:530:0 >> #20 0x00000000004b5db4 llvm::DWARFDie::dump(llvm::raw_ostream&, unsigned >> int, llvm::DIDumpOptions) const >> /home/linux/llvm-7/llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:530:0 >> #21 0x0000000000445cdd llvm::DWARFCompileUnit::dump(llvm::raw_ostream&, >> llvm::DIDumpOptions) >> /home/linux/llvm-7/llvm/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp:31:0 >> #22 0x00000000004482ad llvm::DWARFContext::dump(llvm::raw_ostream&, >> llvm::DIDumpOptions, std::array<llvm::Optional<unsigned long>...

...gInfo/DWARF/DWARFDie.cpp:530:0 >>>> #20 0x00000000004b5db4 llvm::DWARFDie::dump(llvm::raw_ostream&, >>>> unsigned int, llvm::DIDumpOptions) const >>>> /home/linux/llvm-7/llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:530:0 >>>> #21 0x0000000000445cdd llvm::DWARFCompileUnit::dump(llvm::raw_ostream&, >>>> llvm::DIDumpOptions) >>>> /home/linux/llvm-7/llvm/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp:31:0 >>>> #22 0x00000000004482ad llvm::DWARFContext::dump(llvm::raw_ostream&, >>>> llvm::DIDumpOptions, std::array<llv...

...ducible in ToT.) The `DIE` class is huge. Directly, it accounts for about 15% of backend memory: Bytes Used Count Symbol Name 77.87 MB 8.4% 318960 llvm::DwarfUnit::createAndAddDIE(unsigned int, llvm::DIE&, llvm::DINode const*) 46.34 MB 5.0% 189810 llvm::DwarfCompileUnit::constructVariableDIEImpl(llvm::DbgVariable const&, bool) 25.57 MB 2.7% 104752 llvm::DwarfCompileUnit::constructInlinedScopeDIE(llvm::LexicalScope*) 8.19 MB 0.8% 33547 llvm::DwarfCompileUnit::constructImportedEntityDIE(llvm::DIImportedEntity const*) A lot of...

..._addr, IntDie); // Crashes here... DG.generate(); auto Obj = object::ObjectFile::createObjectFile(Path); if (Obj) { DWARFContextInMemory DwarfContext(*Obj.get().getBinary()); uint32_t NumCUs = DwarfContext.getNumCompileUnits(); for (uint32_t i=0; i<NumCUs; ++i) { DWARFCompileUnit *U = DwarfContext.getCompileUnitAtIndex(i); if (U) U->getUnitDIE(false)->dump(llvm::outs(), U, -1u); } } But things fall down if I try to uncomment the DW_FORM_ref_addr line above. The problem is that AsmPrinter really expects a full stack of stuff to be there and ex...

...case, but it's not present in MDNodeToDieMap so it returns null. callstack is: llc.exe!llvm::DwarfUnit::getOrCreateTypeDIE(const llvm::MDNode * TyNode) Line 718 C++ llvm::DwarfUnit::addType(llvm::DIE & Entity, const llvm::DIType * Ty, llvm::dwarf::Attribute Attribute) Line 768 C++ llvm::DwarfCompileUnit::applyVariableAttributes(const llvm::DbgVariable & Var, llvm::DIE & VariableDie) Line 897 C++ llvm::DwarfCompileUnit::finishVariableDefinition(const llvm::DbgVariable & Var) Line 725 C++ llvm::DwarfDebug::finishVariableDefinitions() Line 655 C++ llvm::DwarfDebug::finalizeModuleInfo()...

...quot;getCompileUnitOrNull", >>>> the name "check*" seems to imply that it does some checking, which isn't >>>> true. >>>> >>> Will do. >>> >> Done in attached patch. >> >>> >>> >>>> DwarfCompileUnit.cpp: >>>> the "istype || issubprogram" check should probably be pulled out >>>> into a separate function, something like "isShareableAcrossCUs" or >>>> something like that (please, that's not the best name, let's discuss it >&gt...

...tached patch. > > DIE.h: >> checkCompileUnit could probably be called "getCompileUnitOrNull", the >> name "check*" seems to imply that it does some checking, which isn't true. >> > Will do. > Done in attached patch. > > >> DwarfCompileUnit.cpp: >> the "istype || issubprogram" check should probably be pulled out into >> a separate function, something like "isShareableAcrossCUs" or something >> like that (please, that's not the best name, let's discuss it further >> before we sett...

...quot;getCompileUnitOrNull", >>>> the name "check*" seems to imply that it does some checking, which isn't >>>> true. >>>> >>> Will do. >>> >> Done in attached patch. >> >>> >>> >>>> DwarfCompileUnit.cpp: >>>> the "istype || issubprogram" check should probably be pulled out >>>> into a separate function, something like "isShareableAcrossCUs" or >>>> something like that (please, that's not the best name, let's discuss it >&gt...

...ckCompileUnit could probably be called "getCompileUnitOrNull", >>> the name "check*" seems to imply that it does some checking, which isn't >>> true. >>> >> Will do. >> > Done in attached patch. > >> >> >>> DwarfCompileUnit.cpp: >>> the "istype || issubprogram" check should probably be pulled out >>> into a separate function, something like "isShareableAcrossCUs" or >>> something like that (please, that's not the best name, let's discuss it >>> furthe...

...DG.generate(); > > auto Obj = object::ObjectFile::createObjectFile(Path); > if (Obj) { > DWARFContextInMemory DwarfContext(*Obj.get().getBinary()); > uint32_t NumCUs = DwarfContext.getNumCompileUnits(); > for (uint32_t i=0; i<NumCUs; ++i) { > DWARFCompileUnit *U = DwarfContext.getCompileUnitAtIndex(i); > if (U) > U->getUnitDIE(false)->dump(llvm::outs(), U, -1u); > } > } > > > But things fall down if I try to uncomment the DW_FORM_ref_addr line above. The problem is that AsmPrinter really expects a ful...

...quot; seems to imply that it does some checking, which isn't >>>>>> true. >>>>>> >>>>> Will do. >>>>> >>>> Done in attached patch. >>>> >>>>> >>>>> >>>>>> DwarfCompileUnit.cpp: >>>>>> the "istype || issubprogram" check should probably be pulled out >>>>>> into a separate function, something like "isShareableAcrossCUs" or >>>>>> something like that (please, that's not the best name, let&...

...> > > > MDNode *MD = I.getMetadata("dbg"); > > > > DICompileUnit compileUnit(MD); > > > > return compileUnit.getDirectory().str(); > > > > In general for these questions it's easier to look at how it's done in > DwarfDebug.cpp and DwarfCompileUnit.cpp. > > -eric > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121003/947420cf/attachment.html>

...;>>> the name "check*" seems to imply that it does some checking, which isn't >>>>> true. >>>>> >>>> Will do. >>>> >>> Done in attached patch. >>> >>>> >>>> >>>>> DwarfCompileUnit.cpp: >>>>> the "istype || issubprogram" check should probably be pulled out >>>>> into a separate function, something like "isShareableAcrossCUs" or >>>>> something like that (please, that's not the best name, let's discus...

...ckCompileUnit could probably be called "getCompileUnitOrNull", >>> the name "check*" seems to imply that it does some checking, which isn't >>> true. >>> >> Will do. >> > Done in attached patch. > >> >> >>> DwarfCompileUnit.cpp: >>> the "istype || issubprogram" check should probably be pulled out >>> into a separate function, something like "isShareableAcrossCUs" or >>> something like that (please, that's not the best name, let's discuss it >>> furthe...

...to Obj = object::ObjectFile::createObjectFile(Path); >>> if (Obj) { >>> DWARFContextInMemory DwarfContext(*Obj.get().getBinary()); >>> uint32_t NumCUs = DwarfContext.getNumCompileUnits(); >>> for (uint32_t i=0; i<NumCUs; ++i) { >>> DWARFCompileUnit *U = DwarfContext.getCompileUnitAtIndex(i); >>> if (U) >>> U->getUnitDIE(false)->dump(llvm::outs(), U, -1u); >>> } >>> } >>> >>> >>> But things fall down if I try to uncomment the DW_FORM_ref_addr line >&g...

...me >>>>>>> checking, which isn't true. >>>>>>> >>>>>> Will do. >>>>>> >>>>> Done in attached patch. >>>>> >>>>>> >>>>>> >>>>>>> DwarfCompileUnit.cpp: >>>>>>> the "istype || issubprogram" check should probably be pulled out >>>>>>> into a separate function, something like "isShareableAcrossCUs" or >>>>>>> something like that (please, that's not the bes...

...it's not present in MDNodeToDieMap so it returns null. callstack is: llc.exe!llvm::DwarfUnit::getOrCreateTypeDIE(const llvm::MDNode * TyNode) Line 718 C++ llvm::DwarfUnit::addType(llvm::DIE & Entity, const llvm::DIType * Ty, llvm::dwarf::Attribute Attribute) Line 768 C++ llvm::DwarfCompileUnit::applyVariableAttributes(const llvm::DbgVariable & Var, llvm::DIE & VariableDie) Line 897 C++ llvm::DwarfCompileUnit::finishVariableDefinition(const llvm::DbgVariable & Var) Line 725 C++ llvm::DwarfDebug::finishVariableDefinitions() Line 655 C++ llvm::DwarfDebug::finalizeModuleI...

...checking, which isn't true. >>>>>>> >>>>>>> Will do. >>>>>> >>>>>> Done in attached patch. >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> DwarfCompileUnit.cpp: >>>>>>>> the "istype || issubprogram" check should probably be pulled out >>>>>>>> into a separate function, something like "isShareableAcrossCUs" or something >>>>>>>> like that (please, that's...