search for: dverkamp

...s support for > discard and write zeroes in the virtio-blk driver when the device > advertises the corresponding features, VIRTIO_BLK_F_DISCARD and > VIRTIO_BLK_F_WRITE_ZEROES. > > Signed-off-by: Changpeng Liu <changpeng.liu at intel.com> > Signed-off-by: Daniel Verkamp <dverkamp at chromium.org> > --- > dverkamp: I've picked up this patch and made a few minor changes (as > listed below); most notably, I changed the kmalloc back to GFP_ATOMIC, > since it can be called from a context where sleeping is not allowed. > To prevent large allocations, I'v...

What's the status of this patch ? anybody pulled it for the branch ? > -----Original Message----- > From: Stefan Hajnoczi [mailto:stefanha at redhat.com] > Sent: Friday, November 2, 2018 12:18 PM > To: Daniel Verkamp <dverkamp at chromium.org> > Cc: virtualization at lists.linux-foundation.org; linux-block at vger.kernel.org; > Michael S. Tsirkin <mst at redhat.com>; Jason Wang <jasowang at redhat.com>; > Jens Axboe <axboe at kernel.dk>; Paolo Bonzini <pbonzini at redhat.com>; > Chr...

...ould not actually be dereferenced; however, the uninitialized callbacks elements would still be read in vp_find_vqs_msix() and used to calculate the number of MSI-X vectors required. Fixes: 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT") Signed-off-by: Daniel Verkamp <dverkamp at chromium.org> --- drivers/virtio/virtio_balloon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 93f995f6cf36..8e400ece9273 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -47...

...ould not actually be dereferenced; however, the uninitialized callbacks elements would still be read in vp_find_vqs_msix() and used to calculate the number of MSI-X vectors required. Fixes: 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT") Signed-off-by: Daniel Verkamp <dverkamp at chromium.org> --- drivers/virtio/virtio_balloon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 93f995f6cf36..8e400ece9273 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -47...

...s support for > discard and write zeroes in the virtio-blk driver when the device > advertises the corresponding features, VIRTIO_BLK_F_DISCARD and > VIRTIO_BLK_F_WRITE_ZEROES. > > Signed-off-by: Changpeng Liu <changpeng.liu at intel.com> > Signed-off-by: Daniel Verkamp <dverkamp at chromium.org> > --- > dverkamp: I've picked up this patch and made a few minor changes (as > listed below); most notably, I changed the kmalloc back to GFP_ATOMIC, > since it can be called from a context where sleeping is not allowed. > To prevent large allocations, I'v...

Existing virtio-blk protocol doesn't have DISCARD/WRITE ZEROES commands support, this will impact the performance when using SSD backend over file systems. Commit 88c85538 "virtio-blk: add discard and write zeroes features to specification"(see https://github.com/oasis-tcs/virtio-spec) extended existing virtio-blk protocol, adding extra DISCARD and WRITE ZEROES commands support.

Existing virtio-blk protocol doesn't have DISCARD/WRITE ZEROES commands support, this will impact the performance when using SSD backend over file systems. Commit 88c85538 "virtio-blk: add discard and write zeroes features to specification"(see https://github.com/oasis-tcs/virtio-spec) extended existing virtio-blk protocol, adding extra DISCARD and WRITE ZEROES commands support.

...gic that chose nvqs conditionally based on enabled features, which was removed as part of the aforementioned commit. This is slightly more complex than just incrementing a counter of the number of VQs, since the queue for a given feature is assigned a fixed index. Signed-off-by: Daniel Verkamp <dverkamp at chromium.org> --- drivers/virtio/virtio_balloon.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 93f995f6cf36..67c6318d77c7 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/vir...

...gic that chose nvqs conditionally based on enabled features, which was removed as part of the aforementioned commit. This is slightly more complex than just incrementing a counter of the number of VQs, since the queue for a given feature is assigned a fixed index. Signed-off-by: Daniel Verkamp <dverkamp at chromium.org> --- drivers/virtio/virtio_balloon.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 93f995f6cf36..67c6318d77c7 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/vir...

...S commands. This patch enables support for discard and write zeroes in the virtio-blk driver when the device advertises the corresponding features, VIRTIO_BLK_F_DISCARD and VIRTIO_BLK_F_WRITE_ZEROES. Signed-off-by: Changpeng Liu <changpeng.liu at intel.com> Signed-off-by: Daniel Verkamp <dverkamp at chromium.org> --- dverkamp: I've picked up this patch and made a few minor changes (as listed below); most notably, I changed the kmalloc back to GFP_ATOMIC, since it can be called from a context where sleeping is not allowed. To prevent large allocations, I've also clamped the maximu...

...still be read in vp_find_vqs_msix() and used to calculate the number of MSI-X vectors required. Cc: stable at vger.kernel.org Fixes: 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT") Reviewed-by: Cornelia Huck <cohuck at redhat.com> Signed-off-by: Daniel Verkamp <dverkamp at chromium.org> --- v1: https://lists.linuxfoundation.org/pipermail/virtualization/2019-December/044829.html Changes from v1: - Clarified "array" in commit message to "callbacks array" drivers/virtio/virtio_balloon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/...

...still be read in vp_find_vqs_msix() and used to calculate the number of MSI-X vectors required. Cc: stable at vger.kernel.org Fixes: 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT") Reviewed-by: Cornelia Huck <cohuck at redhat.com> Signed-off-by: Daniel Verkamp <dverkamp at chromium.org> --- v1: https://lists.linuxfoundation.org/pipermail/virtualization/2019-December/044829.html Changes from v1: - Clarified "array" in commit message to "callbacks array" drivers/virtio/virtio_balloon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/...

...S commands. This patch enables support for discard and write zeroes in the virtio-blk driver when the device advertises the corresponding features, VIRTIO_BLK_F_DISCARD and VIRTIO_BLK_F_WRITE_ZEROES. Signed-off-by: Changpeng Liu <changpeng.liu at intel.com> Signed-off-by: Daniel Verkamp <dverkamp at chromium.org> --- dverkamp: I've picked up this patch and made a few minor changes (as listed below); most notably, I changed the kmalloc back to GFP_ATOMIC, since it can be called from a context where sleeping is not allowed. To prevent large allocations, I've also clamped the maximu...

On Mon, 16 Dec 2019 15:14:29 -0800 Daniel Verkamp <dverkamp at chromium.org> wrote: > After 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT"), > the virtio-balloon device unconditionally specifies 4 virtqueues as the > argument to find_vqs(), which means that 5 MSI-X vectors are required in > order to assign one vect...

...ULL callback as needing a vector. Add a check to the per_vq_vectors loop so that vectors with no name are not counted to make the two loops consistent. This prevents over-counting unnecessary vectors (e.g. for features which were not negotiated with the device). Signed-off-by: Daniel Verkamp <dverkamp at chromium.org> --- drivers/virtio/virtio_pci_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c index f2862f66c2ac..222d630c41fc 100644 --- a/drivers/virtio/virtio_pci_common.c +++ b/drivers/virt...

...ferenced; however, the uninitialized callbacks elements would still > be read in vp_find_vqs_msix() and used to calculate the number of MSI-X > vectors required. > > Fixes: 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT") > Signed-off-by: Daniel Verkamp <dverkamp at chromium.org> Actually, we already have the issue with the stats VQ, no? So I think this one is more appropriate: Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon driver (V4)") > --- > drivers/virtio/virtio_balloon.c | 2 ++ > 1 file changed...

...over-counting unnecessary vectors (e.g. for features which were not negotiated with the device). Cc: stable at vger.kernel.org Fixes: 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT") Reviewed-by: Cornelia Huck <cohuck at redhat.com> Signed-off-by: Daniel Verkamp <dverkamp at chromium.org> --- v1: https://lists.linuxfoundation.org/pipermail/virtualization/2019-December/044828.html drivers/virtio/virtio_pci_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c index f2...

...escription doesn't seem true after your second patch gets applied. > Cc: stable at vger.kernel.org > Fixes: 86a559787e6f ("virtio-balloon: > VIRTIO_BALLOON_F_FREE_PAGE_HINT") > Reviewed-by: Cornelia Huck <cohuck at redhat.com> > Signed-off-by: Daniel Verkamp <dverkamp at chromium.org> > --- > > v1: > https://lists.linuxfoundation.org/pipermail/virtualization/2019-December/04 > 4829.html > > Changes from v1: > - Clarified "array" in commit message to "callbacks array" > > drivers/virtio/virtio_balloon.c | 2...

...x environment. I point the "boot server" (windows dhcp) to my tftp server and "Bootfile name" to pxelinux. How would I invoke the chain loader over iscsi? I was reading the following page and wondering if I could use gpxelinux to boot this? http://etherboot.org/wiki/soc/2009/dverkamp/notes/windows_xp_iscsi I saw examples of san boot here http://syslinux.zytor.com/wiki/index.php/Sanboot.c32 but im not so sure how to tie the two together. I'm guessing that gpxelinux.0 still uses a file related to the mac address probably under a directory gpxelinux.cfg or default if none ex...

On Fri, Oct 12, 2018 at 02:06:28PM -0700, Daniel Verkamp wrote: > From: Changpeng Liu <changpeng.liu at intel.com> > > In commit 88c85538, "virtio-blk: add discard and write zeroes features > to specification" (https://github.com/oasis-tcs/virtio-spec), the virtio There is some issues in this spec. For one using the multiple ranges also for write zeroes is rather