search for: dual_inner_prod

...ted effect on performance (if any) for each of your patches? Also, are these all the patches you intend to merge for 1.2 or are there more upcoming ones? Cheers, Jean-Marc On 01/06/17 06:33 PM, Linfeng Zhang wrote: > Hi, > > Attached are 5 patches related to celt_inner_prod() > and dual_inner_prod() NEON intrinsics optimization. > > In 0004-Optimize-floating-point-celt_inner_prod-and-dual_inn.patch, the > optimization changed the order of floating-point inner products, which > will change the results. I > created celt_inner_prod_neon_float_c_simulation() > and dual_inner_p...

...you intend to merge for 1.2 or are there more > upcoming ones? > > Cheers, > > Jean-Marc > > On 01/06/17 06:33 PM, Linfeng Zhang wrote: > > Hi, > > > > Attached are 5 patches related to celt_inner_prod() > > and dual_inner_prod() NEON intrinsics optimization. > > > > In > 0004-Optimize-floating-point-celt_inner_prod-and-dual_inn.patch, the > > optimization changed the order of floating-point inner products, which > > will change the results. I > > created celt_inner...

...d to merge for 1.2 or are there more upcoming >> ones? >> >> Cheers, >> >> Jean-Marc >> >> On 01/06/17 06:33 PM, Linfeng Zhang wrote: >> > Hi, >> > >> > Attached are 5 patches related to celt_inner_prod() >> > and dual_inner_prod() NEON intrinsics optimization. >> > >> > In 0004-Optimize-floating-point-celt_inner_prod-and-dual_inn.patch, the >> > optimization changed the order of floating-point inner products, which >> > will change the results. I >> > created celt_inner_prod_neo...

...ame reason we didn’t want it in the arm_silk_map tables. Out of curiosity, what’s the CPU in the Chromebook you’re using to test? > On Jun 1, 2017, at 6:33 PM, Linfeng Zhang <linfengz at google.com> wrote: > > Hi, > > Attached are 5 patches related to celt_inner_prod() and dual_inner_prod() NEON intrinsics optimization. > > In 0004-Optimize-floating-point-celt_inner_prod-and-dual_inn.patch, the optimization changed the order of floating-point inner products, which will change the results. I created celt_inner_prod_neon_float_c_simulation() and dual_inner_prod_neon_float_c_sim...

...U in the Chromebook you’re using to > > test? > > > >> On Jun 1, 2017, at 6:33 PM, Linfeng Zhang <linfengz at google.com> > >> wrote: > >> > >> Hi, > >> > >> Attached are 5 patches related to celt_inner_prod() and > >> dual_inner_prod() NEON intrinsics optimization. > >> > >> In 0004-Optimize-floating-point-celt_inner_prod-and-dual_inn.patch, > >> the optimization changed the order of floating-point inner > >> products, which will change the results. I created > >> celt_inner_prod_neo...

Hi, Attached are 5 patches related to celt_inner_prod() and dual_inner_prod() NEON intrinsics optimization. In 0004-Optimize-floating-point-celt_inner_prod-and-dual_inn.patch, the optimization changed the order of floating-point inner products, which will change the results. I created celt_inner_prod_neon_float_c_simulation() and dual_inner_prod_neon_float_c_simulation()...

...> > > Cheers, > > > > Jean-Marc > > > > On 01/06/17 06:33 PM, Linfeng Zhang wrote: > > > Hi, > > > > > > Attached are 5 patches related to celt_inner_prod() > > > and dual_inner_prod() NEON intrinsics optimization. > > > > > > In > > 0004-Optimize-floating-point-celt_inner_prod-and-dual_inn.pa > > <http://elt_inner_prod-and-dual_inn.pa>tch, the > > > optimization changed the order of floating-p...

Yes, Thank you. I'll follow up with the AVX code and tests for pitch code. Radu -----Original Message----- From: opus-bounces at xiph.org [mailto:opus-bounces at xiph.org] On Behalf Of Timothy B. Terriberry Sent: Thursday, November 5, 2015 10:31 AM To: opus at xiph.org Subject: Re: [opus] AVX Optimizations Velea, Radu wrote: > I've created a pull request[1] to enable configuration

...so, are these > all the patches you intend to merge for 1.2 or are there more upcoming > ones? > > Cheers, > > Jean-Marc > > On 01/06/17 06:33 PM, Linfeng Zhang wrote: > > Hi, > > > > Attached are 5 patches related to celt_inner_prod() > > and dual_inner_prod() NEON intrinsics optimization. > > > > In 0004-Optimize-floating-point-celt_inner_prod-and-dual_inn.patch, the > > optimization changed the order of floating-point inner products, which > > will change the results. I > > created celt_inner_prod_neon_float_c_simulation...

...> > Out of curiosity, what’s the CPU in the Chromebook you’re using to > test? > >> On Jun 1, 2017, at 6:33 PM, Linfeng Zhang <linfengz at google.com> >> wrote: >> >> Hi, >> >> Attached are 5 patches related to celt_inner_prod() and >> dual_inner_prod() NEON intrinsics optimization. >> >> In 0004-Optimize-floating-point-celt_inner_prod-and-dual_inn.patch, >> the optimization changed the order of floating-point inner >> products, which will change the results. I created >> celt_inner_prod_neon_float_c_simulation() a...

...nst opus_val16 *x, const opus_val16 *y, int N ) = { celt_inner_prod_c, /* non-sse */ MAY_HAVE_SSE(celt_inner_prod), MAY_HAVE_SSE(celt_inner_prod), MAY_HAVE_SSE(celt_inner_prod), + MAY_HAVE_SSE(celt_inner_prod) }; void (*const DUAL_INNER_PROD_IMPL[OPUS_ARCHMASK + 1])( const opus_val16 *x, const opus_val16 *y01, const opus_val16 *y02, int N, opus_val32 *xy1, opus_val32 *xy2 ) = {...

...Jean-Marc > >> > > >> > On 01/06/17 06:33 PM, Linfeng Zhang wrote: > >> > > Hi, > >> > > > >> > > Attached are 5 patches related to celt_inner_prod() > >> > > and dual_inner_prod() NEON intrinsics optimization. > >> > > > >> > > In > >> > 0004-Optimize-floating-point-celt_inner_prod-and-dual_inn.pa > >> > <http://elt_inner_prod-and-dual_inn.pa>tch, the > >> > >...

...re there more > upcoming ones? > > Cheers, > > Jean-Marc > > On 01/06/17 06:33 PM, Linfeng Zhang wrote: > > Hi, > > > > Attached are 5 patches related to celt_inner_prod() > > and dual_inner_prod() NEON intrinsics optimization. > > > > In > 0004-Optimize-floating-point-celt_inner_prod-and-dual_inn.pa > <http://elt_inner_prod-and-dual_inn.pa>tch, the > > optimization changed the order of floating-point inner > p...

...nst opus_val16 *x, const opus_val16 *y, int N ) = { celt_inner_prod_c, /* non-sse */ MAY_HAVE_SSE(celt_inner_prod), MAY_HAVE_SSE(celt_inner_prod), MAY_HAVE_SSE(celt_inner_prod), + MAY_HAVE_SSE(celt_inner_prod) }; void (*const DUAL_INNER_PROD_IMPL[OPUS_ARCHMASK + 1])( const opus_val16 *x, const opus_val16 *y01, const opus_val16 *y02, int N, opus_val32 *xy1, opus_val32 *xy2 ) = {...

...gt;> > >> > Jean-Marc >> > >> > On 01/06/17 06:33 PM, Linfeng Zhang wrote: >> > > Hi, >> > > >> > > Attached are 5 patches related to celt_inner_prod() >> > > and dual_inner_prod() NEON intrinsics optimization. >> > > >> > > In >> > 0004-Optimize-floating-point-celt_inner_prod-and-dual_inn.pa >> > <http://elt_inner_prod-and-dual_inn.pa>tch, the >> > > optimization changed the...

...US_RESTRICT Y, opus_val16 mid, int N, int arch) { int j; opus_val32 xp=0, side=0; @@ -410,7 +410,7 @@ static void stereo_merge(celt_norm * OPUS_RESTRICT X, celt_norm * OPUS_RESTRICT opus_val32 t, lgain, rgain; /* Compute the norm of X+Y and X-Y as |X|^2 + |Y|^2 +/- sum(xy) */ - dual_inner_prod(Y, X, Y, N, &xp, &side); + dual_inner_prod(Y, X, Y, N, &xp, &side, arch); /* Compensating for the mid normalization */ xp = MULT16_32_Q15(mid, xp); /* mid and side are in Q15, not Q14 like X and Y */ @@ -1348,7 +1348,7 @@ static unsigned quant_band_stereo(struct band_c...

...US_RESTRICT Y, opus_val16 mid, int N, int arch) { int j; opus_val32 xp=0, side=0; @@ -410,7 +410,7 @@ static void stereo_merge(celt_norm * OPUS_RESTRICT X, celt_norm * OPUS_RESTRICT opus_val32 t, lgain, rgain; /* Compute the norm of X+Y and X-Y as |X|^2 + |Y|^2 +/- sum(xy) */ - dual_inner_prod(Y, X, Y, N, &xp, &side); + dual_inner_prod(Y, X, Y, N, &xp, &side, arch); /* Compensating for the mid normalization */ xp = MULT16_32_Q15(mid, xp); /* mid and side are in Q15, not Q14 like X and Y */ @@ -1348,7 +1348,7 @@ static unsigned quant_band_stereo(struct band_c...

The attached patch cleans up Opus's x86 intrinsics configury. It: * Makes ?enable-intrinsics work with clang and other non-GCC compilers * Enables RTCD for the floating-point-mode SSE code in Celt. * Disables use of RTCD in cases where the compiler targets an instruction set by default. * Enables the SSE4.1 Silk optimizations that apply to the common parts of Silk when Opus is built in

Should call celt_inner_prod(). --- celt/bands.c | 7 ++++--- celt/bands.h | 2 +- celt/celt_encoder.c | 6 +++--- celt/pitch.c | 2 +- src/opus_multistream_encoder.c | 2 +- 5 files changed, 10 insertions(+), 9 deletions(-) diff --git a/celt/bands.c b/celt/bands.c index bbe8a4c..1ab24aa 100644 --- a/celt/bands.c +++ b/celt/bands.c

Hi All, Since I continue to base my work on top of Jonathan's patch, and my previous Ne10 fft/ifft/mdct_forward/backward patches, I thought it would be better to just post all new patches as a patch series. Please let me know if anyone disagrees with this approach. You can see wip branch of all latest patches at https://git.linaro.org/people/viswanath.puttagunta/opus.git Branch: