search for: drmmode_set_scanout_pixmap

drmmode_set_scanout_pixmap(pix) adds drmmod->fb_id through a call to drmmode_xf86crtc_resize(), but on a subsequent drmmode_set_scanout_pixmap(NULL) it would not remove the fb. This keeps the crtc marked as busy, which causes the dgpu to not being able to runtime suspend, after an output attached to the dgpu has been use...

...orrect. Saw the new warnings though. src/drmmode_display.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/drmmode_display.c b/src/drmmode_display.c index 2480122..f677e24 100644 --- a/src/drmmode_display.c +++ b/src/drmmode_display.c @@ -697,7 +697,13 @@ drmmode_set_scanout_pixmap(xf86CrtcPtr crtc, PixmapPtr ppix) int c, total_width = 0, max_height = 0, this_x = 0; if (!ppix) { if (crtc->randr_crtc->scanout_pixmap) { - PixmapStopDirtyTracking(crtc->randr_crtc->scanout_pixmap, screenpix); + PixmapStopDirtyTracking( +#ifdef HAS_DIRTYTRACKING_DRAWABLE_SRC...

Hi Ilia, Ben, et al. Can I please get a review of this patch, and assuming the review is favorable, can someone please push this ? Regards, Hans p.s. Is it ok if I request push rights to the nouveau repos / group at freedesktop.org ? On 03-06-16 14:46, Hans De Goede wrote: > drmmode_set_scanout_pixmap(pix) adds drmmod->fb_id through a call > to drmmode_xf86crtc_resize(), but on a subsequent > drmmode_set_scanout_pixmap(NULL) it would not remove the fb. > > This keeps the crtc marked as busy, which causes the dgpu to not > being able to runtime suspend, after an output attached...

...Enable HW cursor support with PRIME slave output & Xorg > 1.18.99.901 Order unique chipsets according to first appearance in ati_pciids.csv Remove PCI IDs and bus type from ati_pciids.csv Sayōnara, AM_MAINTAINER_MODE! Don't rely on randr_crtc->scanout_pixmap in drmmode_set_scanout_pixmap Always call PixmapStopDirtyTracking in drmmode_set_scanout_pixmap Consume all available udev events at once Require xserver 1.10 or newer Check Xorg version at runtime instead of build time in two places Reindent code in radeon_dri2_create_buffer2 Refactor radeon...

...t cursor hotspot position for drmModeSetCursor2 Enable HW cursor support with PRIME slave output & Xorg > 1.18.99.901 Order unique chipsets according to first appearance in ati_pciids.csv Sayōnara, AM_MAINTAINER_MODE! Don't rely on randr_crtc->scanout_pixmap in drmmode_set_scanout_pixmap Always call PixmapStopDirtyTracking in drmmode_set_scanout_pixmap Consume all available udev events at once present: Check tiling info for flips Require xserver 1.10 or newer Check Xorg version at runtime instead of build time in two places Refactor amdgpu_mode_h...

...-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/drmmode_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/drmmode_display.c b/src/drmmode_display.c index 1dc48c5..b950f42 100644 --- a/src/drmmode_display.c +++ b/src/drmmode_display.c @@ -704,7 +704,7 @@ drmmode_set_scanout_pixmap(xf86CrtcPtr crtc, PixmapPtr ppix) if (max_height < iter->mode.VDisplay) max_height = iter->mode.VDisplay; } -#ifndef HAS_DIRTYTRACKING2 +#if !defined(HAS_DIRTYTRACKING_ROTATION) && !defined(HAS_DIRTYTRACKING2) if (iter != crtc) { ErrorF("Cannot do multiple crt...

...rrSetScanoutPixmap(). Instead of using multiple calls to rrSetScanoutPixmap() to >> setup scanout pixmaps for flipping, the scanout pixmap setting is done >> implicitly in rrEnableSharedPixmapFlipping(). >> >> There are two new patches that fix outstanding bugs with >> drmmode_set_scanout_pixmap(), with details in their respective commit messages: >> modesetting: Internal storage of scanout pixmaps >> modesetting: Always tear down scanout pixmap >> >> Getting RRReplaceScanoutPixmap() working with synchronization would require an >> ABI change to pass i...

...>randr_crtc->scanout_pixmap && + if (amdgpu_dirty_src_equals(dirty, crtc->randr_crtc->scanout_pixmap) && dirty->slave_dst == drmmode_crtc->scanout[drmmode_crtc->scanout_id].pixmap) { dirty->slave_dst = @@ -1216,7 +1216,11 @@ static Bool drmmode_set_scanout_pixmap(xf86CrtcPtr crtc, PixmapPtr ppix) return FALSE; } -#ifdef HAS_DIRTYTRACKING_ROTATION +#ifdef HAS_DIRTYTRACKING_DRAWABLE_SRC + PixmapStartDirtyTracking(&ppix->drawable, + drmmode_crtc->scanout[scanout_id].pixmap, + 0, 0, 0, 0, RR_Rotate_0); +#elif defined(HAS_DIRTYTRACKING_R...

https://bugs.freedesktop.org/show_bug.cgi?id=60369 Priority: medium Bug ID: 60369 CC: airlied at freedesktop.org Assignee: nouveau at lists.freedesktop.org Summary: src/nouveau_exa.c:142:31: error: 'CREATE_PIXMAP_USAGE_SHARED' undeclared (first use in this function) QA Contact:

From: Michel Dänzer <michel.daenzer at amd.com> This allows making the master screen's pixmap_dirty_list entries explicitly reflect that we're now tracking the root window instead of the screen pixmap, in order to allow Present page flipping on master outputs while there are active slave outputs. Define HAS_DIRTYTRACKING_DRAWABLE_SRC for drivers to check, but leave