search for: drmmode_crtc

...eflips and vblank waits on disabled CRTCs. I'm not sure how pageflipping disabled CRTCs ever worked in the first place, but since not doing so is the proper behavior anyway I haven't investigated any further. So, copy the ms_crtc_on() function from the modesetting driver and add it here as drmmode_crtc_on(), then use that in all of the places where we should be checking for both DPMS off and disabled CRTCs. This fixes issues with the X ceasing to function (usually) after the first time a CRTC has it's DPMS turned on. Reproduction recipe: - Load up gnome-shell on a machine - Wait for the dis...

...dex b950f42..f326e46 100644 --- a/src/drmmode_display.c +++ b/src/drmmode_display.c @@ -680,10 +680,16 @@ drmmode_set_scanout_pixmap(xf86CrtcPtr crtc, PixmapPtr ppix) PixmapPtr screenpix = screen->GetScreenPixmap(screen); xf86CrtcConfigPtr xf86_config = XF86_CRTC_CONFIG_PTR(crtc->scrn); drmmode_crtc_private_ptr drmmode_crtc = crtc->driver_private; + drmmode_ptr drmmode = drmmode_crtc->drmmode; int c, total_width = 0, max_height = 0, this_x = 0; if (!ppix) { - if (crtc->randr_crtc->scanout_pixmap) + if (crtc->randr_crtc->scanout_pixmap) { PixmapStopDirtyTracking(crtc...

...te(xf86CrtcPtr crtc, unsigned scanout_id) Bool ret = FALSE; xorg_list_for_each_entry(dirty, &screen->pixmap_dirty_list, ent) { - if (dirty->src == scanoutpix && dirty->slave_dst == + if (amdgpu_dirty_src_equals(dirty, scanoutpix) && dirty->slave_dst == drmmode_crtc->scanout[scanout_id ^ drmmode_crtc->tear_free].pixmap) { RegionPtr region; @@ -738,10 +738,10 @@ amdgpu_dirty_update(ScrnInfoPtr scrn) PixmapDirtyUpdatePtr region_ent = ent; if (master_has_sync_shared_pixmap(scrn, ent)) { - ScreenPtr master_screen = ent->src->master_p...

...- times do not change, so it's safe to apply it. --- src/drmmode_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/drmmode_display.c b/src/drmmode_display.c index 4d2d09d..ee0805d 100644 --- a/src/drmmode_display.c +++ b/src/drmmode_display.c @@ -567,7 +567,7 @@ drmmode_crtc_init(ScrnInfoPtr pScrn, drmmode_ptr drmmode, int num) drmmode->mode_res->crtcs[num]); drmmode_crtc->drmmode = drmmode; - ret = nouveau_bo_new(pNv->dev, NOUVEAU_BO_VRAM | NOUVEAU_BO_MAP, 0, + ret = nouveau_bo_new(pNv->dev, NOUVEAU_BO_GART | NOUVEAU_BO_MAP, 0, 64*6...

...letions(-) diff --git a/src/drmmode_display.c b/src/drmmode_display.c index f2fe0e8..7acddf1 100644 --- a/src/drmmode_display.c +++ b/src/drmmode_display.c @@ -333,7 +333,14 @@ done: static void drmmode_set_cursor_colors (xf86CrtcPtr crtc, int bg, int fg) { + NVPtr pNv = NVPTR(crtc->scrn); + drmmode_crtc_private_ptr drmmode_crtc = crtc->driver_private; + struct nouveau_bo *bo = drmmode_crtc->cursor; + nouveau_bo_map(bo, NOUVEAU_BO_WR); + nv_cursor_convert_cursor(pNv->curImage, bo->map, nv_cursor_width(pNv), + 64, 32, fg | (0xff << 24), bg | (0xff << 24)); + nouveau_bo_...

...t; --- a/src/drmmode_display.c > +++ b/src/drmmode_display.c > @@ -680,10 +680,16 @@ drmmode_set_scanout_pixmap(xf86CrtcPtr crtc, PixmapPtr ppix) > PixmapPtr screenpix = screen->GetScreenPixmap(screen); > xf86CrtcConfigPtr xf86_config = XF86_CRTC_CONFIG_PTR(crtc->scrn); > drmmode_crtc_private_ptr drmmode_crtc = crtc->driver_private; > + drmmode_ptr drmmode = drmmode_crtc->drmmode; > int c, total_width = 0, max_height = 0, this_x = 0; > if (!ppix) { > - if (crtc->randr_crtc->scanout_pixmap) > + if (crtc->randr_crtc->scanout_pixmap) { >...

...if (drmmode->fb_id) { drmModeRmFB(drmmode->fd, drmmode->fb_id); drmmode->fb_id = 0; @@ -897,7 +897,8 @@ drmmode_set_target_scanout_pixmap_gpu(xf86CrtcPtr crtc, PixmapPtr ppix, screen->height = screenpix->drawable.height = max_height; } drmmode_crtc->prime_pixmap_x = this_x; - PixmapStartDirtyTracking(ppix, screenpix, 0, 0, this_x, 0, RR_Rotate_0); + PixmapStartDirtyTracking(&ppix->drawable, screenpix, 0, 0, this_x, 0, + RR_Rotate_0); *target = ppix; return TRUE; } diff --git a/hw/xfree86/...

...from drmmode_display.h Don't enable DRI3 without glamor Simplify tracking of PRIME scanout pixmap Update URLs Use reference counting for tracking KMS framebuffer lifetimes Improve AMDGPUPreInitAccel_KMS log messages Increase reference count of FB assigned to drmmode_crtc->flip_pending Improve drmmode_fb_reference debugging code Only call drmmode_scanout_free for non-GPU screens in LeaveVT Use drmmode_crtc->scanout_id instead of 0 to check for scanout buffer If a TearFree flip fails, fall back to non-TearFree operation Add AC_CONF...

...ify tracking of PRIME scanout pixmap Remove unused struct members from drmmode_display.h Update URLs Include xf86Pci.h for DRICreatePCIBusID with xserver Git master Only call drmmode_scanout_free for non-GPU screens in LeaveVT Increase reference count of FB assigned to drmmode_crtc->flip_pending Improve drmmode_fb_reference debugging code Use pRADEONEnt->fd exclusively for the DRM file descriptor Use drmmode_crtc->scanout_id instead of 0 to check for scanout buffer If a TearFree flip fails, fall back to non-TearFree operation Only handle...

...able, +#else + crtc->randr_crtc->scanout_pixmap, +#endif + screenpix); if (drmmode && drmmode->fb_id) { drmModeRmFB(drmmode->fd, drmmode->fb_id); drmmode->fb_id = 0; @@ -744,7 +750,13 @@ drmmode_set_scanout_pixmap(xf86CrtcPtr crtc, PixmapPtr ppix) } drmmode_crtc->scanout_pixmap_x = this_x; #ifdef HAS_DIRTYTRACKING_ROTATION - PixmapStartDirtyTracking(ppix, screenpix, 0, 0, this_x, 0, RR_Rotate_0); + PixmapStartDirtyTracking( +#ifdef HAS_DIRTYTRACKING_DRAWABLE_SRC + &ppix->drawable, +#else + ppix, +#endif + screenpix, 0, 0, this_x, 0, RR_Rotate...

...ConnectorPtr mode_output; drmModeEncoderPtr mode_encoder; drmModePropertyBlobPtr edid_blob; + drmModePropertyBlobPtr tile_blob; int num_props; drmmode_prop_ptr props; } drmmode_output_private_rec, *drmmode_output_private_ptr; @@ -770,7 +770,7 @@ static const xf86CrtcFuncsRec drmmode_crtc_funcs = { static unsigned int -drmmode_crtc_init(ScrnInfoPtr pScrn, drmmode_ptr drmmode, int num) +drmmode_crtc_init(ScrnInfoPtr pScrn, drmmode_ptr drmmode, drmModeResPtr mode_res, int num) { NVPtr pNv = NVPTR(pScrn); NVEntPtr pNVEnt = NVEntPriv(pScrn); @@ -784,7 +784,7 @@ drmmode_crtc_in...

...crtc, DisplayModePtr mode, continue; drmmode_output = output->driver_private; + if (drmmode_output->output_id == -1) + continue; output_ids[output_count] = drmmode_output->mode_output->connector_id; output_count++; @@ -770,7 +772,7 @@ static const xf86CrtcFuncsRec drmmode_crtc_funcs = { static unsigned int -drmmode_crtc_init(ScrnInfoPtr pScrn, drmmode_ptr drmmode, int num) +drmmode_crtc_init(ScrnInfoPtr pScrn, drmmode_ptr drmmode, drmModeResPtr mode_res, int num) { NVPtr pNv = NVPTR(pScrn); NVEntPtr pNVEnt = NVEntPriv(pScrn); @@ -784,7 +786,7 @@ drmmode_crtc_in...

[PATCH 1/3] kms: Don't hardcode the output properties [PATCH 2/3] kms: Implement output->get_property when RandR1.3 is available. [PATCH 3/3] kms: Add TV-out support src/drmmode_display.c | 403 ++++++++++++++++++++++++++++++++----------------- 1 files changed, 261 insertions(+), 142 deletions(-)

...se any PRIME offloading capabilities without acceleration Load fb module before glamoregl/shadow modules HAS_DIRTYTRACKING_ROTATION also supports multiple CRTCs Bump version for 1.0.1 release Mykola Lysenko (2): Check for NULL koutput in drmmode_output_dpms Initialize drmmode_crtc dpms_mode to DPMSModeOff git tag: xf86-video-amdgpu-1.0.1 http://xorg.freedesktop.org/archive/individual/driver/xf86-video-amdgpu-1.0.1.tar.bz2 MD5: f989e7a564afca970631a7b37ab78004 xf86-video-amdgpu-1.0.1.tar.bz2 SHA1: 74a6b3cbde0e7dc48f4a54dcdda479af18c0ebca xf86-video-amdgpu-1.0.1.tar.bz2 S...

...ibuted to this release in any way! Alan Coopersmith (1): Update README for gitlab migration Mario Kleiner (1): Fix crash when page flipping in multi-X-Screen/Zaphod mode Michel Dänzer (30): dri3: Handle radeon_get_pixmap_bo returning NULL Handle pending scanout update in drmmode_crtc_scanout_free Make wait_pending_flip / handle_deferred symmetric in set_mode_major Allow up to six instances in Zaphod mode Post-release version bump Detect and fix up non-premultiplied cursor data Skip gamma correction of cursor data if premultiplied R/G/B > alpha...

...ile descriptor for ssh clients (v2) Update pixmap pitch in radeon_set_pixmap_bo Identify DRM event queue entries by sequence number instead of by pointer Update manpage entry for Option "TearFree" Bump version for 7.7.0 release Mykola Lysenko (1): Initialize drmmode_crtc dpms_mode to DPMSModeOff Ryan Kennedy (1): Use correct tiling in drmmode_create_bo_pixmap jimqu (2): Move radeon_glamor_destroy_pixmap before radeon_glamor_create_pixmap glamor: Return NullPixmap on failure to create shareable pixmap git tag: xf86-video-ati-7.7.0 http://xorg.f...

.... Plus other improvements and fixes. Thanks to everybody who contributed to this release in any way! Emil Velikov (1): Do not export the DriverRec RADEON Jammy Zhou (1): Remove throttling from radeon_dri2_copy_region2 Jim Qu (1): Wait for pending scanout update before calling drmmode_crtc_scanout_free Keith Packard (3): modesetting: Record non-desktop kernel property at PreInit time modesetting: Create CONNECTOR_ID properties for outputs [v2] Add RandR leases support Michel Dänzer (55): Bail from dri2_create_buffer2 if we can't get a pixmap glamor...

https://bugs.freedesktop.org/show_bug.cgi?id=60369 Priority: medium Bug ID: 60369 CC: airlied at freedesktop.org Assignee: nouveau at lists.freedesktop.org Summary: src/nouveau_exa.c:142:31: error: 'CREATE_PIXMAP_USAGE_SHARED' undeclared (first use in this function) QA Contact:

...tries by sequence number instead of by pointer Update manpage entry for Option "TearFree" glamor: Force GPU rendering to/from pixmaps created via DRI3 Bump version for 1.1.0 release Mykola Lysenko (2): Check for NULL koutput in drmmode_output_dpms Initialize drmmode_crtc dpms_mode to DPMSModeOff Tom St Denis (1): Move memset() after variable declarations jimqu (2): Move amdgpu_glamor_destroy_pixmap before amdgpu_glamor_create_pixmap glamor: Return NullPixmap on failure to create shareable pixmap git tag: xf86-video-amdgpu-1.1.0 http://xorg.fre...

...o contributed to this release in any way! Emil Velikov (3): Move amdgpu_bus_id/amgpu_kernel_mode within amdgpu_kernel_open_fd Do not export the DriverRec AMDGPU Remove set but unused amdgpu_dri2::pKernelDRMVersion Jim Qu (1): Wait for pending scanout update before calling drmmode_crtc_scanout_free Keith Packard (3): modesetting: Record non-desktop kernel property at PreInit time modesetting: Create CONNECTOR_ID properties for outputs [v2] Add RandR leases support Leo Li (Sunpeng) (7): Cache color property IDs and LUT sizes during pre-init Initiali...