search for: drm_vblank_disable_and_sav

...s are already disabled... Seems so, the below shut up suspend for both 8600 GT and GTX 980. --- drivers/gpu/drm/drm_vblank.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) --- a/drivers/gpu/drm/drm_vblank.c +++ b/drivers/gpu/drm/drm_vblank.c @@ -323,6 +323,14 @@ void drm_vblank_disable_and_save(struct spin_lock_irqsave(&dev->vblank_time_lock, irqflags); /* + * Always update the count and timestamp to maintain the + * appearance that the counter has been ticking all along until + * this time. This makes the count account for the entire time + * between drm_crtc_vblank_on(...

...lution is to not call drm_crtc_vblank_off for atomic modesetting in nouveau_display_fini. I think Ben's working on it. On Wed, Jul 19, 2017 at 1:25 PM, Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de> wrote: > mimic the behavior of vblank_disable_fn(), another caller of > drm_vblank_disable_and_save(). > > This avoids oopsing, while trying to disable vblank on a not connected display: > > [ 12.768079] WARNING: CPU: 0 PID: 274 at drivers/gpu/drm/drm_vblank.c:609 drm_calc_vbltimestamp_from_scanoutpos+0x296/0x320 [drm] > [ 12.768080] Modules linked in: bnep snd_hda_codec_hdmi...

...herwise we're back to the old style vblank horror show. > > Thanks, Daniel > >> On Wed, Jul 19, 2017 at 1:25 PM, Tobias Klausmann >> <tobias.johannes.klausmann at mni.thm.de> wrote: >>> mimic the behavior of vblank_disable_fn(), another caller of >>> drm_vblank_disable_and_save(). >>> >>> This avoids oopsing, while trying to disable vblank on a not connected display: >>> >>> [ 12.768079] WARNING: CPU: 0 PID: 274 at drivers/gpu/drm/drm_vblank.c:609 drm_calc_vbltimestamp_from_scanoutpos+0x296/0x320 [drm] >>> [ 12.768080] Mod...

mimic the behavior of vblank_disable_fn(), another caller of drm_vblank_disable_and_save(). This avoids oopsing, while trying to disable vblank on a not connected display: [ 12.768079] WARNING: CPU: 0 PID: 274 at drivers/gpu/drm/drm_vblank.c:609 drm_calc_vbltimestamp_from_scanoutpos+0x296/0x320 [drm] [ 12.768080] Modules linked in: bnep snd_hda_codec_hdmi rtsx_usb_sdmmc uvcvideo...

...d _not_ fix it up. Otherwise we're back to the old style vblank horror show. Thanks, Daniel > > On Wed, Jul 19, 2017 at 1:25 PM, Tobias Klausmann > <tobias.johannes.klausmann at mni.thm.de> wrote: > > mimic the behavior of vblank_disable_fn(), another caller of > > drm_vblank_disable_and_save(). > > > > This avoids oopsing, while trying to disable vblank on a not connected display: > > > > [ 12.768079] WARNING: CPU: 0 PID: 274 at drivers/gpu/drm/drm_vblank.c:609 drm_calc_vbltimestamp_from_scanoutpos+0x296/0x320 [drm] > > [ 12.768080] Modules linked in:...

...e old style vblank horror show. >> >> Thanks, Daniel >> >>> On Wed, Jul 19, 2017 at 1:25 PM, Tobias Klausmann >>> <tobias.johannes.klausmann at mni.thm.de> wrote: >>>> mimic the behavior of vblank_disable_fn(), another caller of >>>> drm_vblank_disable_and_save(). >>>> >>>> This avoids oopsing, while trying to disable vblank on a not connected display: >>>> >>>> [ 12.768079] WARNING: CPU: 0 PID: 274 at drivers/gpu/drm/drm_vblank.c:609 drm_calc_vbltimestamp_from_scanoutpos+0x296/0x320 [drm] >>>&gt...

...d0 ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018 #12 [ffffc900039f7b18] gf119_head_vblank_put at ffffffffa04422f9 [nouveau] #13 [ffffc900039f7b88] drm_get_last_vbltimestamp at ffffffffa020ad91 [drm] #14 [ffffc900039f7ba8] drm_update_vblank_count at ffffffffa020b3e1 [drm] #15 [ffffc900039f7c10] drm_vblank_disable_and_save at ffffffffa020bbe9 [drm] #16 [ffffc900039f7c40] drm_crtc_vblank_off at ffffffffa020c3c0 [drm] #17 [ffffc900039f7cb0] nouveau_display_fini at ffffffffa048a4d6 [nouveau] #18 [ffffc900039f7ce0] nouveau_display_suspend at ffffffffa048ac4f [nouveau] #19 [ffffc900039f7d00] nouveau_do_suspend at fffffff...

...3 [ 321.474004] CR2: 00007fdd82e8f810 CR3: 0000000214683000 CR4: 00000000000006e0 [ 321.474005] Call Trace: [ 321.474068] ? nv50_head_vblank_put+0x22/0x50 [nouveau] [ 321.474085] drm_get_last_vbltimestamp+0x41/0x70 [drm] [ 321.474102] drm_update_vblank_count+0x61/0x230 [drm] [ 321.474118] drm_vblank_disable_and_save+0x59/0xc0 [drm] [ 321.474134] drm_crtc_vblank_off+0x1d5/0x210 [drm] [ 321.474152] ? drm_modeset_drop_locks+0x4e/0x60 [drm] [ 321.474203] nouveau_display_fini+0x56/0xd0 [nouveau] [ 321.474254] nouveau_display_suspend+0x4f/0x110 [nouveau] [ 321.474304] nouveau_do_suspend+0x7c/0x1e0 [nouvea...

...fffffffffffff CS: 0010 SS: 0018 > #12 [ffffc900039f7b18] gf119_head_vblank_put at ffffffffa04422f9 [nouveau] > #13 [ffffc900039f7b88] drm_get_last_vbltimestamp at ffffffffa020ad91 [drm] > #14 [ffffc900039f7ba8] drm_update_vblank_count at ffffffffa020b3e1 [drm] > #15 [ffffc900039f7c10] drm_vblank_disable_and_save at ffffffffa020bbe9 [drm] > #16 [ffffc900039f7c40] drm_crtc_vblank_off at ffffffffa020c3c0 [drm] > #17 [ffffc900039f7cb0] nouveau_display_fini at ffffffffa048a4d6 [nouveau] > #18 [ffffc900039f7ce0] nouveau_display_suspend at ffffffffa048ac4f [nouveau] > #19 [ffffc900039f7d00] nouveau_d...

...07fdd82e8f810 CR3: 0000000214683000 CR4: 00000000000006e0 > [ 321.474005] Call Trace: > [ 321.474068] ? nv50_head_vblank_put+0x22/0x50 [nouveau] > [ 321.474085] drm_get_last_vbltimestamp+0x41/0x70 [drm] > [ 321.474102] drm_update_vblank_count+0x61/0x230 [drm] > [ 321.474118] drm_vblank_disable_and_save+0x59/0xc0 [drm] > [ 321.474134] drm_crtc_vblank_off+0x1d5/0x210 [drm] > [ 321.474152] ? drm_modeset_drop_locks+0x4e/0x60 [drm] > [ 321.474203] nouveau_display_fini+0x56/0xd0 [nouveau] > [ 321.474254] nouveau_display_suspend+0x4f/0x110 [nouveau] > [ 321.474304] nouveau_do_s...

Nvidia released some documentation on how CRC support works on their GPUs, hooray! So: this patch series implements said CRC support in nouveau, along with adding some special debugfs interfaces for some relevant igt-gpu-tools tests (already on the ML). First - we add some new functionality to kthread_work in the kernel, and then use this to add a new feature to DRM that Ville Syrj?l? came up