Displaying 11 results from an estimated 11 matches for "drm_sched_init".
2025 Jan 22
1
[PATCH] drm/sched: Use struct for drm_sched_init() params
Hi Philipp,
On 22/01/25 11:08, Philipp Stanner wrote:
> drm_sched_init() has a great many parameters and upcoming new
> functionality for the scheduler might add even more. Generally, the
> great number of parameters reduces readability and has already caused
> one missnaming in:
>
> commit 6f1cacf4eba7 ("drm/nouveau: Improve variable name in nouv...
2025 Jan 23
2
[PATCH] drm/sched: Use struct for drm_sched_init() params
On Wed, 2025-01-22 at 19:07 -0300, Ma?ra Canal wrote:
> Hi Philipp,
>
> On 22/01/25 11:08, Philipp Stanner wrote:
> > drm_sched_init() has a great many parameters and upcoming new
> > functionality for the scheduler might add even more. Generally, the
> > great number of parameters reduces readability and has already
> > caused
> > one missnaming in:
> >
> > commit 6f1cacf4eba7 ("drm/nou...
2025 Jan 22
5
[PATCH] drm/sched: Use struct for drm_sched_init() params
drm_sched_init() has a great many parameters and upcoming new
functionality for the scheduler might add even more. Generally, the
great number of parameters reduces readability and has already caused
one missnaming in:
commit 6f1cacf4eba7 ("drm/nouveau: Improve variable name in nouveau_sched_init()")....
2025 Jan 23
0
[PATCH] drm/sched: Use struct for drm_sched_init() params
...-0300, Ma?ra Canal wrote:
>> Hi Philipp,
>>
>> On 23/01/25 05:10, Philipp Stanner wrote:
>>> On Wed, 2025-01-22 at 19:07 -0300, Ma?ra Canal wrote:
>>>> Hi Philipp,
>>>>
>>>> On 22/01/25 11:08, Philipp Stanner wrote:
>>>>> drm_sched_init() has a great many parameters and upcoming new
>>>>> functionality for the scheduler might add even more. Generally,
>>>>> the
>>>>> great number of parameters reduces readability and has already
>>>>> caused
>>>>> one missn...
2025 Jan 22
1
[PATCH] drm/sched: Use struct for drm_sched_init() params
...>> +++ b/drivers/gpu/drm/panthor/panthor_sched.c
> >> @@ -3272,6 +3272,7 @@ group_create_queue(struct panthor_group *group,
> >> const struct drm_panthor_queue_create *args)
> >> {
> >> struct drm_gpu_scheduler *drm_sched;
> >> + struct drm_sched_init_params sched_params;
> >
> > nit: Could we use a struct initializer instead of a
> > memset(0)+field-assignment?
> >
> > struct drm_sched_init_params sched_params = {
Actually, you can even make it const if it's not modified after the
declaration.
> >...
2025 Jan 23
1
[PATCH] drm/sched: Use struct for drm_sched_init() params
...u/drm/panthor/panthor_sched.c
> > >> @@ -3272,6 +3272,7 @@ group_create_queue(struct panthor_group *group,
> > >> const struct drm_panthor_queue_create *args)
> > >> {
> > >> struct drm_gpu_scheduler *drm_sched;
> > >> + struct drm_sched_init_params sched_params;
> > >
> > > nit: Could we use a struct initializer instead of a
> > > memset(0)+field-assignment?
> > >
> > > struct drm_sched_init_params sched_params = {
>
> Actually, you can even make it const if it's not modified...
2025 Jan 23
0
[PATCH] drm/sched: Use struct for drm_sched_init() params
On Thu, 23 Jan 2025 08:33:01 +0100
Philipp Stanner <phasta at mailbox.org> wrote:
> On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote:
> > On Wed, 22 Jan 2025 15:08:20 +0100
> > Philipp Stanner <phasta at kernel.org> wrote:
> >
> > > ?int drm_sched_init(struct drm_gpu_scheduler *sched,
> > > - ?? const struct drm_sched_backend_ops *ops,
> > > - ?? struct workqueue_struct *submit_wq,
> > > - ?? u32 num_rqs, u32 credit_limit, unsigned int hang_limit,
> > > - ?? long timeout, struct workqueue_struct *timeout_wq,
&g...
2025 Jan 23
0
[PATCH] drm/sched: Use struct for drm_sched_init() params
On Thu, Jan 23, 2025 at 08:33:01AM +0100, Philipp Stanner wrote:
> On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote:
> > On Wed, 22 Jan 2025 15:08:20 +0100
> > Philipp Stanner <phasta at kernel.org> wrote:
> >
> > > ?int drm_sched_init(struct drm_gpu_scheduler *sched,
> > > - ?? const struct drm_sched_backend_ops *ops,
> > > - ?? struct workqueue_struct *submit_wq,
> > > - ?? u32 num_rqs, u32 credit_limit, unsigned int hang_limit,
> > > - ?? long timeout, struct workqueue_struct *timeout_wq,
&g...
2025 Jan 23
0
[PATCH] drm/sched: Use struct for drm_sched_init() params
...2025 at 08:33:01AM +0100, Philipp Stanner wrote:
> > > On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote:
> > > > On Wed, 22 Jan 2025 15:08:20 +0100
> > > > Philipp Stanner <phasta at kernel.org> wrote:
> > > >
> > > > > ?int drm_sched_init(struct drm_gpu_scheduler *sched,
> > > > > - ?? const struct drm_sched_backend_ops *ops,
> > > > > - ?? struct workqueue_struct *submit_wq,
> > > > > - ?? u32 num_rqs, u32 credit_limit, unsigned int hang_limit,
> > > > > - ?? long timeout,...
2024 Jul 12
1
[PATCH v2] drm/nouveau: Improve variable names in nouveau_sched_init()
nouveau_sched_init() uses the function drm_sched_init(). The latter
function has parameters called "hang_limit" and "timeout" in its API
documentation.
nouveau_sched_init(), however, defines a variable called
"job_hang_limit" which is passed to drm_sched_init()'s "timeout"
parameter. The actual "hang_l...
2024 Jul 11
1
[PATCH] drm/nouveau: Improve variable names in nouveau_sched_init()
nouveau_sched_init() uses the function drm_sched_init(). The latter
function has parameters called "hang_limit" and "timeout" in its API
documentation.
nouveau_sched_init(), however, defines a variable called
"job_hang_limit" which is passed to drm_sched_init()'s "timeout"
parameter. The actual "hang_l...