search for: drm_property_add_enum

From: Ville Syrjälä <ville.syrjala at linux.intel.com> drm_property_add_enum() can calculate the index itself just fine, so no point in having the caller pass it in. Cc: Patrik Jakobsson <patrik.r.jakobsson at gmail.com> Cc: Ben Skeggs <bskeggs at redhat.com> Cc: nouveau at lists.freedesktop.org Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com&...

...f Lisovskiy, Stanislav [stanislav.lisovskiy at intel.com] Sent: Monday, April 23, 2018 4:59 PM To: Ville Syrjala; dri-devel at lists.freedesktop.org Cc: nouveau at lists.freedesktop.org; intel-gfx at lists.freedesktop.org; Ben Skeggs Subject: Re: [Intel-gfx] [PATCH] drm: Don't pass the index to drm_property_add_enum() Acked-by: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com> Best Regards, Lisovskiy Stanislav Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo> ________________________________________ From: Ville Syrjala [ville.syrjala at linux.intel.com] Sent: Fri...

..._______________ From: Ville Syrjala [ville.syrjala at linux.intel.com] Sent: Friday, March 16, 2018 9:04 PM To: dri-devel at lists.freedesktop.org Cc: intel-gfx at lists.freedesktop.org; Patrik Jakobsson; Ben Skeggs; nouveau at lists.freedesktop.org Subject: [PATCH] drm: Don't pass the index to drm_property_add_enum() From: Ville Syrjälä <ville.syrjala at linux.intel.com> drm_property_add_enum() can calculate the index itself just fine, so no point in having the caller pass it in. Cc: Patrik Jakobsson <patrik.r.jakobsson at gmail.com> Cc: Ben Skeggs <bskeggs at redhat.com> Cc: nouveau at l...

Hello, This is an attempt at providing generic support for underscan connector props. We already have 3 drivers defining the same underscan, underscan vborder and underscan hborder properties (amd, radeon and nouveau) and I am about to add a new one, hence my proposal to put the prop parsing code in the core and add ->underscan fields to drm_connector_state. Note that I use this new

...urn -ENOMEM; > + > + for (i = 0; i < ARRAY_SIZE(drm_underscan_mode_enum_list); i++) { > + const struct drm_prop_enum_list *entry; > + int ret; > + > + if (!(BIT(i) & mode_mask)) > + continue; > + > + entry = &drm_underscan_mode_enum_list[i]; > + ret = drm_property_add_enum(prop, entry->type, entry->name); > + if (ret) > + goto err_free_mode_prop; > + } > + > + connector->underscan_mode_property = prop; > + > + prop = drm_property_create_range(dev, 0, "underscan hborder", 0, > + max_hborder); > + if (!prop) > +...

...+ hweight32(mode_mask)); + if (!prop) + return -ENOMEM; + + for (i = 0; i < ARRAY_SIZE(drm_underscan_mode_enum_list); i++) { + const struct drm_prop_enum_list *entry; + int ret; + + if (!(BIT(i) & mode_mask)) + continue; + + entry = &drm_underscan_mode_enum_list[i]; + ret = drm_property_add_enum(prop, entry->type, entry->name); + if (ret) + goto err_free_mode_prop; + } + + connector->underscan_mode_property = prop; + + prop = drm_property_create_range(dev, 0, "underscan hborder", 0, + max_hborder); + if (!prop) + goto err_free_mode_prop; + + connector->unders...

...+ hweight32(mode_mask)); + if (!prop) + return -ENOMEM; + + for (i = 0; i < ARRAY_SIZE(drm_underscan_mode_enum_list); i++) { + const struct drm_prop_enum_list *entry; + int ret; + + if (!(BIT(i) & mode_mask)) + continue; + + entry = &drm_underscan_mode_enum_list[i]; + ret = drm_property_add_enum(prop, entry->type, entry->name); + if (ret) + goto err_free_mode_prop; + } + + connector->underscan_mode_property = prop; + + prop = drm_property_create_range(dev, 0, "underscan hborder", 0, + max_hborder); + if (!prop) + goto err_free_mode_prop; + + connector->unders...

...< ARRAY_SIZE(drm_underscan_mode_enum_list); i++) { > > + const struct drm_prop_enum_list *entry; > > + int ret; > > + > > + if (!(BIT(i) & mode_mask)) > > + continue; > > + > > + entry = &drm_underscan_mode_enum_list[i]; > > + ret = drm_property_add_enum(prop, entry->type, entry->name); > > + if (ret) > > + goto err_free_mode_prop; > > + } > > + > > + connector->underscan_mode_property = prop; > > + > > + prop = drm_property_create_range(dev, 0, "underscan hborder", 0, > > +...

...>+ return -ENOMEM; >+ >+ for (i = 0; i < ARRAY_SIZE(drm_underscan_mode_enum_list); i++) { >+ const struct drm_prop_enum_list *entry; >+ int ret; >+ >+ if (!(BIT(i) & mode_mask)) >+ continue; >+ >+ entry = &drm_underscan_mode_enum_list[i]; >+ ret = drm_property_add_enum(prop, entry->type, entry->name); >+ if (ret) >+ goto err_free_mode_prop; >+ } >+ >+ connector->underscan_mode_property = prop; >+ >+ prop = drm_property_create_range(dev, 0, "underscan hborder", 0, >+ max_hborder); >+ if (!prop) >+ goto err_...

Hello, This is an attempt at providing generic support for underscan connector props. We already have 3 drivers defining the same underscan, underscan vborder and underscan hborder properties (amd, radeon and nouveau) and I am about to add a new one, hence my proposal to put the prop parsing code in the core and add ->underscan fields to drm_connector_state. This v3 was based on the "VC4

...urn -ENOMEM; > + > + for (i = 0; i < ARRAY_SIZE(drm_underscan_mode_enum_list); i++) { > + const struct drm_prop_enum_list *entry; > + int ret; > + > + if (!(BIT(i) & mode_mask)) > + continue; > + > + entry = &drm_underscan_mode_enum_list[i]; > + ret = drm_property_add_enum(prop, entry->type, entry->name); > + if (ret) > + goto err_free_mode_prop; > + } > + > + connector->underscan_mode_property = prop; > + > + prop = drm_property_create_range(dev, 0, "underscan hborder", 0, > + max_hborder); > + if (!prop) > +...

Hello, This is an attempt at providing generic support for underscan connector props. We already have 3 drivers defining the same underscan, underscan vborder and underscan hborder properties (amd, radeon and nouveau) and I am about to add a new one, hence my proposal to put the prop parsing code in the core and add ->underscan fields to drm_connector_state. In this v2, I also converted the