search for: drm_prime_cap_

...Maybe we need some helpers for virtual drivers which only allow > self-reimport and nothing else at all? The current gem prime helpers handle this reasonable well, I don't see a need for that. More useful would be some way to signal this self-reimport capability to userspace somehow. See DRM_PRIME_CAP_LOCAL patch. Right now I have the choice to set DRM_PRIME_CAP_{IMPORT,EXPORT}, in which case some userspace assumes it can do cross-driver export/import and trips over that not working. Or I do not set DRM_PRIME_CAP_{IMPORT,EXPORT}, which breaks DRI3 ... > I think there's qxl, virgl, expo...

...Maybe we need some helpers for virtual drivers which only allow > self-reimport and nothing else at all? The current gem prime helpers handle this reasonable well, I don't see a need for that. More useful would be some way to signal this self-reimport capability to userspace somehow. See DRM_PRIME_CAP_LOCAL patch. Right now I have the choice to set DRM_PRIME_CAP_{IMPORT,EXPORT}, in which case some userspace assumes it can do cross-driver export/import and trips over that not working. Or I do not set DRM_PRIME_CAP_{IMPORT,EXPORT}, which breaks DRI3 ... > I think there's qxl, virgl, expo...

Hi, > > More useful would be some way to signal this self-reimport capability > > to userspace somehow. See DRM_PRIME_CAP_LOCAL patch. > > Userspace is supposed to test whether import/export works for a > specific combo, not blindly assume it does and then keel over. I think > we need to fix that, not add more flags - there's lots of reasons why > a given pair of devices can't share buffers (e.g...

On Sat, 12 Jan 2019 at 07:13, Dave Airlie <airlied at gmail.com> wrote: > > On Thu, 10 Jan 2019 at 18:17, Gerd Hoffmann <kraxel at redhat.com> wrote: > > > > Also set prime_handle_to_fd and prime_fd_to_handle to NULL, > > so drm will not advertive DRM_PRIME_CAP_{IMPORT,EXPORT} to > > userspace. It's been pointed out to me that disables DRI3 for these devices, I'm not sure that is the solution we actually wanted. any ideas? Dave. > > > > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> > > Reviewed-by: Dave Airlie...

On Sat, 12 Jan 2019 at 07:13, Dave Airlie <airlied at gmail.com> wrote: > > On Thu, 10 Jan 2019 at 18:17, Gerd Hoffmann <kraxel at redhat.com> wrote: > > > > Also set prime_handle_to_fd and prime_fd_to_handle to NULL, > > so drm will not advertive DRM_PRIME_CAP_{IMPORT,EXPORT} to > > userspace. It's been pointed out to me that disables DRI3 for these devices, I'm not sure that is the solution we actually wanted. any ideas? Dave. > > > > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> > > Reviewed-by: Dave Airlie...

...2 Jan 2019 at 07:13, Dave Airlie <airlied at gmail.com> wrote: > > > > On Thu, 10 Jan 2019 at 18:17, Gerd Hoffmann <kraxel at redhat.com> wrote: > > > > > > Also set prime_handle_to_fd and prime_fd_to_handle to NULL, > > > so drm will not advertive DRM_PRIME_CAP_{IMPORT,EXPORT} to > > > userspace. > > It's been pointed out to me that disables DRI3 for these devices, I'm > not sure that is the solution we actually wanted. > > any ideas? Well. Lets have a look at where we stand: * drm_gem_prime_export() works with qxl, yo...

...irtual drivers which only allow > > self-reimport and nothing else at all? > > The current gem prime helpers handle this reasonable well, > I don't see a need for that. > > More useful would be some way to signal this self-reimport capability > to userspace somehow. See DRM_PRIME_CAP_LOCAL patch. Userspace is supposed to test whether import/export works for a specific combo, not blindly assume it does and then keel over. I think we need to fix that, not add more flags - there's lots of reasons why a given pair of devices can't share buffers (e.g. all the contiguous allo...

...Airlie <airlied at gmail.com> wrote: > > > > > > On Thu, 10 Jan 2019 at 18:17, Gerd Hoffmann <kraxel at redhat.com> wrote: > > > > > > > > Also set prime_handle_to_fd and prime_fd_to_handle to NULL, > > > > so drm will not advertive DRM_PRIME_CAP_{IMPORT,EXPORT} to > > > > userspace. > > > > It's been pointed out to me that disables DRI3 for these devices, I'm > > not sure that is the solution we actually wanted. > > > > any ideas? > > Well. Lets have a look at where we stand: > &gt...

...Airlie <airlied at gmail.com> wrote: > > > > > > On Thu, 10 Jan 2019 at 18:17, Gerd Hoffmann <kraxel at redhat.com> wrote: > > > > > > > > Also set prime_handle_to_fd and prime_fd_to_handle to NULL, > > > > so drm will not advertive DRM_PRIME_CAP_{IMPORT,EXPORT} to > > > > userspace. > > > > It's been pointed out to me that disables DRI3 for these devices, I'm > > not sure that is the solution we actually wanted. > > > > any ideas? > > Well. Lets have a look at where we stand: > &gt...

This reverts commit f4c34b1e2a37d5676180901fa6ff188bcb6371f8. Simliar to commit a0cecc23cfcb Revert "drm/virtio: drop prime import/export callbacks". We have to do the same with qxl, for the same reasons (it breaks DRI3). Drop the WARN_ON_ONCE(). Fixes: f4c34b1e2a37d5676180901fa6ff188bcb6371f8 Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> ---

This reverts commit f4c34b1e2a37d5676180901fa6ff188bcb6371f8. Simliar to commit a0cecc23cfcb Revert "drm/virtio: drop prime import/export callbacks". We have to do the same with qxl, for the same reasons (it breaks DRI3). Drop the WARN_ON_ONCE(). Fixes: f4c34b1e2a37d5676180901fa6ff188bcb6371f8 Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> ---