Displaying 20 results from an estimated 21 matches for "drm_mode_probed_add".
2024 Jun 26
1
[PATCH] drm/nouveau: fix null pointer dereference in nouveau_connector_get_modes
...001,8 @@ nouveau_connector_get_modes(struct drm_connector *connector)
> struct drm_display_mode *mode;
>
> mode = drm_mode_duplicate(dev, nv_connector->native_mode);
> + if (!mode)
> + return -ENOMEM;
Do not return negative values from .get_modes().
BR,
Jani.
> drm_mode_probed_add(connector, mode);
> ret = 1;
> }
--
Jani Nikula, Intel
2020 Jul 24
2
[PATCH 0/2] drm/probe_helper, drm/nouveau: Validate MST modes against PBN
Now that we've added the hooks that we've needed for this and used them
in i915, let's add one more hook (which I could use some feedback on,
I'm not sure if it's worth maybe just reworking how we do mode pruning
in nouveau instead...) and start using this in our mst ->mode_valid
callback to filter out impossible to set modes on MST connectors.
Lyude Paul (2):
2024 Jun 26
0
[PATCH] drm/nouveau: fix null pointer dereference in nouveau_connector_get_modes
...licate(). Add a check to avoid npd.
1. Can a wording approach (like the following) be a better change description?
A null pointer is stored in the local variable ?mode? after a call
of the function ?drm_mode_duplicate? failed. This pointer was passed to
a subsequent call of the function ?drm_mode_probed_add? where an undesirable
dereference will be performed then.
Thus add a corresponding return value check.
2. Would you like to add any tags (like ?Fixes? and ?Cc?) accordingly?
3. How do you think about to append parentheses to the function name
in the summary phrase?
4. How do you thin...
2020 Feb 25
2
[PATCH 04/12] drm: Nuke mode->vrefresh
...>
> >
> > @@ -2300,7 +2299,6 @@ int vmw_du_connector_fill_modes(struct drm_connector *connector,
> > mode = drm_mode_duplicate(dev, bmode);
> > if (!mode)
> > return 0;
> > - mode->vrefresh = drm_mode_vrefresh(mode);
> >
> > drm_mode_probed_add(connector, mode);
> > }
> > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h
> > index 7dab7f172431..52e8ca613e4b 100644
> > --- a/include/drm/drm_modes.h
> > +++ b/include/drm/drm_modes.h
> > @@ -380,16 +380,6 @@ struct drm_display_mode {
> &g...
2020 Feb 24
0
[PATCH 04/12] drm: Nuke mode->vrefresh
...fresh = drm_mode_vrefresh(mode);
> }
>
>
> @@ -2300,7 +2299,6 @@ int vmw_du_connector_fill_modes(struct drm_connector *connector,
> mode = drm_mode_duplicate(dev, bmode);
> if (!mode)
> return 0;
> - mode->vrefresh = drm_mode_vrefresh(mode);
>
> drm_mode_probed_add(connector, mode);
> }
> diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h
> index 7dab7f172431..52e8ca613e4b 100644
> --- a/include/drm/drm_modes.h
> +++ b/include/drm/drm_modes.h
> @@ -380,16 +380,6 @@ struct drm_display_mode {
> */
> int private_flags;...
2020 Feb 25
0
[PATCH 04/12] drm: Nuke mode->vrefresh
...gt;>> @@ -2300,7 +2299,6 @@ int vmw_du_connector_fill_modes(struct drm_connector *connector,
>>> mode = drm_mode_duplicate(dev, bmode);
>>> if (!mode)
>>> return 0;
>>> - mode->vrefresh = drm_mode_vrefresh(mode);
>>>
>>> drm_mode_probed_add(connector, mode);
>>> }
>>> diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h
>>> index 7dab7f172431..52e8ca613e4b 100644
>>> --- a/include/drm/drm_modes.h
>>> +++ b/include/drm/drm_modes.h
>>> @@ -380,16 +380,6 @@ struct drm_disp...
2009 Aug 13
9
[PATCHv2 01/10] drm/nouveau: Fix a lock up at NVSetOwner with nv11.
It seems it was only locking up in the context of
nouveau_hw_save_vga_fonts, when it actually did something (because
the console wasn't already in graphics mode).
Signed-off-by: Francisco Jerez <currojerez at riseup.net>
---
drivers/gpu/drm/nouveau/nouveau_hw.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_hw.c
2020 Feb 19
5
[PATCH 04/12] drm: Nuke mode->vrefresh
...l * (u32)mode->vtotal / 100 * 6;
- mode->vrefresh = drm_mode_vrefresh(mode);
}
@@ -2300,7 +2299,6 @@ int vmw_du_connector_fill_modes(struct drm_connector *connector,
mode = drm_mode_duplicate(dev, bmode);
if (!mode)
return 0;
- mode->vrefresh = drm_mode_vrefresh(mode);
drm_mode_probed_add(connector, mode);
}
diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h
index 7dab7f172431..52e8ca613e4b 100644
--- a/include/drm/drm_modes.h
+++ b/include/drm/drm_modes.h
@@ -380,16 +380,6 @@ struct drm_display_mode {
*/
int private_flags;
- /**
- * @vrefresh:
- *
- * Vertic...
2009 Aug 12
14
[PATCH 00/12] TV-out modesetting kernel patches.
This patch series adds TV-out modesetting support to the KMS
implementation.
I've tried to test it on all the hardware I've got at hand (that is
nv11, nv17, nv34, nv35, nv40, nv4b) with every possible output
combination; I believe it has reached a mergeable state, however it
depends on some commits from drm-next that haven't got into Linus'
tree yet, if you agree to merge this
2015 Mar 24
10
[PATCH] Add virtio gpu driver.
...RES_DEF;
+ height = YRES_DEF;
+ drm_set_preferred_mode(connector, XRES_DEF, YRES_DEF);
+ } else {
+ DRM_DEBUG("add mode: %dx%d\n", width, height);
+ mode = drm_cvt_mode(connector->dev, width, height, 60,
+ false, false, false);
+ mode->type |= DRM_MODE_TYPE_PREFERRED;
+ drm_mode_probed_add(connector, mode);
+ count++;
+ }
+
+ return count;
+}
+
+static int virtio_gpu_conn_mode_valid(struct drm_connector *connector,
+ struct drm_display_mode *mode)
+{
+ struct virtio_gpu_output *output =
+ drm_connector_to_virtio_gpu_output(connector);
+ int width, height;
+
+ width = le32...
2015 Mar 24
10
[PATCH] Add virtio gpu driver.
...RES_DEF;
+ height = YRES_DEF;
+ drm_set_preferred_mode(connector, XRES_DEF, YRES_DEF);
+ } else {
+ DRM_DEBUG("add mode: %dx%d\n", width, height);
+ mode = drm_cvt_mode(connector->dev, width, height, 60,
+ false, false, false);
+ mode->type |= DRM_MODE_TYPE_PREFERRED;
+ drm_mode_probed_add(connector, mode);
+ count++;
+ }
+
+ return count;
+}
+
+static int virtio_gpu_conn_mode_valid(struct drm_connector *connector,
+ struct drm_display_mode *mode)
+{
+ struct virtio_gpu_output *output =
+ drm_connector_to_virtio_gpu_output(connector);
+ int width, height;
+
+ width = le32...
2015 Mar 24
0
[PATCH] Add virtio gpu driver.
...+ drm_set_preferred_mode(connector, XRES_DEF, YRES_DEF);
> + } else {
> + DRM_DEBUG("add mode: %dx%d\n", width, height);
> + mode = drm_cvt_mode(connector->dev, width, height, 60,
> + false, false, false);
> + mode->type |= DRM_MODE_TYPE_PREFERRED;
> + drm_mode_probed_add(connector, mode);
> + count++;
> + }
> +
> + return count;
> +}
> +
> +static int virtio_gpu_conn_mode_valid(struct drm_connector *connector,
> + struct drm_display_mode *mode)
> +{
> + struct virtio_gpu_output *output =
> + drm_connector_to_virtio_gpu_ou...
2015 Mar 24
0
[PATCH] Add virtio gpu driver.
...+ drm_set_preferred_mode(connector, XRES_DEF, YRES_DEF);
> + } else {
> + DRM_DEBUG("add mode: %dx%d\n", width, height);
> + mode = drm_cvt_mode(connector->dev, width, height, 60,
> + false, false, false);
> + mode->type |= DRM_MODE_TYPE_PREFERRED;
> + drm_mode_probed_add(connector, mode);
> + count++;
> + }
> +
> + return count;
> +}
> +
> +static int virtio_gpu_conn_mode_valid(struct drm_connector *connector,
> + struct drm_display_mode *mode)
> +{
> + struct virtio_gpu_output *output =
> + drm_connector_to_virtio_gpu_ou...
2015 May 22
1
[PATCH v3 4/4] Add virtio gpu driver.
...RES_DEF;
+ height = YRES_DEF;
+ drm_set_preferred_mode(connector, XRES_DEF, YRES_DEF);
+ } else {
+ DRM_DEBUG("add mode: %dx%d\n", width, height);
+ mode = drm_cvt_mode(connector->dev, width, height, 60,
+ false, false, false);
+ mode->type |= DRM_MODE_TYPE_PREFERRED;
+ drm_mode_probed_add(connector, mode);
+ count++;
+ }
+
+ return count;
+}
+
+static int virtio_gpu_conn_mode_valid(struct drm_connector *connector,
+ struct drm_display_mode *mode)
+{
+ struct virtio_gpu_output *output =
+ drm_connector_to_virtio_gpu_output(connector);
+ int width, height;
+
+ width = le32...
2015 May 22
1
[PATCH v3 4/4] Add virtio gpu driver.
...RES_DEF;
+ height = YRES_DEF;
+ drm_set_preferred_mode(connector, XRES_DEF, YRES_DEF);
+ } else {
+ DRM_DEBUG("add mode: %dx%d\n", width, height);
+ mode = drm_cvt_mode(connector->dev, width, height, 60,
+ false, false, false);
+ mode->type |= DRM_MODE_TYPE_PREFERRED;
+ drm_mode_probed_add(connector, mode);
+ count++;
+ }
+
+ return count;
+}
+
+static int virtio_gpu_conn_mode_valid(struct drm_connector *connector,
+ struct drm_display_mode *mode)
+{
+ struct virtio_gpu_output *output =
+ drm_connector_to_virtio_gpu_output(connector);
+ int width, height;
+
+ width = le32...
2015 Apr 01
3
[PATCH v2 3/4] Add virtio gpu driver.
...RES_DEF;
+ height = YRES_DEF;
+ drm_set_preferred_mode(connector, XRES_DEF, YRES_DEF);
+ } else {
+ DRM_DEBUG("add mode: %dx%d\n", width, height);
+ mode = drm_cvt_mode(connector->dev, width, height, 60,
+ false, false, false);
+ mode->type |= DRM_MODE_TYPE_PREFERRED;
+ drm_mode_probed_add(connector, mode);
+ count++;
+ }
+
+ return count;
+}
+
+static int virtio_gpu_conn_mode_valid(struct drm_connector *connector,
+ struct drm_display_mode *mode)
+{
+ struct virtio_gpu_output *output =
+ drm_connector_to_virtio_gpu_output(connector);
+ int width, height;
+
+ width = le32...
2015 Apr 01
3
[PATCH v2 3/4] Add virtio gpu driver.
...RES_DEF;
+ height = YRES_DEF;
+ drm_set_preferred_mode(connector, XRES_DEF, YRES_DEF);
+ } else {
+ DRM_DEBUG("add mode: %dx%d\n", width, height);
+ mode = drm_cvt_mode(connector->dev, width, height, 60,
+ false, false, false);
+ mode->type |= DRM_MODE_TYPE_PREFERRED;
+ drm_mode_probed_add(connector, mode);
+ count++;
+ }
+
+ return count;
+}
+
+static int virtio_gpu_conn_mode_valid(struct drm_connector *connector,
+ struct drm_display_mode *mode)
+{
+ struct virtio_gpu_output *output =
+ drm_connector_to_virtio_gpu_output(connector);
+ int width, height;
+
+ width = le32...
2020 Apr 04
0
[PATCH v2 03/17] drm: Nuke mode->vrefresh
...esh = drm_mode_vrefresh(mode);
> }
>
>
> @@ -2212,7 +2211,6 @@ int vmw_du_connector_fill_modes(struct
> drm_connector *connector,
> mode = drm_mode_duplicate(dev, bmode);
> if (!mode)
> return 0;
> - mode->vrefresh = drm_mode_vrefresh(mode);
>
> drm_mode_probed_add(connector, mode);
> }
> diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h
> index 730fc31de4fb..8b05f3705d0e 100644
> --- a/include/drm/drm_modes.h
> +++ b/include/drm/drm_modes.h
> @@ -380,16 +380,6 @@ struct drm_display_mode {
> */
> int private_flags;...
2020 Apr 28
0
[PATCH v3 03/16] drm: Nuke mode->vrefresh
...l * (u32)mode->vtotal / 100 * 6;
- mode->vrefresh = drm_mode_vrefresh(mode);
}
@@ -2212,7 +2211,6 @@ int vmw_du_connector_fill_modes(struct drm_connector *connector,
mode = drm_mode_duplicate(dev, bmode);
if (!mode)
return 0;
- mode->vrefresh = drm_mode_vrefresh(mode);
drm_mode_probed_add(connector, mode);
}
diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h
index 730fc31de4fb..8b05f3705d0e 100644
--- a/include/drm/drm_modes.h
+++ b/include/drm/drm_modes.h
@@ -380,16 +380,6 @@ struct drm_display_mode {
*/
int private_flags;
- /**
- * @vrefresh:
- *
- * Vertic...
2012 Dec 12
43
[PATCH 00/37] [RFC] revamped modeset locking
Hi all,
First thing first: It works, I now no longer have a few dropped frames every 10s
on my testbox here with the pageflip i-g-t tests.
Random notes:
- New design has per-crtc locks to protect the crtc input-side (pageflip,
cursor) for r/w and the output state of the crtc (mode, dpms) as read-only. It
also required completely revamped fb lifecycle management, those are now
refcounted