search for: drm_mode_page_flip_ioctl

...- > >> - ret = drm_crtc_vblank_get(crtc); > > > > The DRM core's atomic page flip helper doesn't get/put vblank. Have > > you double-checked that removing them isn't a problem ? > > This patch makes the amdgpu DM code use the page_flip_target hook. > drm_mode_page_flip_ioctl calls drm_crtc_vblank_get before the > page_flip_target hook. > > You're right though that the fact that drm_atomic_helper_page_flip doesn't > call drm_crtc_vblank_get is a bit alarming. From the > DRM_IOCTL_MODE_PAGE_FLIP POV, drm_crtc_vblank_get must be called > when us...

Hi Andrey, Thank you for the patch. On Monday 16 Jan 2017 10:44:57 Andrey Grodzovsky wrote: > Change-Id: Iad3e0b9b3546e4e4dc79be9233daf4fe4dba83e0 > Signed-off-by: Andrey Grodzovsky <Andrey.Grodzovsky at amd.com> > --- > .../drm/amd/display/amdgpu_dm/amdgpu_dm_types.c | 92 ++---------------- > 1 file changed, 6 insertions(+), 86 deletions(-) > > diff --git

...> - return -ENOMEM; >> - >> - ret = drm_crtc_vblank_get(crtc); > > The DRM core's atomic page flip helper doesn't get/put vblank. Have you > double-checked that removing them isn't a problem ? This patch makes the amdgpu DM code use the page_flip_target hook. drm_mode_page_flip_ioctl calls drm_crtc_vblank_get before the page_flip_target hook. You're right though that the fact that drm_atomic_helper_page_flip doesn't call drm_crtc_vblank_get is a bit alarming. From the DRM_IOCTL_MODE_PAGE_FLIP POV, drm_crtc_vblank_get must be called when userspace calls the ioctl (eithe...

Hi Andrey, Thank you for the patch. On Monday 16 Jan 2017 10:44:55 Andrey Grodzovsky wrote: > Allows using atomic flip helpers for drivers > using ASYNC flip. > Remove ASYNC_FLIP restriction in helpers and > caches the page flip flags in drm_plane_state > to be used in the low level drivers. > > Signed-off-by: Andrey Grodzovsky <Andrey.Grodzovsky at amd.com> > ---

...ers using the helper will not reject that async flag, > even if they don't implement support for async page flip. You need to either > patch them all to reject the flag, or implement async page flip support for all > of them (preferable in the helpers, and then remove the Please check drm_mode_page_flip_ioctl, one of the checks in the beginning is if ((page_flip->flags & DRM_MODE_PAGE_FLIP_ASYNC) && !dev->mode_config.async_page_flip) return -EINVAL; We in DC explicitly set dev->mode_config.async_page_flip = true, any driver which is Not supporting ASYNC flip will fail the IOCTL...

...[<ffffffff810b9dbd>] lock_acquire+0x90/0x1f9 [<ffffffff816ed517>] mutex_lock_nested+0x56/0x3bb [<ffffffffa0347e9c>] nouveau_bo_pin+0x3c/0x15b [nouveau] [<ffffffffa0353938>] nouveau_crtc_page_flip+0xef/0x68b [nouveau] [<ffffffffa0276595>] drm_mode_page_flip_ioctl+0x289/0x336 [drm] [<ffffffffa02651b6>] drm_ioctl+0x4d3/0x619 [drm] [<ffffffff81196278>] do_vfs_ioctl+0x90/0x50a [<ffffffff81196781>] SyS_ioctl+0x8f/0x9e [<ffffffff816fa6a4>] tracesys+0xdd/0xe2 -> #0 (&drm_client_lock_class_key){+.+.+.}:...

...35904] ee280000 e94ce400 f22cd800 f4232000 c0168000 edd9cb40 ec161800 e784ac00 Apr 29 22:16:06 h kernel: [ 78.636025] Call Trace: Apr 29 22:16:06 h kernel: [ 78.636109] [<f8fc398b>] nouveau_crtc_page_flip+0x34b/0x780 [nouveau] Apr 29 22:16:06 h kernel: [ 78.636225] [<f8a95328>] drm_mode_page_flip_ioctl+0x198/0x300 [drm] Apr 29 22:16:06 h kernel: [ 78.636328] [<f8a95190>] ? drm_mode_gamma_get_ioctl+0xd0/0xd0 [drm] Apr 29 22:16:06 h kernel: [ 78.636425] [<f8a861a5>] drm_ioctl+0x1f5/0x560 [drm] Apr 29 22:16:06 h kernel: [ 78.636425] [<c11bf66f>] ? core_sys_select+0x18f/0x2...

Hi all, First thing first: It works, I now no longer have a few dropped frames every 10s on my testbox here with the pageflip i-g-t tests. Random notes: - New design has per-crtc locks to protect the crtc input-side (pageflip, cursor) for r/w and the output state of the crtc (mode, dpms) as read-only. It also required completely revamped fb lifecycle management, those are now refcounted