search for: drm_mode_page_flip_event

From: Gustavo Padovan <gustavo.padovan at collabora.co.uk> virtio_gpu was failing to send vblank events when using the atomic IOCTL with the DRM_MODE_PAGE_FLIP_EVENT flag set. This patch fixes each and enables atomic pageflips updates. Signed-off-by: Gustavo Padovan <gustavo.padovan at collabora.co.uk> --- drivers/gpu/drm/virtio/virtgpu_display.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b...

From: Gustavo Padovan <gustavo.padovan at collabora.co.uk> virtio_gpu was failing to send vblank events when using the atomic IOCTL with the DRM_MODE_PAGE_FLIP_EVENT flag set. This patch fixes each and enables atomic pageflips updates. Signed-off-by: Gustavo Padovan <gustavo.padovan at collabora.co.uk> --- drivers/gpu/drm/virtio/virtgpu_display.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b...

From: Gustavo Padovan <gustavo.padovan at collabora.co.uk> Simplify code by using the new vblank crtc helpers. Signed-off-by: Gustavo Padovan <gustavo.padovan at collabora.co.uk> --- drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index

From: Gustavo Padovan <gustavo.padovan at collabora.co.uk> Simplify code by using the new vblank crtc helpers. Signed-off-by: Gustavo Padovan <gustavo.padovan at collabora.co.uk> --- drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index

From: Gustavo Padovan <gustavo.padovan at collabora.co.uk> virtio_gpu was failing to send vblank events when using the atomic IOCTL with the DRM_MODE_PAGE_FLIP_EVENT flag set. This patch fixes each and enables atomic pageflips updates. Signed-off-by: Gustavo Padovan <gustavo.padovan at collabora.co.uk> --- drivers/gpu/drm/virtio/virtgpu_plane.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_pla...

From: Gustavo Padovan <gustavo.padovan at collabora.co.uk> virtio_gpu was failing to send vblank events when using the atomic IOCTL with the DRM_MODE_PAGE_FLIP_EVENT flag set. This patch fixes each and enables atomic pageflips updates. Signed-off-by: Gustavo Padovan <gustavo.padovan at collabora.co.uk> --- drivers/gpu/drm/virtio/virtgpu_display.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b...

From: Gustavo Padovan <gustavo.padovan at collabora.co.uk> virtio_gpu was failing to send vblank events when using the atomic IOCTL with the DRM_MODE_PAGE_FLIP_EVENT flag set. This patch fixes each and enables atomic pageflips updates. Signed-off-by: Gustavo Padovan <gustavo.padovan at collabora.co.uk> --- drivers/gpu/drm/virtio/virtgpu_display.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b...

...igt_pipe_crc_start(pipe_crc); + + for (i = 0; i < n_crcs; i++) { + const int color_idx = i % n_colors; + + igt_plane_set_fb(primary, &colors[color_idx].fb); + do_or_die(drmModePageFlip(data->drm_fd, + output->config.crtc->crtc_id, + colors[color_idx].fb.fb_id, + DRM_MODE_PAGE_FLIP_EVENT, + NULL)); + kmstest_wait_for_pageflip(data->drm_fd); + } + + igt_pipe_crc_get_crcs(pipe_crc, n_crcs, &crcs); + igt_pipe_crc_stop(pipe_crc); + + /* + * Find the first color in our pattern with a CRC that differs from the + * last CRC, so we can use it to find the start of the patter...

...igt_pipe_crc_start(pipe_crc); + + for (i = 0; i < n_crcs; i++) { + const int color_idx = i % n_colors; + + igt_plane_set_fb(primary, &colors[color_idx].fb); + do_or_die(drmModePageFlip(data->drm_fd, + output->config.crtc->crtc_id, + colors[color_idx].fb.fb_id, + DRM_MODE_PAGE_FLIP_EVENT, + NULL)); + kmstest_wait_for_pageflip(data->drm_fd); + } + + igt_pipe_crc_get_crcs(pipe_crc, n_crcs, &crcs); + igt_pipe_crc_stop(pipe_crc); + + /* + * Find the first color in our pattern with a CRC that differs from the + * last CRC, so we can use it to find the start of the patter...

...igt_pipe_crc_start(pipe_crc); + + for (i = 0; i < n_crcs; i++) { + const int color_idx = i % n_colors; + + igt_plane_set_fb(primary, &colors[color_idx].fb); + do_or_die(drmModePageFlip(data->drm_fd, + output->config.crtc->crtc_id, + colors[color_idx].fb.fb_id, + DRM_MODE_PAGE_FLIP_EVENT, + NULL)); + kmstest_wait_for_pageflip(data->drm_fd); + } + + igt_pipe_crc_get_crcs(pipe_crc, n_crcs, &crcs); + igt_pipe_crc_stop(pipe_crc); + + /* + * Find the first color in our pattern with a CRC that differs from the + * last CRC, so we can use it to find the start of the patter...

...igt_pipe_crc_start(pipe_crc); + + for (i = 0; i < n_crcs; i++) { + const int color_idx = i % n_colors; + + igt_plane_set_fb(primary, &colors[color_idx].fb); + do_or_die(drmModePageFlip(data->drm_fd, + output->config.crtc->crtc_id, + colors[color_idx].fb.fb_id, + DRM_MODE_PAGE_FLIP_EVENT, + NULL)); + kmstest_wait_for_pageflip(data->drm_fd); + } + + igt_pipe_crc_get_crcs(pipe_crc, n_crcs, &crcs); + igt_pipe_crc_stop(pipe_crc); + + /* + * Guard against CRC collisions in the color framebuffers by finding the first color in our + * pattern with a CRC that differs from t...

From: Lyude Paul <lyude at redhat.com> Nouveau has finally gotten CRC support, hooray! Well, it's under review at least: https://patchwork.freedesktop.org/series/74804/ (it has a cover letter, but nouveau's mailing list configuration has blocked the email so I'm waiting for a moderator to fix that) So, this series adds the relevant tests for it since nvidia's CRC

...t; > + const int color_idx = i % n_colors; > > + > > + igt_plane_set_fb(primary, &colors[color_idx].fb); > > + do_or_die(drmModePageFlip(data->drm_fd, > > + output->config.crtc->crtc_id, > > + colors[color_idx].fb.fb_id, > > + DRM_MODE_PAGE_FLIP_EVENT, > > + NULL)); > > + kmstest_wait_for_pageflip(data->drm_fd); > > While testing I was experiencing some test failures, at which point I > turned on a bunch of debug logging on the kernel side. This led to this > test reliably failing because this call timed out wa...

...or (i = 0; i < n_crcs; i++) { > + const int color_idx = i % n_colors; > + > + igt_plane_set_fb(primary, &colors[color_idx].fb); > + do_or_die(drmModePageFlip(data->drm_fd, > + output->config.crtc->crtc_id, > + colors[color_idx].fb.fb_id, > + DRM_MODE_PAGE_FLIP_EVENT, > + NULL)); > + kmstest_wait_for_pageflip(data->drm_fd); While testing I was experiencing some test failures, at which point I turned on a bunch of debug logging on the kernel side. This led to this test reliably failing because this call timed out waiting on the pageflip event, w...

From: Lyude Paul <lyude at redhat.com> (Just forwarding this to nouveau's ml, since I completely forgot to before) Nouveau has finally gotten CRC support, hooray! Well, it's under review at least: https://patchwork.freedesktop.org/series/74804/ (it has a cover letter, but nouveau's mailing list configuration has blocked the email so I'm waiting for a moderator to fix that)

From: Lyude Paul <lyude at redhat.com> Nouveau has finally gotten CRC support, hooray! Well, it's under review at least: https://patchwork.freedesktop.org/series/74804/ (it has a cover letter, but nouveau's mailing list configuration has blocked the email so I'm waiting for a moderator to fix that) So, this series adds the relevant tests for it since nvidia's CRC

From: Lyude Paul <lyude at redhat.com> Nouveau has finally gotten CRC support, and at this point that support has made its way upstream. Hooray! So, let's start adding some relevant tests for it since nvidia's CRC implementation has some rather interesting design choices that needed to be worked around. Lyude Paul (5): lib/igt_core: Fix igt_assert_fd() documentation

...on_pipe) lib/igt_kms: Fix indent when try_commit fails. tests/kms_flip: degrade warn to debug tests/kms_busy: Add test to reproduce the CI kms_flip killer igt/meta_test: Add a warn subtest to make sure warnings are caught as expected. tests/kms_atomic: Add test for new DRM_MODE_PAGE_FLIP_EVENT behavior. tests/kms_busy: Remove gem_bo_busy checks tests/kms_cursor_crc: Fix the cursor tests to work on CHV tests/kms_atomic_transitions: Use igt_display_require_output(). tests/debugfs_test: Allow opening CRC to fail with -EIO. tests/kms_atomic_transition: Add test...

Hi, here a set of patches against the nouveau-ddx. This is an extended and revised set, based on Francisco Jerez feedback from autumn last year. [1/9] Makes pageflipping work again on X-Server 1.12rc. It apparently stopped working somewhere around Xorg 1.11+. [2/9] Implements handling of pageflip completion events from the kernel. Francisco Jerez argument against including it was that the

Hi all, First thing first: It works, I now no longer have a few dropped frames every 10s on my testbox here with the pageflip i-g-t tests. Random notes: - New design has per-crtc locks to protect the crtc input-side (pageflip, cursor) for r/w and the output state of the crtc (mode, dpms) as read-only. It also required completely revamped fb lifecycle management, those are now refcounted