search for: drm_mode_cursor_universal

...me if > > you could fix that up. Atomic drivers really shouldn't use the legacy > > cursor interfaces any more at all. > > -Daniel > > Figured that one for the most part, see attached draft. > > The only thing I'm wondering is how the hotspot is handled. > drm_mode_cursor_universal doesn't even look at req->hot_{x,y}. > > /me looks confused. No need to, you're simply the first virtual driver to wire up atomic cursors. Hence some gaps to be filled out. First we need to wire up the state tracking scaffolding for atomic: - add hot_x/y to drm_plane_state - add...

...me if > > you could fix that up. Atomic drivers really shouldn't use the legacy > > cursor interfaces any more at all. > > -Daniel > > Figured that one for the most part, see attached draft. > > The only thing I'm wondering is how the hotspot is handled. > drm_mode_cursor_universal doesn't even look at req->hot_{x,y}. > > /me looks confused. No need to, you're simply the first virtual driver to wire up atomic cursors. Hence some gaps to be filled out. First we need to wire up the state tracking scaffolding for atomic: - add hot_x/y to drm_plane_state - add...

...on't exist yet) and then attach those props to the cursor. We > > don't want those props everywhere, but only on drivers that support/need > > them, aka virtual hw. > > Hmm, why is this special to virtual hw? > > > if (crtc->cursor) { > > - ret = drm_mode_cursor_universal(crtc, req, file_priv); > > + if (drm_core_check_feature(DRIVER_ATOMIC)) > > + ret = drm_mode_cursor_atomic(crtc, req, file_priv); > > + else > > + ret = drm_mode_cursor_universal(crtc, req, file_priv); > > goto out; > > > drm_mode_cursor_atomic wou...

...on't exist yet) and then attach those props to the cursor. We > > don't want those props everywhere, but only on drivers that support/need > > them, aka virtual hw. > > Hmm, why is this special to virtual hw? > > > if (crtc->cursor) { > > - ret = drm_mode_cursor_universal(crtc, req, file_priv); > > + if (drm_core_check_feature(DRIVER_ATOMIC)) > > + ret = drm_mode_cursor_atomic(crtc, req, file_priv); > > + else > > + ret = drm_mode_cursor_universal(crtc, req, file_priv); > > goto out; > > > drm_mode_cursor_atomic wou...

...te the properties > (if they don't exist yet) and then attach those props to the cursor. We > don't want those props everywhere, but only on drivers that support/need > them, aka virtual hw. Hmm, why is this special to virtual hw? > if (crtc->cursor) { > - ret = drm_mode_cursor_universal(crtc, req, file_priv); > + if (drm_core_check_feature(DRIVER_ATOMIC)) > + ret = drm_mode_cursor_atomic(crtc, req, file_priv); > + else > + ret = drm_mode_cursor_universal(crtc, req, file_priv); > goto out; > drm_mode_cursor_atomic would simply be a fusing of > drm...

...Not tainted 4.10.5-1001.fc24.x86_64 #1 ... Call Trace: drm_atomic_helper_wait_for_fences+0x48/0x120 [drm_kms_helper] nv50_disp_atomic_commit+0x19c/0x2a0 [nouveau] drm_atomic_commit+0x4b/0x50 [drm] drm_atomic_helper_update_plane+0xec/0x150 [drm_kms_helper] __setplane_internal+0x1b4/0x280 [drm] drm_mode_cursor_universal+0x126/0x210 [drm] drm_mode_cursor_common+0x86/0x180 [drm] drm_mode_cursor_ioctl+0x50/0x70 [drm] drm_ioctl+0x21b/0x4c0 [drm] ? drm_mode_setplane+0x1a0/0x1a0 [drm] nouveau_drm_ioctl+0x74/0xc0 [nouveau] do_vfs_ioctl+0xa3/0x5f0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x1a/0xa9 ... RIP: dm...

..._tail+0x67/0x70 [drm_kms_helper] [354073.738378] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] [354073.738390] drm_atomic_commit+0x4a/0x50 [drm] [354073.738394] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] [354073.738402] __setplane_atomic+0xd3/0x120 [drm] [354073.738410] drm_mode_cursor_universal+0x142/0x270 [drm] [354073.738418] drm_mode_cursor_common+0xcb/0x220 [drm] [354073.738425] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] [354073.738432] drm_mode_cursor2_ioctl+0xe/0x10 [drm] [354073.738438] drm_ioctl_kernel+0xb0/0x100 [drm] [354073.738440] ? ___sys_recvmsg+0x16c/0x200 [354073.738445]...

..._tail+0x67/0x70 [drm_kms_helper] [354073.738378] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] [354073.738390] drm_atomic_commit+0x4a/0x50 [drm] [354073.738394] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] [354073.738402] __setplane_atomic+0xd3/0x120 [drm] [354073.738410] drm_mode_cursor_universal+0x142/0x270 [drm] [354073.738418] drm_mode_cursor_common+0xcb/0x220 [drm] [354073.738425] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] [354073.738432] drm_mode_cursor2_ioctl+0xe/0x10 [drm] [354073.738438] drm_ioctl_kernel+0xb0/0x100 [drm] [354073.738440] ? ___sys_recvmsg+0x16c/0x200 [354073.738445]...

On 05.09.19 10:14, Gerd Hoffmann wrote: > On Tue, Aug 06, 2019 at 09:00:10PM +0300, Jaak Ristioja wrote: >> Hello! >> >> I'm writing to report a crash in the QXL / DRM code in the Linux kernel. >> I originally filed the issue on LaunchPad and more details can be found >> there, although I doubt whether these details are useful. > > Any change with kernel

On 05.09.19 10:14, Gerd Hoffmann wrote: > On Tue, Aug 06, 2019 at 09:00:10PM +0300, Jaak Ristioja wrote: >> Hello! >> >> I'm writing to report a crash in the QXL / DRM code in the Linux kernel. >> I originally filed the issue on LaunchPad and more details can be found >> there, although I doubt whether these details are useful. > > Any change with kernel

...rm_kms_helper] drm_atomic_helper_commit_tail+0x2b/0x70 [drm_kms_helper] commit_tail+0x67/0x70 [drm_kms_helper] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] drm_atomic_commit+0x4a/0x50 [drm] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] __setplane_atomic+0xd6/0x120 [drm] drm_mode_cursor_universal+0x145/0x270 [drm] drm_mode_cursor_common+0x18f/0x200 [drm] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] drm_mode_cursor2_ioctl+0xe/0x10 [drm] drm_ioctl_kernel+0xad/0xf0 [drm] ? ___sys_recvmsg+0x16c/0x200 drm_ioctl+0x233/0x410 [drm] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] ? ep_scan_ready_list.con...

...rm_kms_helper] drm_atomic_helper_commit_tail+0x2b/0x70 [drm_kms_helper] commit_tail+0x67/0x70 [drm_kms_helper] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] drm_atomic_commit+0x4a/0x50 [drm] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] __setplane_atomic+0xd6/0x120 [drm] drm_mode_cursor_universal+0x145/0x270 [drm] drm_mode_cursor_common+0x18f/0x200 [drm] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] drm_mode_cursor2_ioctl+0xe/0x10 [drm] drm_ioctl_kernel+0xad/0xf0 [drm] ? ___sys_recvmsg+0x16c/0x200 drm_ioctl+0x233/0x410 [drm] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] ? ep_scan_ready_list.con...

...o/virtgpu_display.c:332) [ 37.725835] commit_tail (linux/drivers/gpu/drm/drm_atomic_helper.c:1612) [ 37.726204] drm_atomic_helper_commit (linux/drivers/gpu/drm/drm_atomic_helper.c:1824) [ 37.726729] drm_atomic_helper_update_plane (linux/drivers/gpu/drm/drm_atomic_helper.c:2858) [ 37.727391] drm_mode_cursor_universal (linux/drivers/gpu/drm/drm_plane.c:909) [...] [ 37.729585] drm_mode_cursor_common (linux/drivers/gpu/drm/drm_plane.c:995) [...] [ 37.731491] drm_ioctl_kernel (linux/drivers/gpu/drm/drm_ioctl.c:792) [...] [ 37.733510] drm_ioctl (linux/./include/linux/uaccess.h:152 linux/drivers/gpu/drm/drm_ioc...

On Mon, Mar 30, 2015 at 4:49 PM, Daniel Vetter <daniel at ffwll.ch> wrote: > On Mon, Mar 30, 2015 at 02:23:47PM +0200, Gerd Hoffmann wrote: >> > > Signed-off-by: Dave Airlie <airlied at redhat.com> >> > > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> >> > >> > Standard request from my side for new drm drivers (especially if

On Mon, Mar 30, 2015 at 4:49 PM, Daniel Vetter <daniel at ffwll.ch> wrote: > On Mon, Mar 30, 2015 at 02:23:47PM +0200, Gerd Hoffmann wrote: >> > > Signed-off-by: Dave Airlie <airlied at redhat.com> >> > > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> >> > >> > Standard request from my side for new drm drivers (especially if

..._tail+0x68/0x70 [drm_kms_helper] [124212.551395] drm_atomic_helper_commit+0x118/0x120 [drm_kms_helper] [124212.551407] drm_atomic_commit+0x4a/0x50 [drm] [124212.551411] drm_atomic_helper_update_plane+0xea/0x100 [drm_kms_helper] [124212.551418] __setplane_atomic+0xcb/0x110 [drm] [124212.551428] drm_mode_cursor_universal+0x140/0x260 [drm] [124212.551435] drm_mode_cursor_common+0xcc/0x220 [drm] [124212.551441] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] [124212.551447] drm_mode_cursor2_ioctl+0xe/0x10 [drm] [124212.551452] drm_ioctl_kernel+0xae/0xf0 [drm] [124212.551458] drm_ioctl+0x234/0x3d0 [drm] [124212.551464]...

...helper] > [124212.551395] drm_atomic_helper_commit+0x118/0x120 [drm_kms_helper] > [124212.551407] drm_atomic_commit+0x4a/0x50 [drm] > [124212.551411] drm_atomic_helper_update_plane+0xea/0x100 [drm_kms_helper] > [124212.551418] __setplane_atomic+0xcb/0x110 [drm] > [124212.551428] drm_mode_cursor_universal+0x140/0x260 [drm] > [124212.551435] drm_mode_cursor_common+0xcc/0x220 [drm] > [124212.551441] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] > [124212.551447] drm_mode_cursor2_ioctl+0xe/0x10 [drm] > [124212.551452] drm_ioctl_kernel+0xae/0xf0 [drm] > [124212.551458] drm_ioctl+0x234/0x3d...

...helper] > [354073.738378] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] > [354073.738390] drm_atomic_commit+0x4a/0x50 [drm] > [354073.738394] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] > [354073.738402] __setplane_atomic+0xd3/0x120 [drm] > [354073.738410] drm_mode_cursor_universal+0x142/0x270 [drm] > [354073.738418] drm_mode_cursor_common+0xcb/0x220 [drm] > [354073.738425] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] > [354073.738432] drm_mode_cursor2_ioctl+0xe/0x10 [drm] > [354073.738438] drm_ioctl_kernel+0xb0/0x100 [drm] > [354073.738440] ? ___sys_recvmsg+0x...

...helper] > [354073.738378] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] > [354073.738390] drm_atomic_commit+0x4a/0x50 [drm] > [354073.738394] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] > [354073.738402] __setplane_atomic+0xd3/0x120 [drm] > [354073.738410] drm_mode_cursor_universal+0x142/0x270 [drm] > [354073.738418] drm_mode_cursor_common+0xcb/0x220 [drm] > [354073.738425] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] > [354073.738432] drm_mode_cursor2_ioctl+0xe/0x10 [drm] > [354073.738438] drm_ioctl_kernel+0xb0/0x100 [drm] > [354073.738440] ? ___sys_recvmsg+0x...

..._atomic_get_crtc_state+0x1be/0x3d0 (drivers/gpu/drm/drm_atomic.c:264) drm_atomic_get_plane_state+0x2a5/0x3e0 (drivers/gpu/drm/drm_atomic.c:679) drm_atomic_helper_update_plane+0x10b/0x3b0 (drivers/gpu/drm/drm_atomic_helper.c:2089) __setplane_internal+0x417/0x950 (drivers/gpu/drm/drm_plane.c:457) drm_mode_cursor_universal+0x397/0xb30 (drivers/gpu/drm/drm_plane.c:599) drm_mode_cursor_common+0x173/0x750 (drivers/gpu/drm/drm_plane.c:675) drm_mode_cursor_ioctl+0x90/0xb0 (drivers/gpu/drm/drm_plane.c:733) drm_ioctl+0x4b0/0xba0 (drivers/gpu/drm/drm_ioctl.c:657) nouveau_drm_ioctl+0xf9/0x1e0 [nouveau] (drivers/gpu/drm/no...