search for: drm_mode_cursor_common

...ll Trace: drm_atomic_helper_wait_for_fences+0x48/0x120 [drm_kms_helper] nv50_disp_atomic_commit+0x19c/0x2a0 [nouveau] drm_atomic_commit+0x4b/0x50 [drm] drm_atomic_helper_update_plane+0xec/0x150 [drm_kms_helper] __setplane_internal+0x1b4/0x280 [drm] drm_mode_cursor_universal+0x126/0x210 [drm] drm_mode_cursor_common+0x86/0x180 [drm] drm_mode_cursor_ioctl+0x50/0x70 [drm] drm_ioctl+0x21b/0x4c0 [drm] ? drm_mode_setplane+0x1a0/0x1a0 [drm] nouveau_drm_ioctl+0x74/0xc0 [nouveau] do_vfs_ioctl+0xa3/0x5f0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x1a/0xa9 ... RIP: dma_fence_wait_timeout+0x36/0xf0 RSP: ffffc1...

...eference_protected() usage! [ 37.708899] [ 37.708899] other info that might help us debug this: [ 37.708899] [ 37.709856] [ 37.709856] rcu_scheduler_active = 2, debug_locks = 1 [ 37.710771] 3 locks held by Xorg/1869: [ 37.711266] #0: ffff8880a976fa48 (crtc_ww_class_acquire){+.+.}, at: drm_mode_cursor_common (linux/drivers/gpu/drm/drm_plane.c:949) [ 37.712372] #1: ffff8880b32e00a8 (crtc_ww_class_mutex){+.+.}, at: drm_modeset_lock (linux/drivers/gpu/drm/drm_modeset_lock.c:258 linux/drivers/gpu/drm/drm_modeset_lock.c:342 linux/drivers/gpu/drm/drm_modeset_lock.c:338) [ 37.713415] #2: ffff8880b32eb6c0...

...helper_commit+0x113/0x120 [drm_kms_helper] [354073.738390] drm_atomic_commit+0x4a/0x50 [drm] [354073.738394] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] [354073.738402] __setplane_atomic+0xd3/0x120 [drm] [354073.738410] drm_mode_cursor_universal+0x142/0x270 [drm] [354073.738418] drm_mode_cursor_common+0xcb/0x220 [drm] [354073.738425] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] [354073.738432] drm_mode_cursor2_ioctl+0xe/0x10 [drm] [354073.738438] drm_ioctl_kernel+0xb0/0x100 [drm] [354073.738440] ? ___sys_recvmsg+0x16c/0x200 [354073.738445] drm_ioctl+0x233/0x410 [drm] [354073.738452] ? drm_mode_...

...helper_commit+0x113/0x120 [drm_kms_helper] [354073.738390] drm_atomic_commit+0x4a/0x50 [drm] [354073.738394] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] [354073.738402] __setplane_atomic+0xd3/0x120 [drm] [354073.738410] drm_mode_cursor_universal+0x142/0x270 [drm] [354073.738418] drm_mode_cursor_common+0xcb/0x220 [drm] [354073.738425] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] [354073.738432] drm_mode_cursor2_ioctl+0xe/0x10 [drm] [354073.738438] drm_ioctl_kernel+0xb0/0x100 [drm] [354073.738440] ? ___sys_recvmsg+0x16c/0x200 [354073.738445] drm_ioctl+0x233/0x410 [drm] [354073.738452] ? drm_mode_...

On 05.09.19 10:14, Gerd Hoffmann wrote: > On Tue, Aug 06, 2019 at 09:00:10PM +0300, Jaak Ristioja wrote: >> Hello! >> >> I'm writing to report a crash in the QXL / DRM code in the Linux kernel. >> I originally filed the issue on LaunchPad and more details can be found >> there, although I doubt whether these details are useful. > > Any change with kernel

On 05.09.19 10:14, Gerd Hoffmann wrote: > On Tue, Aug 06, 2019 at 09:00:10PM +0300, Jaak Ristioja wrote: >> Hello! >> >> I'm writing to report a crash in the QXL / DRM code in the Linux kernel. >> I originally filed the issue on LaunchPad and more details can be found >> there, although I doubt whether these details are useful. > > Any change with kernel

...+0x2b/0x70 [drm_kms_helper] commit_tail+0x67/0x70 [drm_kms_helper] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] drm_atomic_commit+0x4a/0x50 [drm] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] __setplane_atomic+0xd6/0x120 [drm] drm_mode_cursor_universal+0x145/0x270 [drm] drm_mode_cursor_common+0x18f/0x200 [drm] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] drm_mode_cursor2_ioctl+0xe/0x10 [drm] drm_ioctl_kernel+0xad/0xf0 [drm] ? ___sys_recvmsg+0x16c/0x200 drm_ioctl+0x233/0x410 [drm] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] ? ep_scan_ready_list.constprop.23+0x1f0/0x200 do_vfs_ioctl+0xa9/0...

...+0x2b/0x70 [drm_kms_helper] commit_tail+0x67/0x70 [drm_kms_helper] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] drm_atomic_commit+0x4a/0x50 [drm] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] __setplane_atomic+0xd6/0x120 [drm] drm_mode_cursor_universal+0x145/0x270 [drm] drm_mode_cursor_common+0x18f/0x200 [drm] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] drm_mode_cursor2_ioctl+0xe/0x10 [drm] drm_ioctl_kernel+0xad/0xf0 [drm] ? ___sys_recvmsg+0x16c/0x200 drm_ioctl+0x233/0x410 [drm] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] ? ep_scan_ready_list.constprop.23+0x1f0/0x200 do_vfs_ioctl+0xa9/0...

...helper_commit+0x118/0x120 [drm_kms_helper] [124212.551407] drm_atomic_commit+0x4a/0x50 [drm] [124212.551411] drm_atomic_helper_update_plane+0xea/0x100 [drm_kms_helper] [124212.551418] __setplane_atomic+0xcb/0x110 [drm] [124212.551428] drm_mode_cursor_universal+0x140/0x260 [drm] [124212.551435] drm_mode_cursor_common+0xcc/0x220 [drm] [124212.551441] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] [124212.551447] drm_mode_cursor2_ioctl+0xe/0x10 [drm] [124212.551452] drm_ioctl_kernel+0xae/0xf0 [drm] [124212.551458] drm_ioctl+0x234/0x3d0 [drm] [124212.551464] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] [124212.551466] ?...

...[drm_kms_helper] > [124212.551407] drm_atomic_commit+0x4a/0x50 [drm] > [124212.551411] drm_atomic_helper_update_plane+0xea/0x100 [drm_kms_helper] > [124212.551418] __setplane_atomic+0xcb/0x110 [drm] > [124212.551428] drm_mode_cursor_universal+0x140/0x260 [drm] > [124212.551435] drm_mode_cursor_common+0xcc/0x220 [drm] > [124212.551441] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] > [124212.551447] drm_mode_cursor2_ioctl+0xe/0x10 [drm] > [124212.551452] drm_ioctl_kernel+0xae/0xf0 [drm] > [124212.551458] drm_ioctl+0x234/0x3d0 [drm] > [124212.551464] ? drm_mode_cursor_ioctl+0x60/0x60...

...[drm_kms_helper] > [354073.738390] drm_atomic_commit+0x4a/0x50 [drm] > [354073.738394] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] > [354073.738402] __setplane_atomic+0xd3/0x120 [drm] > [354073.738410] drm_mode_cursor_universal+0x142/0x270 [drm] > [354073.738418] drm_mode_cursor_common+0xcb/0x220 [drm] > [354073.738425] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] > [354073.738432] drm_mode_cursor2_ioctl+0xe/0x10 [drm] > [354073.738438] drm_ioctl_kernel+0xb0/0x100 [drm] > [354073.738440] ? ___sys_recvmsg+0x16c/0x200 > [354073.738445] drm_ioctl+0x233/0x410 [drm] &gt...

...[drm_kms_helper] > [354073.738390] drm_atomic_commit+0x4a/0x50 [drm] > [354073.738394] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] > [354073.738402] __setplane_atomic+0xd3/0x120 [drm] > [354073.738410] drm_mode_cursor_universal+0x142/0x270 [drm] > [354073.738418] drm_mode_cursor_common+0xcb/0x220 [drm] > [354073.738425] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] > [354073.738432] drm_mode_cursor2_ioctl+0xe/0x10 [drm] > [354073.738438] drm_ioctl_kernel+0xb0/0x100 [drm] > [354073.738440] ? ___sys_recvmsg+0x16c/0x200 > [354073.738445] drm_ioctl+0x233/0x410 [drm] &gt...

...m_atomic_get_plane_state+0x2a5/0x3e0 (drivers/gpu/drm/drm_atomic.c:679) drm_atomic_helper_update_plane+0x10b/0x3b0 (drivers/gpu/drm/drm_atomic_helper.c:2089) __setplane_internal+0x417/0x950 (drivers/gpu/drm/drm_plane.c:457) drm_mode_cursor_universal+0x397/0xb30 (drivers/gpu/drm/drm_plane.c:599) drm_mode_cursor_common+0x173/0x750 (drivers/gpu/drm/drm_plane.c:675) drm_mode_cursor_ioctl+0x90/0xb0 (drivers/gpu/drm/drm_plane.c:733) drm_ioctl+0x4b0/0xba0 (drivers/gpu/drm/drm_ioctl.c:657) nouveau_drm_ioctl+0xf9/0x1e0 [nouveau] (drivers/gpu/drm/nouveau/nouveau_drm.c:925) do_vfs_ioctl+0x184/0xff0 (fs/ioctl.c:624) S...

...t; [354073.738390] drm_atomic_commit+0x4a/0x50 [drm] > > [354073.738394] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] > > [354073.738402] __setplane_atomic+0xd3/0x120 [drm] > > [354073.738410] drm_mode_cursor_universal+0x142/0x270 [drm] > > [354073.738418] drm_mode_cursor_common+0xcb/0x220 [drm] > > [354073.738425] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] > > [354073.738432] drm_mode_cursor2_ioctl+0xe/0x10 [drm] > > [354073.738438] drm_ioctl_kernel+0xb0/0x100 [drm] > > [354073.738440] ? ___sys_recvmsg+0x16c/0x200 > > [354073.738445] drm_io...

...for userspace for legacy applications. For that we need a notch more: - one option would be to add hot_x/hot_y to the ->update_plane hook, but that has massive trickling effects throughout the subsystem. Probably not what we want to do. - 2nd option would be to add a DRIVER_ATOMIC check to drm_mode_cursor_common and call a new drm_mode_cursor_atomic in that case: diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 3e52a6ecf6c0..2f15ce2c6bf4 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -3046,7 +3046,10 @@ static int drm_mode_cursor_common(struct drm_d...

...for userspace for legacy applications. For that we need a notch more: - one option would be to add hot_x/hot_y to the ->update_plane hook, but that has massive trickling effects throughout the subsystem. Probably not what we want to do. - 2nd option would be to add a DRIVER_ATOMIC check to drm_mode_cursor_common and call a new drm_mode_cursor_atomic in that case: diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 3e52a6ecf6c0..2f15ce2c6bf4 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -3046,7 +3046,10 @@ static int drm_mode_cursor_common(struct drm_d...

On Mon, Mar 30, 2015 at 4:49 PM, Daniel Vetter <daniel at ffwll.ch> wrote: > On Mon, Mar 30, 2015 at 02:23:47PM +0200, Gerd Hoffmann wrote: >> > > Signed-off-by: Dave Airlie <airlied at redhat.com> >> > > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> >> > >> > Standard request from my side for new drm drivers (especially if

On Mon, Mar 30, 2015 at 4:49 PM, Daniel Vetter <daniel at ffwll.ch> wrote: > On Mon, Mar 30, 2015 at 02:23:47PM +0200, Gerd Hoffmann wrote: >> > > Signed-off-by: Dave Airlie <airlied at redhat.com> >> > > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> >> > >> > Standard request from my side for new drm drivers (especially if

...7] nv50_disp_atomic_commit+0x18e/0x290 [nouveau] [ 211.555643] drm_atomic_helper_update_plane+0xeb/0x150 [drm_kms_helper] [ 211.555690] __setplane_internal+0x1d9/0x2a0 [drm] [ 211.555718] ? enqueue_entity+0x110/0x6d0 [ 211.555754] drm_mode_cursor_universal+0x10b/0x1e0 [drm] [ 211.555792] drm_mode_cursor_common+0x80/0x170 [drm] [ 211.555829] drm_mode_cursor_ioctl+0x44/0x50 [drm] [ 211.555866] drm_ioctl+0x1ec/0x410 [drm] [ 211.555903] ? drm_mode_setplane+0x1a0/0x1a0 [drm] [ 211.555980] nouveau_drm_ioctl+0x66/0xc0 [nouveau] [ 211.556010] do_vfs_ioctl+0x8f/0x5d0 [ 211.556036] ? __fget+0x70/0xc0 [...

...v50_disp_atomic_commit+0x1c8/0x2d0 [nouveau] [ 194.270714] drm_atomic_commit+0x4b/0x50 [drm] [ 194.270724] drm_atomic_helper_update_plane+0xec/0x150 [drm_kms_helper] [ 194.270740] __setplane_internal+0x1b7/0x280 [drm] [ 194.270755] drm_mode_cursor_universal+0x126/0x210 [drm] [ 194.270770] drm_mode_cursor_common+0x89/0x180 [drm] [ 194.270784] drm_mode_cursor_ioctl+0x50/0x70 [drm] [ 194.270797] drm_ioctl+0x37a/0x4e0 [drm] [ 194.270804] ? sched_clock_cpu+0xa7/0xc0 [ 194.270817] ? drm_mode_setplane+0x1b0/0x1b0 [drm] [ 194.270825] ? trace_hardirqs_on_caller+0xf5/0x1b0 [ 194.270831] ? trace_hardirqs...