search for: drm_mode_connector_attach_encod

From: Colin Ian King <colin.king at canonical.com> The null check on the array msto is incorrect since msto is never null. The null check should be instead on msto[i] since this is being dereferenced in the call to drm_mode_connector_attach_encoder. Thanks to Emil Velikov for pointing out the mistake in my original fix and for suggesting the correct fix. Detected by CoverityScan, CID#1375915 ("Array compared against 0") Fixes: f479c0ba4a17 ("drm/nouveau/kms/nv50: initial support for DP 1.2 multi-stream") Signed-off-by...

....king at canonical.com> wrote: >> From: Colin Ian King <colin.king at canonical.com> >> >> The null check on the array msto is incorrect since msto is never >> null. The null check should be instead on msto[i] since this is >> being dereferenced in the call to drm_mode_connector_attach_encoder. >> >> Thanks to Emil Velikov for pointing out the mistake in my original >> fix and for suggesting the correct fix. >> >> Detected by CoverityScan, CID#1375915 ("Array compared against 0") >> >> Fixes: f479c0ba4a17 ("drm/nouveau/kms/nv50:...

...mstm *mstm, struct drm_dp_mst_port *port, mstc->connector.funcs->reset(&mstc->connector); nouveau_conn_attach_properties(&mstc->connector); - for (i = 0; i < ARRAY_SIZE(mstm->msto) && mstm->msto; i++) + for (i = 0; i < ARRAY_SIZE(mstm->msto); i++) drm_mode_connector_attach_encoder(&mstc->connector, &mstm->msto[i]->encoder); drm_object_attach_property(&mstc->connector.base, dev->mode_config.path_property, 0); -- 2.11.0

...Colin King <colin.king at canonical.com> wrote: > From: Colin Ian King <colin.king at canonical.com> > > The null check on the array msto is incorrect since msto is never > null. The null check should be instead on msto[i] since this is > being dereferenced in the call to drm_mode_connector_attach_encoder. > > Thanks to Emil Velikov for pointing out the mistake in my original > fix and for suggesting the correct fix. > > Detected by CoverityScan, CID#1375915 ("Array compared against 0") > > Fixes: f479c0ba4a17 ("drm/nouveau/kms/nv50: initial support for DP 1.2 m...

...om> wrote: >>> From: Colin Ian King <colin.king at canonical.com> >>> >>> The null check on the array msto is incorrect since msto is never >>> null. The null check should be instead on msto[i] since this is >>> being dereferenced in the call to drm_mode_connector_attach_encoder. >>> >>> Thanks to Emil Velikov for pointing out the mistake in my original >>> fix and for suggesting the correct fix. >>> >>> Detected by CoverityScan, CID#1375915 ("Array compared against 0") >>> >>> Fixes: f479c0ba4a17 (...

The patches contain some tidy-up work, and refactoring that has arisen as a by-product of my initial work on adding TV support to nv50. Joel Holdsworth (4): drm/nouveau: Removed unneeded include in nvc0_fence.c drm/nouveau: Replaced magic numbers with defines from nouveau_reg drm/nouveau: Replaced copy-pasted nv_wait with nv50_wait_dpms_ctrl helper drm/nouveau: Refactored encoder

...properties(&mstc->connector); 3157 3158 for (i = 0; i < ARRAY_SIZE(mstm->msto) && mstm->msto; i++) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This doesn't make sense. Maybe mstm->msto[i] was intended?? 3159 drm_mode_connector_attach_encoder(&mstc->connector, &mstm->msto[i]->encoder); 3160 3161 drm_object_attach_property(&mstc->connector.base, dev->mode_config.path_property, 0); 3162 drm_object_attach_property(&mstc->connector.base, dev->mode_config.tile_property, 0); 3...

...r); > > - for (i = 0; i < ARRAY_SIZE(mstm->msto) && mstm->msto; i++) > + for (i = 0; i < ARRAY_SIZE(mstm->msto); i++) I think that should be mstm->msto[i]. After all we are dereferencing the pointer, so we don't want to crash. > drm_mode_connector_attach_encoder(&mstc->connector, &mstm->msto[i]->encoder); -Emil

...+ drm_connector_init(dev, connector, &virtio_gpu_connector_funcs, + DRM_MODE_CONNECTOR_VIRTUAL); + connector->polled = DRM_CONNECTOR_POLL_HPD; + drm_encoder_init(dev, encoder, &virtio_gpu_enc_funcs, + DRM_MODE_ENCODER_VIRTUAL); + + encoder->possible_crtcs = 1 << index; + drm_mode_connector_attach_encoder(connector, encoder); + drm_encoder_helper_add(encoder, &virtio_gpu_enc_helper_funcs); + drm_connector_helper_add(connector, &virtio_gpu_conn_helper_funcs); + drm_connector_register(connector); + return 0; +} + +static struct drm_framebuffer * +virtio_gpu_user_framebuffer_create(struct drm...

...+ drm_connector_init(dev, connector, &virtio_gpu_connector_funcs, + DRM_MODE_CONNECTOR_VIRTUAL); + connector->polled = DRM_CONNECTOR_POLL_HPD; + drm_encoder_init(dev, encoder, &virtio_gpu_enc_funcs, + DRM_MODE_ENCODER_VIRTUAL); + + encoder->possible_crtcs = 1 << index; + drm_mode_connector_attach_encoder(connector, encoder); + drm_encoder_helper_add(encoder, &virtio_gpu_enc_helper_funcs); + drm_connector_helper_add(connector, &virtio_gpu_conn_helper_funcs); + drm_connector_register(connector); + return 0; +} + +static struct drm_framebuffer * +virtio_gpu_user_framebuffer_create(struct drm...

..., &virtio_gpu_connector_funcs, > + DRM_MODE_CONNECTOR_VIRTUAL); > + connector->polled = DRM_CONNECTOR_POLL_HPD; > + drm_encoder_init(dev, encoder, &virtio_gpu_enc_funcs, > + DRM_MODE_ENCODER_VIRTUAL); > + > + encoder->possible_crtcs = 1 << index; > + drm_mode_connector_attach_encoder(connector, encoder); > + drm_encoder_helper_add(encoder, &virtio_gpu_enc_helper_funcs); > + drm_connector_helper_add(connector, &virtio_gpu_conn_helper_funcs); > + drm_connector_register(connector); > + return 0; > +} > + > +static struct drm_framebuffer * > +virti...

..., &virtio_gpu_connector_funcs, > + DRM_MODE_CONNECTOR_VIRTUAL); > + connector->polled = DRM_CONNECTOR_POLL_HPD; > + drm_encoder_init(dev, encoder, &virtio_gpu_enc_funcs, > + DRM_MODE_ENCODER_VIRTUAL); > + > + encoder->possible_crtcs = 1 << index; > + drm_mode_connector_attach_encoder(connector, encoder); > + drm_encoder_helper_add(encoder, &virtio_gpu_enc_helper_funcs); > + drm_connector_helper_add(connector, &virtio_gpu_conn_helper_funcs); > + drm_connector_register(connector); > + return 0; > +} > + > +static struct drm_framebuffer * > +virti...

...VIRTUAL); + drm_connector_helper_add(connector, &virtio_gpu_conn_helper_funcs); + + drm_encoder_init(dev, encoder, &virtio_gpu_enc_funcs, + DRM_MODE_ENCODER_VIRTUAL); + drm_encoder_helper_add(encoder, &virtio_gpu_enc_helper_funcs); + encoder->possible_crtcs = 1 << index; + + drm_mode_connector_attach_encoder(connector, encoder); + drm_connector_register(connector); + return 0; +} + +static struct drm_framebuffer * +virtio_gpu_user_framebuffer_create(struct drm_device *dev, + struct drm_file *file_priv, + struct drm_mode_fb_cmd2 *mode_cmd) +{ + struct drm_gem_object *obj = NULL; + struct v...

...VIRTUAL); + drm_connector_helper_add(connector, &virtio_gpu_conn_helper_funcs); + + drm_encoder_init(dev, encoder, &virtio_gpu_enc_funcs, + DRM_MODE_ENCODER_VIRTUAL); + drm_encoder_helper_add(encoder, &virtio_gpu_enc_helper_funcs); + encoder->possible_crtcs = 1 << index; + + drm_mode_connector_attach_encoder(connector, encoder); + drm_connector_register(connector); + return 0; +} + +static struct drm_framebuffer * +virtio_gpu_user_framebuffer_create(struct drm_device *dev, + struct drm_file *file_priv, + struct drm_mode_fb_cmd2 *mode_cmd) +{ + struct drm_gem_object *obj = NULL; + struct v...

...VIRTUAL); + drm_connector_helper_add(connector, &virtio_gpu_conn_helper_funcs); + + drm_encoder_init(dev, encoder, &virtio_gpu_enc_funcs, + DRM_MODE_ENCODER_VIRTUAL); + drm_encoder_helper_add(encoder, &virtio_gpu_enc_helper_funcs); + encoder->possible_crtcs = 1 << index; + + drm_mode_connector_attach_encoder(connector, encoder); + drm_connector_register(connector); + return 0; +} + +static struct drm_framebuffer * +virtio_gpu_user_framebuffer_create(struct drm_device *dev, + struct drm_file *file_priv, + struct drm_mode_fb_cmd2 *mode_cmd) +{ + struct drm_gem_object *obj = NULL; + struct v...

...VIRTUAL); + drm_connector_helper_add(connector, &virtio_gpu_conn_helper_funcs); + + drm_encoder_init(dev, encoder, &virtio_gpu_enc_funcs, + DRM_MODE_ENCODER_VIRTUAL); + drm_encoder_helper_add(encoder, &virtio_gpu_enc_helper_funcs); + encoder->possible_crtcs = 1 << index; + + drm_mode_connector_attach_encoder(connector, encoder); + drm_connector_register(connector); + return 0; +} + +static struct drm_framebuffer * +virtio_gpu_user_framebuffer_create(struct drm_device *dev, + struct drm_file *file_priv, + struct drm_mode_fb_cmd2 *mode_cmd) +{ + struct drm_gem_object *obj = NULL; + struct v...

It seems it was only locking up in the context of nouveau_hw_save_vga_fonts, when it actually did something (because the console wasn't already in graphics mode). Signed-off-by: Francisco Jerez <currojerez at riseup.net> --- drivers/gpu/drm/nouveau/nouveau_hw.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_hw.c

This patch series adds TV-out modesetting support to the KMS implementation. I've tried to test it on all the hardware I've got at hand (that is nv11, nv17, nv34, nv35, nv40, nv4b) with every possible output combination; I believe it has reached a mergeable state, however it depends on some commits from drm-next that haven't got into Linus' tree yet, if you agree to merge this