search for: drm_irq

...ppen when I try to open a new window in KDE Plasma on Arch Linux (though I am not sure of the exact trigger). ================================================================== BUG: KASAN: use-after-free in drm_calc_vbltimestamp_from_scanoutpos+0x625/0x740 at addr ffff880739ecbfb0 (drivers/gpu/drm/drm_irq.c:743) Read of size 4 by task swapper/4/0 CPU: 4 PID: 0 Comm: swapper/4 Not tainted 4.10.9kasan #10 Hardware name: Notebook P65_P67RGRERA/P65_P67RGRERA, BIOS 1.05.16 05/16/2016 Call Trace: <IRQ> dump_stack+0x68/0x96 (lib/dump_stack.c:27) kasan_object_err+0x21/0x70 (...

...gt; Cc: Ben Skeggs <bskeggs at redhat.com> Cc: Ilia Mirkin <imirkin at alum.mit.edu> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com> --- Note that due to lack of hw this is completely untested. But I think it's the right way to fix this. -Daniel --- drivers/gpu/drm/drm_irq.c | 56 ++++++++++++++++++++++++++++++- drivers/gpu/drm/nouveau/nouveau_display.c | 16 ++++----- include/drm/drmP.h | 4 +++ 3 files changed, 66 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index 46dbc34b...

https://bugs.freedesktop.org/show_bug.cgi?id=92852 Bug ID: 92852 Summary: NV34: WARNING: ... at drivers/gpu/drm/drm_irq.c:924 drm_vblank_count_and_time+0x71/0x80 [drm]() Product: xorg Version: unspecified Hardware: x86 (IA32) OS: Linux (All) Status: NEW Severity: major Priority: medium Component: Driver/nouve...

...gt; > Cc: Ilia Mirkin <imirkin at alum.mit.edu> > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com> > --- > > Note that due to lack of hw this is completely untested. But I think > it's the right way to fix this. > -Daniel > --- > drivers/gpu/drm/drm_irq.c | 56 ++++++++++++++++++++++++++++++- > drivers/gpu/drm/nouveau/nouveau_display.c | 16 ++++----- > include/drm/drmP.h | 4 +++ > 3 files changed, 66 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm...

...ble tag per Ilja's advice. Signed-off-by: Daniel Vetter <daniel.vetter at intel.com> (v1) Reviewed-by: Mario Kleiner <mario.kleiner.de at gmail.com> (v2/v3) Signed-off-by: Mario Kleiner <mario.kleiner.de at gmail.com> Cc: stable at vger.kernel.org # v4.3 --- drivers/gpu/drm/drm_irq.c | 54 ++++++++++++++++++++++++++++++- drivers/gpu/drm/nouveau/nouveau_display.c | 19 ++++++----- include/drm/drmP.h | 4 +++ 3 files changed, 68 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index eba6337...

...- Initialize sequence number for queued pageflip event to avoid trouble in drm_handle_vblank_events(). - Remove dead code and spelling fix. Signed-off-by: Daniel Vetter <daniel.vetter at intel.com> Reviewed-by: Mario Kleiner <mario.kleiner.de at gmail.com> --- drivers/gpu/drm/drm_irq.c | 54 ++++++++++++++++++++++++++++++- drivers/gpu/drm/nouveau/nouveau_display.c | 19 ++++++----- include/drm/drmP.h | 4 +++ 3 files changed, 68 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index eba6337...

Hi, > > Signed-off-by: Dave Airlie <airlied at redhat.com> > > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> > > Standard request from my side for new drm drivers (especially if they're > this simple): Can you please update the drivers to latest drm internal > interfaces, i.e. using universal planes and atomic? Up'n'running. Incremental

Hi, > > Signed-off-by: Dave Airlie <airlied at redhat.com> > > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> > > Standard request from my side for new drm drivers (especially if they're > this simple): Can you please update the drivers to latest drm internal > interfaces, i.e. using universal planes and atomic? Up'n'running. Incremental

...Vetter <daniel.vetter at intel.com> >> (v1) Reviewed-by: Mario Kleiner <mario.kleiner.de at gmail.com> >> (v2/v3) Signed-off-by: Mario Kleiner <mario.kleiner.de at gmail.com> >> >> Cc: stable at vger.kernel.org # v4.3 >> --- >> drivers/gpu/drm/drm_irq.c | 54 ++++++++++++++++++++++++++++++- >> drivers/gpu/drm/nouveau/nouveau_display.c | 19 ++++++----- >> include/drm/drmP.h | 4 +++ >> 3 files changed, 68 insertions(+), 9 deletions(-) > > This looks good to me. Let me clean this...

...ut I'll go over the other reviews first. Looking good. Wrt pageflip the current MO is to handroll it in your driver, common approach is to use the msm async commit implementation msm_atomic_commit. The issue is simply that right now there's still no useable generic vblank callback support (drm_irq.c is a mess) hence why the core helpers don't support async flips yet. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

...;> (v1) Reviewed-by: Mario Kleiner <mario.kleiner.de at gmail.com> > >>> (v2/v3) Signed-off-by: Mario Kleiner <mario.kleiner.de at gmail.com> > >>> > >>> Cc: stable at vger.kernel.org # v4.3 > >>> --- > >>> drivers/gpu/drm/drm_irq.c | 54 ++++++++++++++++++++++++++++++- > >>> drivers/gpu/drm/nouveau/nouveau_display.c | 19 ++++++----- > >>> include/drm/drmP.h | 4 +++ > >>> 3 files changed, 68 insertions(+), 9 deletions(-) > >> > >&...

...; Signed-off-by: Daniel Vetter <daniel.vetter at intel.com> > (v1) Reviewed-by: Mario Kleiner <mario.kleiner.de at gmail.com> > (v2/v3) Signed-off-by: Mario Kleiner <mario.kleiner.de at gmail.com> > > Cc: stable at vger.kernel.org # v4.3 > --- > drivers/gpu/drm/drm_irq.c | 54 ++++++++++++++++++++++++++++++- > drivers/gpu/drm/nouveau/nouveau_display.c | 19 ++++++----- > include/drm/drmP.h | 4 +++ > 3 files changed, 68 insertions(+), 9 deletions(-) This looks good to me. Let me clean this up a little and submit i...

On Tue, Sep 23, 2014 at 2:23 AM, Ted Percival <ted at tedp.id.au> wrote: > On 09/22/2014 03:08 AM, Maarten Lankhorst wrote: >> This fixes a regression introduced by "drm/nouveau: rework to new fence interface" >> (commit 29ba89b2371d466). >> >> The fence sequence should not be reset after creation, the old value is used instead. >> On destruction

...> Reviewed-by: Mario Kleiner <mario.kleiner.de at gmail.com> >> Cc: stable at vger.kernel.org # v4.3 >> Signed-off-by: Mario Kleiner <mario.kleiner.de at gmail.com> >> Signed-off-by: Thierry Reding <treding at nvidia.com> >> --- >> drivers/gpu/drm/drm_irq.c | 54 ++++++++++++++++++++++++++++++- >> drivers/gpu/drm/nouveau/nouveau_display.c | 19 ++++++----- >> include/drm/drmP.h | 4 +++ >> 3 files changed, 68 insertions(+), 9 deletions(-) > > Hi Dave, > > It'd be great if yo...

...other reviews first. > > Looking good. Wrt pageflip the current MO is to handroll it in your > driver, common approach is to use the msm async commit implementation > msm_atomic_commit. The issue is simply that right now there's still no > useable generic vblank callback support (drm_irq.c is a mess) hence why > the core helpers don't support async flips yet. I guess I didn't do a good job at looking at your v2: Cursor is still using legacy interfaces and not a proper plane. Would be awesome if you could fix that up. Atomic drivers really shouldn't use the legacy cu...

...other reviews first. > > Looking good. Wrt pageflip the current MO is to handroll it in your > driver, common approach is to use the msm async commit implementation > msm_atomic_commit. The issue is simply that right now there's still no > useable generic vblank callback support (drm_irq.c is a mess) hence why > the core helpers don't support async flips yet. I guess I didn't do a good job at looking at your v2: Cursor is still using legacy interfaces and not a proper plane. Would be awesome if you could fix that up. Atomic drivers really shouldn't use the legacy cu...

...at intel.com> >>> (v1) Reviewed-by: Mario Kleiner <mario.kleiner.de at gmail.com> >>> (v2/v3) Signed-off-by: Mario Kleiner <mario.kleiner.de at gmail.com> >>> >>> Cc: stable at vger.kernel.org # v4.3 >>> --- >>> drivers/gpu/drm/drm_irq.c | 54 ++++++++++++++++++++++++++++++- >>> drivers/gpu/drm/nouveau/nouveau_display.c | 19 ++++++----- >>> include/drm/drmP.h | 4 +++ >>> 3 files changed, 68 insertions(+), 9 deletions(-) >> >> This looks good to me...

...ect.h" diff --git a/drivers/gpu/drm/qxl/qxl_irq.c b/drivers/gpu/drm/qxl/qxl_irq.c index 3bb31add6350..8435af108632 100644 --- a/drivers/gpu/drm/qxl/qxl_irq.c +++ b/drivers/gpu/drm/qxl/qxl_irq.c @@ -23,6 +23,10 @@ * Alon Levy */ +#include <linux/pci.h> + +#include <drm/drm_irq.h> + #include "qxl_drv.h" irqreturn_t qxl_irq_handler(int irq, void *arg) diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c index bee61fa2c9bc..611cbe7aee69 100644 --- a/drivers/gpu/drm/qxl/qxl_kms.c +++ b/drivers/gpu/drm/qxl/qxl_kms.c @@ -23,11 +23,14 @@...

...ect.h" diff --git a/drivers/gpu/drm/qxl/qxl_irq.c b/drivers/gpu/drm/qxl/qxl_irq.c index 3bb31add6350..8435af108632 100644 --- a/drivers/gpu/drm/qxl/qxl_irq.c +++ b/drivers/gpu/drm/qxl/qxl_irq.c @@ -23,6 +23,10 @@ * Alon Levy */ +#include <linux/pci.h> + +#include <drm/drm_irq.h> + #include "qxl_drv.h" irqreturn_t qxl_irq_handler(int irq, void *arg) diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c index bee61fa2c9bc..611cbe7aee69 100644 --- a/drivers/gpu/drm/qxl/qxl_kms.c +++ b/drivers/gpu/drm/qxl/qxl_kms.c @@ -23,11 +23,14 @@...

...can suggest other places to look, or things to look for. thanks in advance! here's an excerpt from journalctl: Jun 30 12:47:49 aspirebox.fcshome.stoneham.ma.us kernel: ------------[ cut here ]------------ Jun 30 12:47:49 aspirebox.fcshome.stoneham.ma.us kernel: WARNING: at drivers/gpu/drm/drm_irq.c:1141 drm_wait_one_vblank+0x19e/0x1b0 [drm]() Jun 30 12:47:49 aspirebox.fcshome.stoneham.ma.us kernel: vblank wait timed out on crtc 1 Jun 30 12:47:49 aspirebox.fcshome.stoneham.ma.us kernel: Modules linked in: rfcomm fuse xt_CHECKSUM ipt_MASQUERADE nf_nat_masquerade_ipv4 tun ccm nf_conntrack_netb...