Displaying 4 results from an estimated 4 matches for "drm_ioctl_mode_getfb2".
2017 Aug 01
0
[PATCH] Add drm ioctl DRM_IOCTL_MODE_GETFB2 & associated helpers.
...My initial reaction to this was to reply that not all drivers use GEM, but
after some investigation it seems they actually do. If that's really the case,
we could get rid of the .create_handle() operation completely, which should
simplify the implementation of both DRM_IOCTL_MODE_GETFB and
DRM_IOCTL_MODE_GETFB2.
> + r->handles[i] = 0;
> + }
> + }
> +
> + drm_framebuffer_unreference(fb);
> +
> + return ret;
> +}
[snip]
> diff --git a/drivers/gpu/drm/omapdrm/omap_fb.c
> b/drivers/gpu/drm/omapdrm/omap_fb.c index 29dc677dd4d3..a982c72a773e 100644
> --- a/drivers/gpu/d...
2017 Aug 01
0
[PATCH] Add drm ioctl DRM_IOCTL_MODE_GETFB2 & associated helpers.
...reply that not all drivers use GEM, but
> > after some investigation it seems they actually do. If that's really the
> > case, we could get rid of the .create_handle() operation completely, which
> > should simplify the implementation of both DRM_IOCTL_MODE_GETFB and
> > DRM_IOCTL_MODE_GETFB2.
>
> Deleting the handle is the same in all cases, but creating the handle
> isn't consistent across the drivers. I didn't see a clean way to simplify
> this.
Creating the handle seems to be fairly consistent, except for a very small
number of special cases. If we stored the...
2017 Aug 01
1
[PATCH] Add drm ioctl DRM_IOCTL_MODE_GETFB2 & associated helpers.
...to this was to reply that not all drivers use GEM, but
> after some investigation it seems they actually do. If that's really the
> case,
> we could get rid of the .create_handle() operation completely, which should
> simplify the implementation of both DRM_IOCTL_MODE_GETFB and
> DRM_IOCTL_MODE_GETFB2.
>
> Deleting the handle is the same in all cases, but creating the handle
isn't consistent across the drivers. I didn't see a clean way to simplify
this.
> > + r->handles[i] = 0;
> > + }
> > + }
> > +
> > + d...
2017 Jul 31
2
[PATCH] Add drm ioctl DRM_IOCTL_MODE_GETFB2 & associated helpers.
...SETPROPERTY, drm_mode_connector_property_set_ioctl, DRM_MASTER|DRM_CONTROL_ALLOW|DRM_UNLOCKED),
DRM_IOCTL_DEF(DRM_IOCTL_MODE_GETPROPBLOB, drm_mode_getblob_ioctl, DRM_CONTROL_ALLOW|DRM_UNLOCKED),
DRM_IOCTL_DEF(DRM_IOCTL_MODE_GETFB, drm_mode_getfb, DRM_CONTROL_ALLOW|DRM_UNLOCKED),
+ DRM_IOCTL_DEF(DRM_IOCTL_MODE_GETFB2, drm_mode_getfb2, DRM_CONTROL_ALLOW|DRM_UNLOCKED),
DRM_IOCTL_DEF(DRM_IOCTL_MODE_ADDFB, drm_mode_addfb, DRM_CONTROL_ALLOW|DRM_UNLOCKED),
DRM_IOCTL_DEF(DRM_IOCTL_MODE_ADDFB2, drm_mode_addfb2, DRM_CONTROL_ALLOW|DRM_UNLOCKED),
DRM_IOCTL_DEF(DRM_IOCTL_MODE_RMFB, drm_mode_rmfb, DRM_CONTROL_ALLOW|DR...