search for: drm_framebuffer_put

...ly set for initialized > framebuffers. The fbdev's clean-up code skips uninitialized framebuffers. > > The memory for struct drm_framebuffer is allocated dynamically. This requires > additional error handling within cirrusfb_create. The framebuffer clean-up is > now performed by drm_framebuffer_put, which also frees the data strcuture's > memory. pushed to drm-misc-next (also the other ones, except the failing ttm_put patches). thanks, Gerd

...au_fb->base.obj[0]) { > - nvbo = nouveau_gem_object(nouveau_fb->base.obj[0]); > + if (fb && fb->obj[0]) { > + nvbo = nouveau_gem_object(fb->obj[0]); > nouveau_vma_del(&fbcon->vma); > nouveau_bo_unmap(nvbo); > nouveau_bo_unpin(nvbo); > - drm_framebuffer_put(&nouveau_fb->base); > + drm_framebuffer_put(fb); > } > > return 0; >

...]); >>> +??? if (fb && fb->obj[0]) { >>> +??????? nvbo = nouveau_gem_object(fb->obj[0]); >>> ????????? nouveau_vma_del(&fbcon->vma); >>> ????????? nouveau_bo_unmap(nvbo); >>> ????????? nouveau_bo_unpin(nvbo); >>> -??????? drm_framebuffer_put(&nouveau_fb->base); >>> +??????? drm_framebuffer_put(fb); >>> ????? } >>> ? ????? return 0; >>> >> _______________________________________________ >> dri-devel mailing list >> dri-devel at lists.freedesktop.org >> https://lists.fr...

...j[0]); >>> +??? if (fb && fb->obj[0]) { >>> +??????? nvbo = nouveau_gem_object(fb->obj[0]); >>> ????????? nouveau_vma_del(&fbcon->vma); >>> ????????? nouveau_bo_unmap(nvbo); >>> ????????? nouveau_bo_unpin(nvbo); >>> -??????? drm_framebuffer_put(&nouveau_fb->base); >>> +??????? drm_framebuffer_put(fb); >>> ????? } >>> ????? return 0; >>> >> _______________________________________________ >> Nouveau mailing list >> Nouveau at lists.freedesktop.org >> https://lists.freedeskto...

...t;obj[0]) { > >>>> + nvbo = nouveau_gem_object(fb->obj[0]); > >>>> nouveau_vma_del(&fbcon->vma); > >>>> nouveau_bo_unmap(nvbo); > >>>> nouveau_bo_unpin(nvbo); > >>>> - drm_framebuffer_put(&nouveau_fb->base); > >>>> + drm_framebuffer_put(fb); > >>>> } > >>>> return 0; > >>>> > >>> _______________________________________________ > >>> dri-devel mailing list > >>&g...

...t; + nvbo = nouveau_gem_object(fb->obj[0]); >>>>>>> nouveau_vma_del(&fbcon->vma); >>>>>>> nouveau_bo_unmap(nvbo); >>>>>>> nouveau_bo_unpin(nvbo); >>>>>>> - drm_framebuffer_put(&nouveau_fb->base); >>>>>>> + drm_framebuffer_put(fb); >>>>>>> } >>>>>>> return 0; >>>>>>> >>>>>> _______________________________________________ >>>>&gt...

...); - if (nouveau_fb && nouveau_fb->base.obj[0]) { - nvbo = nouveau_gem_object(nouveau_fb->base.obj[0]); + if (fb && fb->obj[0]) { + nvbo = nouveau_gem_object(fb->obj[0]); nouveau_vma_del(&fbcon->vma); nouveau_bo_unmap(nvbo); nouveau_bo_unpin(nvbo); - drm_framebuffer_put(&nouveau_fb->base); + drm_framebuffer_put(fb); } return 0; -- 2.25.0

...t(nouveau_fb->base.obj[0]); >> +??? if (fb && fb->obj[0]) { >> +??????? nvbo = nouveau_gem_object(fb->obj[0]); >> ????????? nouveau_vma_del(&fbcon->vma); >> ????????? nouveau_bo_unmap(nvbo); >> ????????? nouveau_bo_unpin(nvbo); >> -??????? drm_framebuffer_put(&nouveau_fb->base); >> +??????? drm_framebuffer_put(fb); >> ????? } >> ????? return 0; >> > _______________________________________________ > Nouveau mailing list > Nouveau at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau

All fields in struct nouveau_framebuffer appear to be obsolete. The data structure can be replaced by struct drm_framebuffer entirely. Patch 1 removes several unused fields from struct nouveau_framebuffer. Patch 2 moves the field vma to struct nouveau_fbdev. The information in vma is only relevant for fbdev emulation, and as such he field is only used there. Patch 3 removes nvbo from struct

...t(nouveau_fb->base.obj[0]); >> +??? if (fb && fb->obj[0]) { >> +??????? nvbo = nouveau_gem_object(fb->obj[0]); >> ????????? nouveau_vma_del(&fbcon->vma); >> ????????? nouveau_bo_unmap(nvbo); >> ????????? nouveau_bo_unpin(nvbo); >> -??????? drm_framebuffer_put(&nouveau_fb->base); >> +??????? drm_framebuffer_put(fb); >> ????? } >> ? ????? return 0; >> > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri...

...? if (fb && fb->obj[0]) { >>>> +??????? nvbo = nouveau_gem_object(fb->obj[0]); >>>> ?????????? nouveau_vma_del(&fbcon->vma); >>>> ?????????? nouveau_bo_unmap(nvbo); >>>> ?????????? nouveau_bo_unpin(nvbo); >>>> -??????? drm_framebuffer_put(&nouveau_fb->base); >>>> +??????? drm_framebuffer_put(fb); >>>> ?????? } >>>> ?? ????? return 0; >>>> >>> _______________________________________________ >>> dri-devel mailing list >>> dri-devel at lists.freedesktop.o...

...if (fb && fb->obj[0]) { > >>> + nvbo = nouveau_gem_object(fb->obj[0]); > >>> nouveau_vma_del(&fbcon->vma); > >>> nouveau_bo_unmap(nvbo); > >>> nouveau_bo_unpin(nvbo); > >>> - drm_framebuffer_put(&nouveau_fb->base); > >>> + drm_framebuffer_put(fb); > >>> } > >>> return 0; > >>> > >> _______________________________________________ > >> Nouveau mailing list > >> Nouveau at lists.freedesktop.or...

...;>>>>> + nvbo = nouveau_gem_object(fb->obj[0]); >>>>>> nouveau_vma_del(&fbcon->vma); >>>>>> nouveau_bo_unmap(nvbo); >>>>>> nouveau_bo_unpin(nvbo); >>>>>> - drm_framebuffer_put(&nouveau_fb->base); >>>>>> + drm_framebuffer_put(fb); >>>>>> } >>>>>> return 0; >>>>>> >>>>> _______________________________________________ >>>>> dri-devel mailing li...

...ouveau_gem_object(fb->obj[0]); > >>>>>>> nouveau_vma_del(&fbcon->vma); > >>>>>>> nouveau_bo_unmap(nvbo); > >>>>>>> nouveau_bo_unpin(nvbo); > >>>>>>> - drm_framebuffer_put(&nouveau_fb->base); > >>>>>>> + drm_framebuffer_put(fb); > >>>>>>> } > >>>>>>> return 0; > >>>>>>> > >>>>>> __________________________________________...

...object_reference drm_mode_object_get do_replace drm_mode_object_unreference drm_mode_object_put do_replace drm_connector_reference drm_connector_get do_replace drm_connector_unreference drm_connector_put do_replace drm_framebuffer_reference drm_framebuffer_get do_replace drm_framebuffer_unreference drm_framebuffer_put do_replace drm_gem_object_reference drm_gem_object_get do_replace drm_gem_object_unreference drm_gem_object_put do_replace __drm_gem_object_unreference __drm_gem_object_put do_replace drm_gem_object_unreference_unlocked drm_gem_object_put_unlocked do_replace drm_property_reference_blob drm_property...

...ouveau_fbcon.c @@ -429,7 +429,7 @@ nouveau_fbcon_destroy(struct drm_device *dev, struct nouveau_fbdev *fbcon) nouveau_vma_del(&nouveau_fb->vma); nouveau_bo_unmap(nouveau_fb->nvbo); nouveau_bo_unpin(nouveau_fb->nvbo); - drm_framebuffer_unreference(&nouveau_fb->base); + drm_framebuffer_put(&nouveau_fb->base); } return 0; -- 2.14.4

...-- drm_connector_reference(object) > -+ drm_connector_get(object) > -| > -- drm_connector_unreference(object) > -+ drm_connector_put(object) > -| > -- drm_framebuffer_reference(object) > -+ drm_framebuffer_get(object) > -| > -- drm_framebuffer_unreference(object) > -+ drm_framebuffer_put(object) > -| > -- drm_gem_object_reference(object) > -+ drm_gem_object_get(object) > -| > -- drm_gem_object_unreference(object) > -+ drm_gem_object_put(object) > -| > -- __drm_gem_object_unreference(object) > -+ __drm_gem_object_put(object) > -| > -- drm_gem_object_...

...+451,7 @@ nouveau_fbcon_destroy(struct drm_device *dev, struct nouveau_fbdev *fbcon) nouveau_bo_vma_del(nouveau_fb->nvbo, &nouveau_fb->vma); nouveau_bo_unmap(nouveau_fb->nvbo); nouveau_bo_unpin(nouveau_fb->nvbo); - drm_framebuffer_unreference(&nouveau_fb->base); + drm_framebuffer_put(&nouveau_fb->base); } return 0; diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c index 2170534..653425c 100644 --- a/drivers/gpu/drm/nouveau/nouveau_gem.c +++ b/drivers/gpu/drm/nouveau/nouveau_gem.c @@ -281,7 +281,7 @@ nouveau_gem_ioctl_new(str...

...destroy(struct drm_device *dev, struct nouveau_fbdev *fbcon) > nouveau_bo_vma_del(nouveau_fb->nvbo, &nouveau_fb->vma); > nouveau_bo_unmap(nouveau_fb->nvbo); > nouveau_bo_unpin(nouveau_fb->nvbo); > - drm_framebuffer_unreference(&nouveau_fb->base); > + drm_framebuffer_put(&nouveau_fb->base); > } > > return 0; > diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c > index 2170534..653425c 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_gem.c > +++ b/drivers/gpu/drm/nouveau/nouveau_gem.c > @@ -2...

...struct nouveau_fbdev *fbcon) drm_fb_helper_fini(&fbcon->helper); if (nouveau_fb && nouveau_fb->nvbo) { - nouveau_vma_del(&nouveau_fb->vma); + nouveau_vma_del(&fbcon->vma); nouveau_bo_unmap(nouveau_fb->nvbo); nouveau_bo_unpin(nouveau_fb->nvbo); drm_framebuffer_put(&nouveau_fb->base); diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.h b/drivers/gpu/drm/nouveau/nouveau_fbcon.h index 73a7eeba3973..1796d8824580 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.h +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.h @@ -31,6 +31,8 @@ #include "nouveau_d...