search for: drm_fbdev_emul

Ilia Mirkin wrote: > I suspect the fb0 issue is because you disabled > CONFIG_DRM_FBDEV_EMULATION? Does the freeze also happen with 4.3? Any > chance you could bisect? I saw this config option, but I didn't realize that. The issue also occurs with 4.3. I even tried 4.3-rc1 with the same results. Would the DRM_FBDEV_EMULATION effect 3D? > On Mon, Jan 11, 2016 at 7:23 PM, Wakko...

Hi Am 03.07.19 um 21:27 schrieb Noralf Tr?nnes: > > > Den 03.07.2019 10.32, skrev Thomas Zimmermann: >> DRM client buffers are permanently mapped throughout their lifetime. This >> prevents us from using generic framebuffer emulation for devices with >> small dedicated video memory, such as ast or mgag200. With fb buffers >> permanently mapped, such devices

Hi Am 03.07.19 um 21:27 schrieb Noralf Tr?nnes: > > > Den 03.07.2019 10.32, skrev Thomas Zimmermann: >> DRM client buffers are permanently mapped throughout their lifetime. This >> prevents us from using generic framebuffer emulation for devices with >> small dedicated video memory, such as ast or mgag200. With fb buffers >> permanently mapped, such devices

...bdev_client_funcs = { .hotplug = drm_fbdev_client_hotplug, }; +static int _drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp, bool use_shadow) +{ + struct drm_fb_helper *fb_helper; + int ret; + + WARN(dev->fb_helper, "fb_helper is already set!\n"); + + if (!drm_fbdev_emulation) + return 0; + + fb_helper = kzalloc(sizeof(*fb_helper), GFP_KERNEL); + if (!fb_helper) + return -ENOMEM; + + ret = drm_client_init(dev, &fb_helper->client, "fbdev", &drm_fbdev_client_funcs); + if (ret) { + kfree(fb_helper); + DRM_DEV_ERROR(dev->dev, "Failed to...

On Fri, Jan 15, 2016 at 5:04 PM, Wakko Warner <wakko at animx.eu.org> wrote: > Ilia Mirkin wrote: >> I suspect the fb0 issue is because you disabled >> CONFIG_DRM_FBDEV_EMULATION? Does the freeze also happen with 4.3? Any >> chance you could bisect? > > I saw this config option, but I didn't realize that. > The issue also occurs with 4.3. I even tried 4.3-rc1 with the same results. > > Would the DRM_FBDEV_EMULATION effect 3D? Shouldn't, b...

...plug, > }; > > +static int _drm_fbdev_generic_setup(struct drm_device *dev, unsigned > int preferred_bpp, bool use_shadow) > +{ > + struct drm_fb_helper *fb_helper; > + int ret; > + > + WARN(dev->fb_helper, "fb_helper is already set!\n"); > + > + if (!drm_fbdev_emulation) > + return 0; > + > + fb_helper = kzalloc(sizeof(*fb_helper), GFP_KERNEL); > + if (!fb_helper) > + return -ENOMEM; > + > + ret = drm_client_init(dev, &fb_helper->client, "fbdev", > &drm_fbdev_client_funcs); > + if (ret) { > + kfree(fb_help...

...plug, > }; > > +static int _drm_fbdev_generic_setup(struct drm_device *dev, unsigned > int preferred_bpp, bool use_shadow) > +{ > + struct drm_fb_helper *fb_helper; > + int ret; > + > + WARN(dev->fb_helper, "fb_helper is already set!\n"); > + > + if (!drm_fbdev_emulation) > + return 0; > + > + fb_helper = kzalloc(sizeof(*fb_helper), GFP_KERNEL); > + if (!fb_helper) > + return -ENOMEM; > + > + ret = drm_client_init(dev, &fb_helper->client, "fbdev", > &drm_fbdev_client_funcs); > + if (ret) { > + kfree(fb_help...

...drivers have already figured out other workarounds for this. If other > drivers do end up needing this in the future, we can just move this > back into drm_fb_helper again. > > Changes since v3: > - Actually check if fb_helper is NULL in both new helpers > - Actually check drm_fbdev_emulation in both new helpers > - Don't fire off a fb_helper hotplug unconditionally; only do it if > the following conditions are true (as otherwise, calling this in the > wrong spot will cause Bad Things to happen): > - fb_helper hotplug handling was actually inhibited previously...

...is option provides kernel modules that can be used to run various selftests on parts of the DRM api. This option is not @@ -113,7 +111,6 @@ config DRM_FBDEV_OVERALLOC config DRM_FBDEV_LEAK_PHYS_SMEM bool "Shamelessly allow leaking of fbdev physical address (DANGEROUS)" depends on DRM_FBDEV_EMULATION && EXPERT - default n help In order to keep user-space compatibility, we want in certain use-cases to keep leaking the fbdev physical address to the @@ -247,7 +244,6 @@ config DRM_VKMS tristate "Virtual KMS (EXPERIMENTAL)" depends on DRM select DRM_KMS_HELPER...

Please keep me in the CC. I am not subscribed to this list. When booting 4.4.0 on one of my systems, when nouveau loads, the screen goes into powersave. It doesn't appear to register the fb0 device. When X starts up, the screen comes back and I'm able to login. When launching anything that accesses 3D, the screen freezes. Nothing is logged in either X or dmesg. This same system works

...er. It seems that other DRM drivers have already figured out other workarounds for this. If other drivers do end up needing this in the future, we can just move this back into drm_fb_helper again. Changes since v3: - Actually check if fb_helper is NULL in both new helpers - Actually check drm_fbdev_emulation in both new helpers - Don't fire off a fb_helper hotplug unconditionally; only do it if the following conditions are true (as otherwise, calling this in the wrong spot will cause Bad Things to happen): - fb_helper hotplug handling was actually inhibited previously - fb_helper actua...

...er. It seems that other DRM drivers have already figured out other workarounds for this. If other drivers do end up needing this in the future, we can just move this back into drm_fb_helper again. Changes since v3: - Actually check if fb_helper is NULL in both new helpers - Actually check drm_fbdev_emulation in both new helpers - Don't fire off a fb_helper hotplug unconditionally; only do it if the following conditions are true (as otherwise, calling this in the wrong spot will cause Bad Things to happen): - fb_helper hotplug handling was actually inhibited previously - fb_helper actua...

This is the latest version of https://patchwork.freedesktop.org/series/46815/ With a bunch of fixes to the new fb_helper to prevent it from breaking module loading/unloading with nouveau. Also; lots of documentation fixes and one fix in response to a kbuild bot. Lyude Paul (8): drm/nouveau: Fix bogus drm_kms_helper_poll_enable() placement drm/nouveau: Enable polling even if we have runtime

...each topology reference/dereference will be printed to the + kernel log once a port or branch device's topology refcount reaches 0. + + This has the potential to use a lot of memory and print some very + large kernel messages. If in doubt, say "N". + config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 5b5c0b3b3c0e..18f9a02927d9 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_d...

...each topology reference/dereference will be printed to the + kernel log once a port or branch device's topology refcount reaches 0. + + This has the potential to use a lot of memory and print some very + large kernel messages. If in doubt, say "N". + config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 428160270482..cedfa281a22e 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_d...

...modules that can be used to run > various selftests on parts of the DRM api. This option is not > @@ -113,7 +111,6 @@ config DRM_FBDEV_OVERALLOC > config DRM_FBDEV_LEAK_PHYS_SMEM > bool "Shamelessly allow leaking of fbdev physical address (DANGEROUS)" > depends on DRM_FBDEV_EMULATION && EXPERT > - default n > help > In order to keep user-space compatibility, we want in certain > use-cases to keep leaking the fbdev physical address to the > @@ -247,7 +244,6 @@ config DRM_VKMS > tristate "Virtual KMS (EXPERIMENTAL)" > depe...

Latest version of https://patchwork.freedesktop.org/series/46815/ , with one small change re: ilia Lyude Paul (5): drm/nouveau: Fix bogus drm_kms_helper_poll_enable() placement drm/nouveau: Remove duplicate poll_enable() in pmops_runtime_suspend() drm/nouveau: Fix deadlock with fb_helper with async RPM requests drm/nouveau: Use pm_runtime_get_noresume() in connector_detect()

Next version of https://patchwork.freedesktop.org/series/46815/ Same as previous version, but some small changes made to commit messages and acks/rbs have been added Lyude Paul (5): drm/nouveau: Fix bogus drm_kms_helper_poll_enable() placement drm/nouveau: Remove duplicate poll_enable() in pmops_runtime_suspend() drm/nouveau: Fix deadlock with fb_helper with async RPM requests

Latest version of https://patchwork.freedesktop.org/series/46815/ with some significant improvements: - I finally figured out a clean way to do this entirely with runtime PM helpers, no avoiding grabbing refs required! - Since this new method removes the need for a lot of the other changes I made (although we probably still want those changes, but not for fixing these deadlocks)

This is the latest version of https://patchwork.freedesktop.org/series/46815/ I moved everything out of fb_helper and back into nouveau, because it seems that other drivers actually do have this handled already as far as I can tell. Lyude Paul (13): drm/nouveau: Fix bogus drm_kms_helper_poll_enable() placement drm/nouveau: Remove duplicate poll_enable() in pmops_runtime_suspend()